From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45D93C5478A for ; Wed, 21 Feb 2024 21:16:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD7326B008C; Wed, 21 Feb 2024 16:16:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A86546B0092; Wed, 21 Feb 2024 16:16:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94E126B0093; Wed, 21 Feb 2024 16:16:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 822FF6B008C for ; Wed, 21 Feb 2024 16:16:35 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5B4EAA1016 for ; Wed, 21 Feb 2024 21:16:35 +0000 (UTC) X-FDA: 81817069950.16.6F13EC1 Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com [209.85.210.49]) by imf19.hostedemail.com (Postfix) with ESMTP id 90EB61A001C for ; Wed, 21 Feb 2024 21:16:33 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b="e/T86gHy"; dmarc=pass (policy=none) header.from=soleen.com; spf=pass (imf19.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.210.49 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708550193; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YWpAXMfptvXBWhPj/Zu9FAZfSnAxEQBXKk45RWYFa4c=; b=2LFbwFYmuH7CJp/tSD91VE0gM0tSw/8rRn8csZbh445fWFYQWflghwvnHjLPM5ERTv4qmm Hw7jX/JVE8A1Ek3tpjQct2jAnmb4MJtnYtMH4nM5F58rCry+g2mC+xHCYMj/Qv/25/Pf3J a+oqTnUc9dw98Mj9GO3SlhY4lKMQ6ms= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b="e/T86gHy"; dmarc=pass (policy=none) header.from=soleen.com; spf=pass (imf19.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.210.49 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708550193; a=rsa-sha256; cv=none; b=bhMnW8rE5vctDg1ELegZwzoZk2cLs+F1snASP20LO0Q5LSY4fYQIKC7hZONFOI1jy0osER 5LqywfM7Sax3iIlv+QJI4kqXaaahpxARnRaArXqJw8hvEIKOaJhIxmFdQHacRJPRtO4bwf OTzSCzKYSjPqlwggxl3aWeoUT2tuvIQ= Received: by mail-ot1-f49.google.com with SMTP id 46e09a7af769-6e2da00185dso3808961a34.1 for ; Wed, 21 Feb 2024 13:16:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen-com.20230601.gappssmtp.com; s=20230601; t=1708550192; x=1709154992; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YWpAXMfptvXBWhPj/Zu9FAZfSnAxEQBXKk45RWYFa4c=; b=e/T86gHyubQhqtJBHe1vhaHZ2wnIfMYJAkKwh0D7QwXk9IM0nI0qYzfN46e1GSAE8P gooDTtPJfLvl07isz9AFyzkq7L17YsdPPVgDlsJUv9tTNHqTo6JoYEIw2mvge9kyvwBT SmqWYpZtOtpVbGsK7kSMLXV/TXzGzY222+4ozLSnrImmbL+KwtcwMgUiNw+LmmibF1NO nuDGput/Wb3Ffa7jM3tSLYf1Al+a2BB70Jyn0dFRzzkg8gnsiOkxbAgWgdUwqMh/Wvbe 2q9Eq1l1gnSH5AOtGCvV9nJik7qiuCvdwgW7EFemlOQhJlPsbm+ycA7v/mt97CH8q0md HNyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708550192; x=1709154992; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YWpAXMfptvXBWhPj/Zu9FAZfSnAxEQBXKk45RWYFa4c=; b=KvGv8KxFN5xpa8TTreO1jz5V9yOxhIsDL/ZNadymJ2l/WjTahKPWKdAaLZ7r+X9PLP 7PMvzrBLhh4ZFZO5W9vlYp1gjYSHeiS1rQZHmsjK/xJLLxzrdgmH/t+gfZqJStD3ioj7 ECu8m7mue0qad8KMK/3mTJ4+f+ywuOBlqoouNTHD6UIE5bJr7idUeNII+SqsXg0pf4ii /SL4EFWYKrTDld3sZut+6idf+xpMCbwoB+evUt45PzmAnRD51tJGZLUK/wHcNgyxbJOc vQKnXH3EMwMD8xEnLewijwAcC5F1OeQ59LgwgJ2qzCMjDcSZKv4nyL1wwqwdQdMuQQzO zTew== X-Forwarded-Encrypted: i=1; AJvYcCVWBQMZ9Zab4AJ1s1xgJGAoGt0vZVANLgGhI1F2Y9cGXcLQCp0b2CYRF/RHXaZ7UXwQrUcLf+epN/B1mhWUbpkw9+M= X-Gm-Message-State: AOJu0YzoDdEf8cZYdIprmHxMXlaotpjwd8nl/kTHy5Kcrhk9fmm+gGoi MGSYxq4prYYpMsqrwMu+In17KxUjAjjzTvV7X/gASRO8Ds+hDguntz++h3Cm7Q2VDOMpBaWFZYt BWpmWSIGyS4jWWci8xxxbFvajukPJ74QNlVRozQ== X-Google-Smtp-Source: AGHT+IFlqSylMCeI6KGNha3000K+lFHjDKANDOKnq2alJEDr9oyGg2RKFtJGNI+yjwYm19RTm7J/7Xp71REjuXyqMMY= X-Received: by 2002:a05:6830:1345:b0:6e2:f2cc:e985 with SMTP id r5-20020a056830134500b006e2f2cce985mr19962028otq.13.1708550192733; Wed, 21 Feb 2024 13:16:32 -0800 (PST) MIME-Version: 1.0 References: <20240221194052.927623-1-surenb@google.com> <20240221194052.927623-4-surenb@google.com> In-Reply-To: <20240221194052.927623-4-surenb@google.com> From: Pasha Tatashin Date: Wed, 21 Feb 2024 16:15:56 -0500 Message-ID: Subject: Re: [PATCH v4 03/36] mm/slub: Mark slab_free_freelist_hook() __always_inline To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 90EB61A001C X-Stat-Signature: 6zx41ridns4fdeiexm97k9mqcgmt8fam X-Rspam-User: X-HE-Tag: 1708550193-4274 X-HE-Meta: U2FsdGVkX18GTSg/caig9kQmDSTEifI87oK3N9yW04PIskH2NPUaKK0BiacspvNjbzwDJSrCI2xDfyd+fgqDmE5QE8I7IWdgmwLjjB2Cg4EqEesYxV6YUO5vcLpfy0RKV5nygw9iwu+g2chNYWHWAFilfSpVMJEj/xzoKfPdPESJOoj4xmJmwe+xhiQVXkkwJgZIvoOLe2rkFk/fZ8cM9dcjoO6gusrteBd48r8GR4eKYqpJephLwlukpp2TRY7SHAuxXfb2i3EEE4Lbnm/4MEReAr9dE0Z7SenEgecwOrudplgANev1XItp+CUVwElyCp7I2QJE7ufbDyb6CWPbHBOMFzBb3G3YMurXlBEzuDlmFmckGCl+Nzy8storvq4Jcc1n7vNTJL7tDwZ/Fkum7a36cdw1AeJExBBOU+HHj2RpX3IXR2VBeFeHyn499Zb0nuJzjA2pIeXcjZmcIlYBTbqe19SZ0asM79ivN4gYbFK8C+ukCt1lJlBU6H6ObOVx1TM4dmayHBMAS2UCyVdk4/I2U0Rtc0XpSmjFwr9KJZ9DL+HgsVmKOMZUazW7aXQAgwLL4/uHZMKwdSJ8UrpS+ESPaLPXpNqcJlZdRB9UR8XK5GDxQRl355IyDHpydRcrsLIkHqeAs79p+v84WBVVXMmdtCGhX58JJ/PfHVVdCK4poGRgX/KM+1YTNa6JsBj4wfOrI/lQgqonMZTXxyBWieMOPqkSDp23OdeDxlJJkvXTvL/PneKTnvDulbtaGZoNSPebrxTNsXafK8Or8EnCrzXvYBIeECUd5lObMWa6jnzrF1hMSNphRlWIX0PWm/R7FEntqZ8Azlo7HpPQL53VZ7Yqje/xeAExmoZu1adk3lTB9S9hnrTO5wbbrkyYoXukczVNM+EY/ybmtqfAREwe7MZmjT4WKbzvcCH2mfu7Oqki8NrOAoushq7tPfsZN5BibRng3bc5hrnlxLwwTg9 RBiI5+Vv en+YzmSo6BLT4RMwQYjgyxcyzyQ9jgPaeXjNY6/YAVtLNXdLW/OWPkdXKVAkukrxARaabYfn2DHqyGqkbFESfa7XqHu5pRfkHLW3f0XcUZ/Id8U0l8hlaWTXLU0Fx5sjlGL4NFz1ocyB6oPQP77xiv/hJw/o2lpTHczg/vFR12DSVqq0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 21, 2024 at 2:41=E2=80=AFPM Suren Baghdasaryan wrote: > > From: Kent Overstreet > > It seems we need to be more forceful with the compiler on this one. > This is done for performance reasons only. > > Signed-off-by: Kent Overstreet > Signed-off-by: Suren Baghdasaryan > Reviewed-by: Kees Cook > --- > mm/slub.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 2ef88bbf56a3..d31b03a8d9d5 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -2121,7 +2121,7 @@ bool slab_free_hook(struct kmem_cache *s, void *x, = bool init) > return !kasan_slab_free(s, x, init); > } > > -static inline bool slab_free_freelist_hook(struct kmem_cache *s, > +static __always_inline bool slab_free_freelist_hook(struct kmem_cache *s= , __fastpath_inline seems to me more appropriate here. It prioritizes memory vs performance. > void **head, void **tail, > int *cnt) > { > -- > 2.44.0.rc0.258.g7320e95886-goog >