From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9E9DC3DA4A for ; Thu, 8 Aug 2024 19:06:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 62A756B009A; Thu, 8 Aug 2024 15:06:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B15C6B009C; Thu, 8 Aug 2024 15:06:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 452BB6B009E; Thu, 8 Aug 2024 15:06:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 210016B009A for ; Thu, 8 Aug 2024 15:06:13 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B6302812B5 for ; Thu, 8 Aug 2024 19:06:12 +0000 (UTC) X-FDA: 82430008584.22.BE726E8 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) by imf20.hostedemail.com (Postfix) with ESMTP id 01E101C002F for ; Thu, 8 Aug 2024 19:06:10 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=zJZAYhYI; dmarc=pass (policy=none) header.from=soleen.com; spf=pass (imf20.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.222.175 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723143898; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7A+R6yMU9d6rQjFJ5o1iuGrbrwZ+/nqdudiFO+Vr3EM=; b=jujhFBTIj25bfQ/f1aLYd1Rmli/pYmEtfmW0tX8uHhk2daKgEUJ0u0b4QEwGaUVOAa2qob wQUlexlE9nxubfusmAfgBK8tA7BmUJW2XatH1GtR9dG23ENoNYpd5Au1PxWKV3Sz3XkFnZ ByWiNX48QQMqK0ZOD5fDJfD1ng3UKA4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723143898; a=rsa-sha256; cv=none; b=JkJvFy57NhmEoiKurvT7OjGpET1QLJvplfhZh3WxG3v9AyhWXY7pyk8TqLoTzqvem2JRAb j9wkazT/aReDpZqf5/KTM1WYUgY2J6Vb0vKElUbpm/k7gFlv/ZjwAVZP3NfusNC5caAFuJ GfEEqXWqjdyv3MUlSnyq86ZsMWoD93A= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=zJZAYhYI; dmarc=pass (policy=none) header.from=soleen.com; spf=pass (imf20.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.222.175 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-7a1d42da3e9so77139185a.1 for ; Thu, 08 Aug 2024 12:06:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen-com.20230601.gappssmtp.com; s=20230601; t=1723143970; x=1723748770; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7A+R6yMU9d6rQjFJ5o1iuGrbrwZ+/nqdudiFO+Vr3EM=; b=zJZAYhYI6XZE0ogjc3G/ckFH8mAblKTfmr4MCzXd/a0EHbzJSdOfr0FkSY3qT6927/ rOedq1F7bp/p0C9YH4MmTfHdxJp6O6czF76kNHmqVQS8ozAWfXEzNHoP5fxgiywYQ5wu t2/xWlEWAgdI4F+48dukLfDTnPztl2HMCMFGZm+v8DLOqWYt0ydPy5ZD8A1bncnCOcjd XSXUFhk4h4RmSrP9C40q4mx/A8FZHBLjlUZIonuBzlnwsgoLcCtsfIvNwUXr+ZtVJVM5 ZSqi0Mi0QHY2oeciiCeFtvyWbEBy6yEfCQGmNHCn8SjN/WGe4Mw8SXx6SDcRtBm1UP0R 9tZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723143970; x=1723748770; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7A+R6yMU9d6rQjFJ5o1iuGrbrwZ+/nqdudiFO+Vr3EM=; b=OT37LOiBkm5hKAVrqXj84Krv1SDHdWENO7FDhhtztKqJx2sDCWUFHeTJhqwZca6ZQa JeOe2o5ZI/lfpVhqe7H8O1pSpI4iHWJ6MHRhChykjAdR8XHGa2KnnCBtZsZwZgjtJ6uq HcWeUThGI5EpE296q3s0Wblp32shqh+/QC6/KgE8AaIwiIwkJ9j/AsqQluZOD2CoJxsa 3+3hinNclEnDi/sT5HIBr/nNpZa+yCEZq9Le7Mf4x2NbEE0SVIfO6xYRjvltZvECBfEw 0emyZ8pbRi9gLgvgmb8JUXg4Gmw2M8/rYz5hKgZutoVnZEkBVcE8iB7zTGMHda/SiCVu R5UQ== X-Forwarded-Encrypted: i=1; AJvYcCUIslkhDFSdhacj2Wp00OsexbypV+WEEqMEw4prAD0sMQa8Vl9F3T21XDCEWg9kU5RH+hrCwsXbMRB0DTdmW+Z4TKw= X-Gm-Message-State: AOJu0Yw6kM6AKQ7i0szQWxphfrY+evkh0aKhJuYxSG94r50Hjrdx3/02 UUjbq3qoteO+dMKySSDwrkFMPzkZJfEqXqJNBiDB1dridCc1iCXoBYmy4WUcSmsElf2wvM28RUX mg6Qx2JfrO0yiG/oOFmH9kEGJ+cKOxdbP8nMB6Q== X-Google-Smtp-Source: AGHT+IGCNR6tOOc7zjRc+Z6edE+0iR8kbni5q1QhFVJ5IjBamDJUsGTUSZ80r6e+xP9C/Z5Z3E87bJ+J0HUI7bU8HDE= X-Received: by 2002:a05:620a:4445:b0:7a3:56dc:d414 with SMTP id af79cd13be357-7a381872973mr296729185a.49.1723143970021; Thu, 08 Aug 2024 12:06:10 -0700 (PDT) MIME-Version: 1.0 References: <20240808154237.220029-1-pasha.tatashin@soleen.com> <20240808154237.220029-5-pasha.tatashin@soleen.com> In-Reply-To: From: Pasha Tatashin Date: Thu, 8 Aug 2024 15:05:32 -0400 Message-ID: Subject: Re: [PATCH v3 4/4] mm: don't account memmap per-node To: Alison Schofield Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-cxl@vger.kernel.org, cerasuolodomenico@gmail.com, hannes@cmpxchg.org, j.granados@samsung.com, lizhijian@fujitsu.com, muchun.song@linux.dev, nphamcs@gmail.com, rientjes@google.com, rppt@kernel.org, souravpanda@google.com, vbabka@suse.cz, willy@infradead.org, dan.j.williams@intel.com, yi.zhang@redhat.com, david@redhat.com, yosryahmed@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 01E101C002F X-Stat-Signature: d5uixkoxo8fcpjkcwefzn16eg4mwsap3 X-Rspam-User: X-HE-Tag: 1723143970-613536 X-HE-Meta: U2FsdGVkX1/alK8stBybGcUnGCwFSzqt75Rc/gpr4DQ4jrdsLB0pE0nltkSq3EJ9ocURSasj2rUZvMtRiGuqkK3UhaNS5yv+pZzNvMlyNOrVlWiImixfu+q8zwmjMd5Wxbt2+C4gvE2SPPT5uiLzk+FHrapFwpSQUUIhA22ZNGpVqlYQbtb2FgDoGlsHwr7Va8A609H+OOlyyf9eW7brWOVQ+OvY2fKG/X9NCHe33gCW+vAGCLXsbDFmIQoHMAQG8kKnJq2CXkQpdnfUZJiEYr973x1ua64s6iRRVsaKSRJ0wRqZiPlsq+czYLG6egobSo3UUTi1XLzX0w9EpxnrOCvd5izuZfFd5sMPDWnuCZeU67cjLHMaq/RuudTBp/Bb+ajluMtnSNclGg5s5KQ5y1ucwXNHzVspamQIIwvCiWo9b04Ki+JbNprhfT2Rm2/9+Lb9ThY/LpMf0HcBXPwTvPLcTbIg3JxH3R3rORnNOOi0Ic7T7eSxkitbgmdeuivk3v/Q1LnMXZP4g7+IF+zg1PmmYCr7r2gJCT6H/E9uT1M/31ejNdRjxEXy71iLjB8trG2mJueGa03VckTA32I3y0H2HFx2aod9gb4dSfRpdHweDHgN/TPyZrhDs28AhJCHhq6WW01wdO5GXYm6ywL0n4wtRsPK5B/9xL3cD77iwR9SNxjZHdW1gBc9WvSdrHl75FTHH2IYonUNi168SdIbxAjir0M+wcUsGTQHvf6yFXk4XHdb7FQK5C06qNbbP9cYA73mphmZBd05wFC6TOhd25cB0LlaHiq3/jt9qeT3J7U07gmN2kBVmo1odfBDaQD1N2sH1M0udiMN0N7/5rSiYxQFbs8zmcYxUQtGtM4dnWJscuwhZbnLiEt9VE6sSKGEAvySILfwu7e+qfBGVU8LUx6O9G21o1ODMSK9aUoyyCllZ/JJBjogADNK4Kzkk6ZAQz/TOcBnHRL0EYiGZUK KEVe527/ zDZ2FVFZSjZvMkioQGgq197J3uw8hULC8XimXIQYWUmLk7WtsTY6HWzfx6XqUoZwesfOUEsJkK1EarNRlNS7W6gyINeCMRTCK47FbO7ypdFxhAlYVuc6+/ggEqwmXyi+egy1cuWGvnpCAPRyYJ9ZEkmiNjnyk3xE+9EGvI1QpCYYWh0ZF8ZPGdfiRyOqPK4utoOk5ebFQTK3q9GJNBaddjkZEpyc2IAGa/HimCsE7sv4uBRiSCZMFNpTawA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000034, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 8, 2024 at 2:55=E2=80=AFPM Alison Schofield wrote: > > On Thu, Aug 08, 2024 at 03:42:37PM +0000, Pasha Tatashin wrote: > > Currently, when memory is hot-plugged or hot-removed the accounting is > > done based on the assumption that memmap is allocated from the same nod= e > > as the hot-plugged/hot-removed memory, which is not always the case. > > > > In addition, there are challenges with keeping the node id of the memor= y > > that is being remove to the time when memmap accounting is actually > > performed: since this is done after remove_pfn_range_from_zone(), and > > also after remove_memory_block_devices(). Meaning that we cannot use > > pgdat nor walking though memblocks to get the nid. > > > > How about directly include the failing cases and user visible impacts as > reported in the Tags appended below. Do you mean adding panic backtraces or repro steps to the commit log?