linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Pasha Tatashin <pasha.tatashin@soleen.com>
To: Alison Schofield <alison.schofield@intel.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	 linux-mm@kvack.org, linux-cxl@vger.kernel.org,
	cerasuolodomenico@gmail.com,  hannes@cmpxchg.org,
	j.granados@samsung.com, lizhijian@fujitsu.com,
	 muchun.song@linux.dev, nphamcs@gmail.com, rientjes@google.com,
	 rppt@kernel.org, souravpanda@google.com, vbabka@suse.cz,
	willy@infradead.org,  dan.j.williams@intel.com,
	yi.zhang@redhat.com, david@redhat.com,  yosryahmed@google.com
Subject: Re: [PATCH v3 4/4] mm: don't account memmap per-node
Date: Thu, 8 Aug 2024 15:05:32 -0400	[thread overview]
Message-ID: <CA+CK2bD6wMh2svqf3vhj=53=EUWYtQJmJXyTRkLBm49q7KJFtg@mail.gmail.com> (raw)
In-Reply-To: <ZrUUnm/pEpPS9ltC@aschofie-mobl2>

On Thu, Aug 8, 2024 at 2:55 PM Alison Schofield
<alison.schofield@intel.com> wrote:
>
> On Thu, Aug 08, 2024 at 03:42:37PM +0000, Pasha Tatashin wrote:
> > Currently, when memory is hot-plugged or hot-removed the accounting is
> > done based on the assumption that memmap is allocated from the same node
> > as the hot-plugged/hot-removed memory, which is not always the case.
> >
> > In addition, there are challenges with keeping the node id of the memory
> > that is being remove to the time when memmap accounting is actually
> > performed: since this is done after remove_pfn_range_from_zone(), and
> > also after remove_memory_block_devices(). Meaning that we cannot use
> > pgdat nor walking though memblocks to get the nid.
> >
>
> How about directly include the failing cases and user visible impacts as
> reported in the Tags appended below.

Do you mean adding panic backtraces or repro steps to the commit log?


  reply	other threads:[~2024-08-08 19:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-08 15:42 [PATCH v3 0/4] Fixes for memmap accounting Pasha Tatashin
2024-08-08 15:42 ` [PATCH v3 1/4] mm: update the memmap stat before page is freed Pasha Tatashin
2024-08-08 17:17   ` Yosry Ahmed
2024-08-08 17:20     ` Yosry Ahmed
2024-08-08 17:37       ` Pasha Tatashin
2024-08-08 17:17   ` Fan Ni
2024-08-08 15:42 ` [PATCH v3 2/4] mm: don't account memmap on failure Pasha Tatashin
2024-08-08 17:18   ` Yosry Ahmed
2024-08-08 17:19   ` Fan Ni
2024-08-08 18:12   ` David Hildenbrand
2024-08-08 18:54     ` Pasha Tatashin
2024-08-08 15:42 ` [PATCH v3 3/4] mm: add system wide stats items category Pasha Tatashin
2024-08-08 18:20   ` David Hildenbrand
2024-08-08 19:01     ` Pasha Tatashin
2024-08-08 15:42 ` [PATCH v3 4/4] mm: don't account memmap per-node Pasha Tatashin
2024-08-08 18:26   ` David Hildenbrand
2024-08-08 19:03     ` Pasha Tatashin
2024-08-08 18:55   ` Alison Schofield
2024-08-08 19:05     ` Pasha Tatashin [this message]
2024-08-08 21:12       ` Alison Schofield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+CK2bD6wMh2svqf3vhj=53=EUWYtQJmJXyTRkLBm49q7KJFtg@mail.gmail.com' \
    --to=pasha.tatashin@soleen.com \
    --cc=akpm@linux-foundation.org \
    --cc=alison.schofield@intel.com \
    --cc=cerasuolodomenico@gmail.com \
    --cc=dan.j.williams@intel.com \
    --cc=david@redhat.com \
    --cc=hannes@cmpxchg.org \
    --cc=j.granados@samsung.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lizhijian@fujitsu.com \
    --cc=muchun.song@linux.dev \
    --cc=nphamcs@gmail.com \
    --cc=rientjes@google.com \
    --cc=rppt@kernel.org \
    --cc=souravpanda@google.com \
    --cc=vbabka@suse.cz \
    --cc=willy@infradead.org \
    --cc=yi.zhang@redhat.com \
    --cc=yosryahmed@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox