From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EC9EC4167B for ; Fri, 15 Dec 2023 21:11:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A4898D013C; Fri, 15 Dec 2023 16:11:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 553638D0121; Fri, 15 Dec 2023 16:11:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F4A08D013C; Fri, 15 Dec 2023 16:11:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 299C78D0121 for ; Fri, 15 Dec 2023 16:11:58 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 02D181A0583 for ; Fri, 15 Dec 2023 21:11:57 +0000 (UTC) X-FDA: 81570299916.20.7B0FFB8 Received: from mail-oa1-f41.google.com (mail-oa1-f41.google.com [209.85.160.41]) by imf29.hostedemail.com (Postfix) with ESMTP id 2F279120028 for ; Fri, 15 Dec 2023 21:11:56 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=D6ezksb3; dmarc=none; spf=pass (imf29.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.41 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702674716; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b9KJ+4BbcKeSEG7077PFa7FVZHENUrxS+8ivlb7RAxY=; b=W1xw06y602TCcw0G2v3RYGjayBRwTGWYDmo6avXh/ekmW1tzq+Z0EoN0KkLMhS8RSpygPS 2Gkd+SleSu4cVvQ/RNGX/PGMhaC01K/k9cx0XR3UI4aWoWbm4OD4/XSyPjE/30xhQC1U8v YNQ8iOUSql5zc0gUprYa+BD8S5c8Huk= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=D6ezksb3; dmarc=none; spf=pass (imf29.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.41 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702674716; a=rsa-sha256; cv=none; b=wzE2gb9OyoOhtuujG0f8A9ABxgDFbX3A+lDmnIX79DDXk+LHtb06nHMeSaB1uY8Ihhp21q 5q5T+/cjRWIGf3NQkevX3OT8JXlbFsVIh10EbZNHH1KhEzPn1Ib2El3moll1m5iJhKcgZt Dt4nWtNvNaNWaRgvFQhTSA7IHzHN/ys= Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-20308664c13so714264fac.3 for ; Fri, 15 Dec 2023 13:11:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1702674715; x=1703279515; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=b9KJ+4BbcKeSEG7077PFa7FVZHENUrxS+8ivlb7RAxY=; b=D6ezksb3YWwJVd4j+rwOYZtW0OaB0f4eNYNq1jDoJheVkONeUrXcxRVcP/7AT0jHEv ECKgRzI5OJgNK0DJBWidJjUQyLBQTft2qAB8ZC0mYYjY4DUbCJttwyYSxxmuxs/O0sAL q8GtY4IeLOrU2Lm60UafyfEafk/Xa8zYfpmZp33/9be0S7B5KaL45+BHoUko/Fsme9vl DwDQrhp7a9CrC5Azkb2Lnwf/spTUhwtSR6AQ4yTVg28jASotCndgcCc3Yb36M9BNUnDh Ur0W1SjYTY7TB5qqBwr9V65uvY7OyUaHx+GEPlZQHKPH3JFtXiDZlw5AlgzwyCLp09fA Onow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702674715; x=1703279515; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=b9KJ+4BbcKeSEG7077PFa7FVZHENUrxS+8ivlb7RAxY=; b=nB16w81uQjyhp1gCt7ayfaIZ06kKTJbtZ4BQMNO3WVzu7SbuLfWSV+KaDGRQpOfnlT sc06qFliW+qw9SwviJvkrb4Kp+B9pMc/hz1v7C289q3T3K4sUdLbWaKJ+lADHsfYg/V9 SN17BCGXvzDYZebUU+IDn2tzHMOL/AVsr37vO7X+HiFk6v/VR/pKY0KuggfXYXHuWOBN bJzPTWTbjOvWJPsDLY3gVexc6WnV0kuEEaS9dtJHu3i1tTj7O9xXP8zl+KJ2B3S9Kv53 faV4VUeOtekVuzfwJ45ZbfOgf1a/0MjAfeLgKSbQsKV0roQN5rgxUwl/i6ApO6IxGsba Oguw== X-Gm-Message-State: AOJu0YwQZp6kv0DA52Mvd0cbKguvIbgvDmFbG6QrqnJO6yvMsJO/HmkO XscbgyXwQKm2ZA9wfT8BSoKzNNHDZKV6UGzdSULdyQ== X-Google-Smtp-Source: AGHT+IFHrLpndT4XCwAesdcyNwQf00aMOvX02D4/8uxdog8acvbjKfsi57jpp2aqEyynfGVCKlt0IXuLjUhCsHgb3nk= X-Received: by 2002:a05:6870:c09:b0:203:7ccc:b6e8 with SMTP id le9-20020a0568700c0900b002037cccb6e8mr1214533oab.25.1702674715317; Fri, 15 Dec 2023 13:11:55 -0800 (PST) MIME-Version: 1.0 References: <20231130201504.2322355-1-pasha.tatashin@soleen.com> <20231130201504.2322355-11-pasha.tatashin@soleen.com> In-Reply-To: From: Pasha Tatashin Date: Fri, 15 Dec 2023 16:11:18 -0500 Message-ID: Subject: Re: [PATCH v2 10/10] iommu: account IOMMU allocated memory To: David Rientjes Cc: akpm@linux-foundation.org, alim.akhtar@samsung.com, alyssa@rosenzweig.io, asahi@lists.linux.dev, baolu.lu@linux.intel.com, bhelgaas@google.com, cgroups@vger.kernel.org, corbet@lwn.net, david@redhat.com, dwmw2@infradead.org, hannes@cmpxchg.org, heiko@sntech.de, iommu@lists.linux.dev, jernej.skrabec@gmail.com, jonathanh@nvidia.com, joro@8bytes.org, krzysztof.kozlowski@linaro.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, lizefan.x@bytedance.com, marcan@marcan.st, mhiramat@kernel.org, m.szyprowski@samsung.com, paulmck@kernel.org, rdunlap@infradead.org, robin.murphy@arm.com, samuel@sholland.org, suravee.suthikulpanit@amd.com, sven@svenpeter.dev, thierry.reding@gmail.com, tj@kernel.org, tomas.mudrunka@gmail.com, vdumpa@nvidia.com, wens@csie.org, will@kernel.org, yu-cheng.yu@intel.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 2F279120028 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 56rmr9nx6y7gsq7h849uqy4naaq3fdm9 X-HE-Tag: 1702674716-269564 X-HE-Meta: U2FsdGVkX197yUi6vIzRX7VX/2OJVFbjrCkoz+JaDrHqBHMZGlFZXJHPmRqvFeUsA0OOVVOhSoi2db4zrykxiC4uhMSbbGOQnJ5L954A0t9+sTVsn8HZryKrrgE4c32BCshgTtxNJ3pcQwd7DXHF9770COJFFjx/ZMeS1aZ0zY/c1rGUBWFcV++jj3KeXgjqaQa74sIa1CJkD+YHTnMfKxNdSfvNILVNAWvkMOcZ211GV+9Ezfz29Z1d2tPsPMXB7Ry+SnBkggMZIXKU3xgY2rMM+ofqQMHnJ4WHg/xWduA6GaWu92nEuyfPyeJjJzZtmECZjmjOuC0XBQgy6Vq3OAcGwPxQEbFGJS1U7gdv49YlZ1FaDi9VU1oa1H5u9ak8jhzjRvZdO/dwWQzwbwEC3MqFygUdDN+qQc9B9uF4s1q3u00HM8hDxzr7jKwFpPikc90fghRlX9+cXJqrXyu73X0kDcY+Oy32+zjAIEmqNVGxZ4Iyt0FZCgwA50lzk8GwQI2wIe50ki/ury4L0CReAv1iZfOe7fTwn/uxsydvEeHXlqA8o5rUrismeHKtYJ2H500M/s1V2DTFznDMhvk7TtQbe+RJ945KoH1NZcwp41sQZnakTV4ZybBleA3uRxY8yDrVzLt/28EH0Mw00OFb41IW+ysxiYk1OhbdyS4RQNxlBrL0f+ZzXM6uygV/PxiwuuCy0tP/8lQP9e4jh7X6AlWLSlWkAUmsBulvM2Fluy8xA34W/KRsnSKBtAF2DsVrKz0gxk9kfTfPUYUuHNEuUunnHBxM3OWnUj/c0bINX+0VApY8iuau+2klD+u16bQ7e9bbYI7ITNiA/fSPMGagDzzcXv24WCEvK3lqQOT5/Ta1mcDatZRsMYH99q1yAIzR/ezkymM+RBurSe94IT3fxC/yR3OV/GHUeMNT2Y73yxmfnMycYhlzice56ZtR/gcz6gpCkOOoNTqzsC4VcC8 ucQLJ+f7 Ro2J5ADCb8YF+5b1BT8hlcskaQu6b0QKPqpsIJOts0UqzF12go8EUhFDM3lfxgha2QYh0Ud2rWLzzmHEyluzWS3rHCtKSgkVO2lcjY/gUMTd1T/UIY3SDxIAYKo4s2/MEaQT9INdP526a6QyQqsgzkj3LKskTeZur1J/owZ/PX8dTxpPuDuusM027V4Srk0QceePu+LdxcvCLL4xrkVIWxGgBKBIwOJ3sDs39I3jH5J5/bYe5MraKyb6Dgsk7QROU6sTTYvnZIj87xG9wQUxUFPuUJj1vrQlLcpOEgehFyp3K13+y6d2kwy6W+LbnuuHF1iWx/EXOQNa24L4qv2Ch2w07/socLZeC4Pcn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst > > index 3f85254f3cef..e004e05a7cde 100644 > > --- a/Documentation/admin-guide/cgroup-v2.rst > > +++ b/Documentation/admin-guide/cgroup-v2.rst > > @@ -1418,7 +1418,7 @@ PAGE_SIZE multiple when read back. > > sec_pagetables > > Amount of memory allocated for secondary page tables, > > this currently includes KVM mmu allocations on x86 > > - and arm64. > > + and arm64 and IOMMU page tables. > > Hmm, if existing users are parsing this field and alerting when it exceeds > an expected value (a cloud provider, let's say), is it safe to add in a > whole new set of page tables? > > I understand the documentation allows for it, but I think potential impact > on userspace would be more interesting. Hi David, This is something that was discussed at LPC'23. I also was proposing a separate counter for iommu page tables, but it was noted that we specifically have sec_pagetables called this way to include all non regular CPU page tables, and we should therefore account for them together. Please also see this discussion from the previous version of this patch series: https://lore.kernel.org/all/CAJD7tkb1FqTqwONrp2nphBDkEamQtPCOFm0208H3tp0Gq2OLMQ@mail.gmail.com/ Pasha