From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94646C52D71 for ; Thu, 8 Aug 2024 19:02:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A3BC6B0092; Thu, 8 Aug 2024 15:02:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2537A6B0095; Thu, 8 Aug 2024 15:02:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11B906B009A; Thu, 8 Aug 2024 15:02:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E2AAD6B0092 for ; Thu, 8 Aug 2024 15:02:26 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8D86FA8008 for ; Thu, 8 Aug 2024 19:02:26 +0000 (UTC) X-FDA: 82429999092.17.7D00838 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by imf06.hostedemail.com (Postfix) with ESMTP id D1C0C180029 for ; Thu, 8 Aug 2024 19:02:24 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=DHkFPKi3; spf=pass (imf06.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=pass (policy=none) header.from=soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723143680; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y65uf6qqSRpIHJ9WMhbwfu83kOfz3UXQcvs4i5JT3n4=; b=gf2GQgCddsnFGTcAXzxXGEgeJ/au3Zwpq+J+wdpPe7PgdlA5CcfQZZjI8wS/IiGuuxHaGB Yh5MNCLuwY5eKEApFJIZFHhTB+gKC0rfJCyd8Fok1X4PpeB+qs6iX7YPkPs8AAMEw37SKe rLTW4I5vh8gDuA792Y93iqiq0CZbu8Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723143680; a=rsa-sha256; cv=none; b=NI17CcAr/kxRoqfr4XuxAXQhyItSq75tKZViajJuC2mIq20kpMSg/73WjS/yeCiLtGfM1w xwoVij9Zxhg8upJ4PWczSuJfk5jPXA5IMpTZU8rtuVTpMaOaj9RsYQvtTK3UhxmUcuODNe MeTgpaaXBVD3fIFD1cvQGC3shZXN+cg= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=DHkFPKi3; spf=pass (imf06.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=pass (policy=none) header.from=soleen.com Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-44ff9281e93so6809161cf.2 for ; Thu, 08 Aug 2024 12:02:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen-com.20230601.gappssmtp.com; s=20230601; t=1723143744; x=1723748544; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Y65uf6qqSRpIHJ9WMhbwfu83kOfz3UXQcvs4i5JT3n4=; b=DHkFPKi36PYLGWZSAc9+VeMTxgDClCBoY/XN/Esjrzh3Mc7W9yERtWlrTAhERY3rFL sqAqWARZoSqRX/F5R5Q6nqy5PLsRlZz4he4WgK838PfcupEeAo5Tyt7n+oe0MakNiqWV rmpt/Nepd9ujG//rgz5l08qMSTpfH7FZ7eNXROugIypea3E1ppPup/NzhZ77VJJcSCzg 6DtvbcGa19b2rcQBUVg8aSHMnLeBrxcuSSxWLCxD6IJFI9JLdkz0bMDdjssBSfzV7KCo Rbmy0wWRK1PEpvlWhmNeT6iX4wSOAYgN/xjiv2VllPRMXJpuQWyYjVWih9F9lhGISrkp kmzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723143744; x=1723748544; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y65uf6qqSRpIHJ9WMhbwfu83kOfz3UXQcvs4i5JT3n4=; b=pw2lsTa4Z+f5GM3A77ga1dB3NU2ISXMQq408WES91iOe5NExUrLF7b2LoRpwbBplb1 vagBGfTDsIMbmMd4HVPGXal2krf3Sz+jQxEw2XenhtDxgGI1pICFP1mzqwlvNRaF/pdM RIAecsUlAweuFWxbNSGe9oxsAJD63DwTZv+2trzgGiQVyT18LCIUPmnxy+O2dN+U1qLv bRS50J+/qPAxtTkoMy9inwlNJDaF6KB0+C33P9Rmzoq8/nbESdL3v2DYrWsfJHyHkD/J ghxZBar0gC/Nl9QdSDirXRc0ekYifDocBDZgBwtVLP3yL0d6Ci88aS4SB2aGBLN3df0i +NjA== X-Forwarded-Encrypted: i=1; AJvYcCW4mgFjmOvnh4NZ8hM+wUyBWRx7S5wmsgSq6Fh1EePLsnAYKXsk6YOdzm6e7EU9B7n69ZmubDtESCiiqUV7oxKhADU= X-Gm-Message-State: AOJu0Yy8vsB4PXJf73lsBYyLmupXfBIK9DGqiwRZMWSD252C1QlPf+s5 7ERCtly2ohR6bUPz7XY39CIbxmtyy+HjXRKVJPIj8Pw2aTFkPuhXdugcE8lWQ4SaUPVA2M1YzEk /thF6yJlxy3NlVfRforU3ngCtIkx8/Vs/m4/jzg== X-Google-Smtp-Source: AGHT+IExI0OeHf48EBthOwkTI3aIjxBBaA3Ik679zCw1G8yDECFvltEArNPD+bABqbdLjI6o0QR2sTPYH07apAlR/WI= X-Received: by 2002:a05:622a:4a0d:b0:447:eb33:410d with SMTP id d75a77b69052e-451d421cefcmr36717101cf.18.1723143743702; Thu, 08 Aug 2024 12:02:23 -0700 (PDT) MIME-Version: 1.0 References: <20240808154237.220029-1-pasha.tatashin@soleen.com> <20240808154237.220029-4-pasha.tatashin@soleen.com> <9cf6cbc1-67c0-4ae5-ae5e-5033631e61b6@redhat.com> In-Reply-To: <9cf6cbc1-67c0-4ae5-ae5e-5033631e61b6@redhat.com> From: Pasha Tatashin Date: Thu, 8 Aug 2024 15:01:46 -0400 Message-ID: Subject: Re: [PATCH v3 3/4] mm: add system wide stats items category To: David Hildenbrand Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-cxl@vger.kernel.org, cerasuolodomenico@gmail.com, hannes@cmpxchg.org, j.granados@samsung.com, lizhijian@fujitsu.com, muchun.song@linux.dev, nphamcs@gmail.com, rientjes@google.com, rppt@kernel.org, souravpanda@google.com, vbabka@suse.cz, willy@infradead.org, dan.j.williams@intel.com, yi.zhang@redhat.com, alison.schofield@intel.com, yosryahmed@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: D1C0C180029 X-Stat-Signature: kt617haoucfhmyrhhdrobyiqo1fqe4ht X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1723143744-6189 X-HE-Meta: U2FsdGVkX1+igtMkscpoyGInfFRVDx3AzSyu4E0Pc5kUL1OM6YJDLV8qzwFojBU6BtCWdYeiDe/PmnA7jg7RzRZnPeEEzSOWBM38rqq/Wpq/6HHSuRYNCg31i0vuRFp85pRa/RJl6hvfAfJQVMMjJEbcK/MficBLchVO+LmC7q6/7lURb2DBGufXze0bf5hD8Q6Q/XPFFdr0qVuErfG4V1JMo0ZX3I//zxqzXOXj62+Zb+Tp+23ptpPd/Pm3kI6eKXylNct3p9QWW/1DN1FLZP4Hca+4DUYtT9OioWn1TTQ0LVK8AV7/05ylClm8FYJEz/y1LAC4pVcuzJosyDNhK8YeGy4Mjs1FOpXYZw5uv47qJ7VG/flhfYJypa59G7gon3Rx/4jO8mQINoUTSSplwvoIgHp5oNW1WU/YQoxxd0THaaOXBIO1IXFy7ZxaNaxGN9wk0yRmP2FPm3ZJHRkrxIFiJpn9mvF6NbLvv0Wo/LrffUW6fw9Iqv0Z33zevB2SEWloq1lSvsGiVUMevY/ohf4r1NT6ZW1YZMVXIR1SnZUegVX+irDvpWc9XF5Y1RqXgWIHNw+55cZ2m6RdZOBblkCn0XEdYD/nlGCJ2+CLv5CjbM4XC5nAljgQ+0r7rvenZFOQMOhBOiPp0Mm5ks1vaGU6n6ZaZjSXPInv3EDSMluHLB7w4n8SCEGEyjEyKphSFWnlqm2VI2tQ4sv2fa1dZrNuMTB6Kw5mRt6bqHjtYDCeRqHXtGZTF6RLLb34nzIdrmo09agOAfroDKF/7u8MDSFi/K9ZezXaCtsPVfMq8+pu48BbPLerktyR8EQ9ij/1N6N9lcKj7L+1A0b79vteIbddnhWfpvwrlR9gdjkIOs6eLk4LGL5mTu1tHU8NOYlq1AKsmC/VRkbQwCVsdYqa8dp8NwgIQ1pRKpIBIWynCo3LdAyMzo/eWE0vafHds/KKPNujBOtaitIwQE5MAlY jOlB5/O2 3e8TNsxB4jR9fTm/+taDaQWn7dCCrvMH6rIF4NqVpm+af/FPxyrF0tdt9Zze51B11/DB8WOl4c+eYzYtSj4q8Wx2Jm5FORoETebzMLkjbcphQrGC8XGEReAoXxX+/3TVdm3Y74gtZdPC7FXAB5UtUiy89MkfktHFx1ygZ0rDRUdsVQXcpWnW3IeOxjvl8xGh3E3tjKvzvwhSqhAkWN6nfMPGZONt8WQfBwEGCe5Tjo+JFwPFjd1OIrpQAeA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.135369, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 8, 2024 at 2:20=E2=80=AFPM David Hildenbrand = wrote: > > On 08.08.24 17:42, Pasha Tatashin wrote: > > /proc/vmstat contains events and stats, events can only grow, but stats > > can grow and srhink. > > s/shrink/ Thanks, fixed. > > I think we discussed exposing this in /proc/meminfo. There, it would be > much easier to simply have a global variable, print it, and be done with > it. Like we do with TotalCma. Originally, Sourav had proposed adding per-page metadata stat to /proc/meminfo, but it was decided against, because all the other stats in /proc/meminfo are part of MemTotal, but memmap allocations are not always part of MemTotal which makes things confusing. This is why it makes sense to keep nr_memmap only in /proc/vmstat.