From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C5A1C636CD for ; Thu, 15 Jul 2021 18:13:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 066AB613D3 for ; Thu, 15 Jul 2021 18:12:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 066AB613D3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5007B8D00F2; Thu, 15 Jul 2021 14:12:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D6D88D00EC; Thu, 15 Jul 2021 14:12:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 378FD8D00F2; Thu, 15 Jul 2021 14:12:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0151.hostedemail.com [216.40.44.151]) by kanga.kvack.org (Postfix) with ESMTP id 14B8F8D00EC for ; Thu, 15 Jul 2021 14:12:59 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id E9D9118535DA0 for ; Thu, 15 Jul 2021 18:12:57 +0000 (UTC) X-FDA: 78365618394.07.F920959 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf27.hostedemail.com (Postfix) with ESMTP id 349C77001964 for ; Thu, 15 Jul 2021 18:11:10 +0000 (UTC) Received: by mail-ed1-f46.google.com with SMTP id l1so9359196edr.11 for ; Thu, 15 Jul 2021 11:11:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FXPAG28KbucvzwWJNYmUX3rMJn0+3EtU75a9xp4rWjI=; b=AVglhLSl+WRl4taiirYuKqBg86+Z9/1UQoENraulc/lDrN6yc/nkLFmodiLP3aDz0v bmYviQh33Zg+TVA87kNQMQvKdaGFC6Sd8Y3Lr7Bmv4wXHkWg91yTvk7H8XaKcaiwU8AZ ZgaPe01zLe4Zw+Lt5J0NTa7+zpcmH+v7+gB+eA9ieVbTOn+juP75g0UzFG/9kPb9Prb0 cLUWCKDOX/Cf6gfO/ChzLLKV5fhRbrgeQ4tMgnpML/7qbAukJiqbTizRJKm3KMY3fk5w fuwKb4q0JhXZ3JF3W5WRC7p3xoKl7nZbTlvk39fQ8bFoDlBbhdZC/vYFE3QyOkgMShCO /oEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FXPAG28KbucvzwWJNYmUX3rMJn0+3EtU75a9xp4rWjI=; b=RgnnBFG6dCSSwVsN2Th+ke3QD/dFI7urjU6KF0JrYmZ61lbLgp+OpH2jqQh2LJyBBm eIVE3ybywv0stVTH+thl39J3yYtD7Kj/LWqpc0p1i9/5OSNRnSNtcDL2w4523CMbMNoj OYt/2/5Hq3u5H15uJHVuzqH+AVyhjBVz0fg7ydUQV2ERc4grsUmhc2xfRiIf5w4HTWNU IxJ1DDv8WtEjRq9Pai1Bt9bj5e+ObG+Fp0Qix1/d8fsraErHHX2G8b49aOPRZ+oOKBrV 3yUhsRNY2jWFsCyJyCxt8wYdtcdH/oSffTgr4xWo3/HeAdSH8KnVsuEIXatLW3UYv3Rs 5+Jw== X-Gm-Message-State: AOAM530J4sdM+xjsryPJD+rJHB8bNMezEXUe5knbKdR/yX5OOgKUCbom v59yUzevzNZ0Q481UWykB1DOO3MNYF5/aa26F1QwJw== X-Google-Smtp-Source: ABdhPJzW9yOauKjjzhomDnHUvp+EhR8m1mOHilOLEKFtZXbIjIp+J6Y/gEPvSy7fr2fUTxHodnJtswL6BjpXmnUnhwY= X-Received: by 2002:a05:6402:1488:: with SMTP id e8mr8796429edv.341.1626372668922; Thu, 15 Jul 2021 11:11:08 -0700 (PDT) MIME-Version: 1.0 References: <3610f5373bb12ea04e025bafbf8350f75c0dbf4b.1626371112.git.zhansayabagdaulet@gmail.com> In-Reply-To: <3610f5373bb12ea04e025bafbf8350f75c0dbf4b.1626371112.git.zhansayabagdaulet@gmail.com> From: Pavel Tatashin Date: Thu, 15 Jul 2021 14:10:33 -0400 Message-ID: Subject: Re: [PATCH 2/2] mm: KSM: fix data type To: Zhansaya Bagdauletkyzy Cc: Andrew Morton , Tyler Hicks , linux-mm , LKML Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=AVglhLSl; spf=pass (imf27.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=none X-Rspamd-Server: rspam02 X-Stat-Signature: y71q7twnjjgshreqg9uzsy78yafyf8op X-Rspamd-Queue-Id: 349C77001964 X-HE-Tag: 1626372670-463647 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 15, 2021 at 2:01 PM Zhansaya Bagdauletkyzy wrote: > > ksm_stable_node_chains_prune_millisecs is declared as int, but in > stable__node_chains_prune_millisecs_store(), it can store values up to > UINT_MAX. Change the variable type to unsigned int. > > Signed-off-by: Zhansaya Bagdauletkyzy > --- > mm/ksm.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/ksm.c b/mm/ksm.c > index 057d0c245bf4..2e4bd7662e52 100644 > --- a/mm/ksm.c > +++ b/mm/ksm.c > @@ -259,7 +259,7 @@ static unsigned long ksm_stable_node_chains; > static unsigned long ksm_stable_node_dups; > > /* Delay in pruning stale stable_node_dups in the stable_node_chains */ > -static int ksm_stable_node_chains_prune_millisecs = 2000; > +static unsigned int ksm_stable_node_chains_prune_millisecs = 2000; > > /* Maximum number of page slots sharing a stable node */ > static int ksm_max_page_sharing = 256; > @@ -3105,11 +3105,11 @@ stable_node_chains_prune_millisecs_store(struct kobject *kobj, > struct kobj_attribute *attr, > const char *buf, size_t count) > { > - unsigned long msecs; > + unsigned int msecs; > int err; > > - err = kstrtoul(buf, 10, &msecs); > - if (err || msecs > UINT_MAX) > + err = kstrtouint(buf, 10, &msecs); > + if (err) > return -EINVAL; > > ksm_stable_node_chains_prune_millisecs = msecs; LGTM, but I would merge the two patches together. They both update types of sysfs tunnables in the same file. Reviewed-by: Pavel Tatashin > -- > 2.25.1 >