From: Pasha Tatashin <pasha.tatashin@soleen.com>
To: l00580197 <longwei27@huawei.com>
Cc: Alexander Graf <graf@amazon.com>, Mike Rapoport <rppt@kernel.org>,
Pratyush Yadav <pratyush@kernel.org>,
kexec@lists.infradead.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, hewenliang4@huawei.com
Subject: Re: [PATCH v2] kho: Remove duplicate header file references
Date: Tue, 16 Dec 2025 05:56:27 -0500 [thread overview]
Message-ID: <CA+CK2bCyqOKo1oA32TPnL3u+w8VT6MF+pb+Wps57C_P6v2C9ZQ@mail.gmail.com> (raw)
In-Reply-To: <20251216064520.1529635-1-longwei27@huawei.com>
On Tue, Dec 16, 2025 at 1:45 AM l00580197 <longwei27@huawei.com> wrote:
>
> From: Long Wei <longwei27@huawei.com>
>
> Changes in v2:
> - Fixed the malformed commit message header (removed duplicate 'From:' line).
> - Added module prefix 'kho:' to the subject.
Please move changelog into stat section, so it does not appear part of
the commit log.
>
> kexec_handover_internal.h is included twice in kexec_handover.c.
> Remove the redundant first inclusion to eliminate the duplication.
>
> Signed-off-by: Long Wei <longwei27@huawei.com>
With the above:
Reviewed-by: Pasha Tatashin <pasha.tatashin@soleen.com>
> ---
> kernel/liveupdate/kexec_handover.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/liveupdate/kexec_handover.c b/kernel/liveupdate/kexec_handover.c
> index 9dc51fab604f..1962b6052840 100644
> --- a/kernel/liveupdate/kexec_handover.c
> +++ b/kernel/liveupdate/kexec_handover.c
> @@ -24,7 +24,6 @@
>
> #include <asm/early_ioremap.h>
>
> -#include "kexec_handover_internal.h"
> /*
> * KHO is tightly coupled with mm init and needs access to some of mm
> * internal APIs.
> --
> 2.43.0
next prev parent reply other threads:[~2025-12-16 10:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-15 9:11 [PATCH] " l00580197
2025-12-16 6:45 ` [PATCH v2] kho: " l00580197
2025-12-16 10:56 ` Pasha Tatashin [this message]
2025-12-16 11:44 ` [PATCH v3] " l00580197
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+CK2bCyqOKo1oA32TPnL3u+w8VT6MF+pb+Wps57C_P6v2C9ZQ@mail.gmail.com \
--to=pasha.tatashin@soleen.com \
--cc=graf@amazon.com \
--cc=hewenliang4@huawei.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=longwei27@huawei.com \
--cc=pratyush@kernel.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox