From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF9C6C00140 for ; Tue, 2 Aug 2022 21:37:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2673C8E0002; Tue, 2 Aug 2022 17:37:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 217158E0001; Tue, 2 Aug 2022 17:37:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DFB28E0002; Tue, 2 Aug 2022 17:37:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EE40F8E0001 for ; Tue, 2 Aug 2022 17:37:19 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C28ED141034 for ; Tue, 2 Aug 2022 21:37:19 +0000 (UTC) X-FDA: 79755963798.31.01D7F22 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf23.hostedemail.com (Postfix) with ESMTP id 5364A1400F6 for ; Tue, 2 Aug 2022 21:37:19 +0000 (UTC) Received: by mail-ej1-f54.google.com with SMTP id i14so9445483ejg.6 for ; Tue, 02 Aug 2022 14:37:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OKtGK5sIPibPNqcR6q99LYNIzHJsqP/Ejs1dmn/8SIk=; b=Mj8eI2OCfNotqPrABVWGaqA7+gZkpOh5zRHQPIi+DjoSYb9SSYuXQK2xd4chptvWX3 t6E23pXV6D+gR9KSHqWK2+FvPHdgpyiB99JD8ukiFVv39NoW69m6VimX0eXW4u2evro/ YU8vGErs+6zLx6tSNwvqVQNe11QjdZ+DPujtBI5Ld6GM8GL0avsCGk9newQDeW7tCsm6 vd5/NX3nbzrivN3peKk9fR3t+uuNw3FKPOASBFdeEgKbGGAPunXR6U/ZsJxje8sbQKPT QObgclWm2c8x8EU5aDnDB8R9fKMcSYVglUcjIv9MrWON425OEWHe3Tvellnd9x1+TIIr nycw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OKtGK5sIPibPNqcR6q99LYNIzHJsqP/Ejs1dmn/8SIk=; b=W2r9aArD+06p+wDU7H2j4aFKRsED2afF9ZNCOp5f9+ZUFMi5bU5WqMEOwiSDfWt9Rz 4Up1DqKkQECtOY3TQxdB2ChlCIak8dtyQl2NQiHvnv2FpuYnsfCwulxvjPEa4U+b4mKI 45cNQPjP/0bPIqAPEPQ4wSCa0LJGAcYqzPIQGeOs9/OPZG+QWQay7V3Gez3ogHr4pbZI nwQwzihukx7uG7ocC8edd64bVYDR3Mb0JYaK5CxFgMl1h385GCZIriy5s3q2qcB2HN6m mTlV0PA7yXe4Sz2WNg3Md+yNIxZrs+6lyAI4b5ZUfC+POGcOQs5STLXHJltgGYeggnQz XU1Q== X-Gm-Message-State: ACgBeo1VewIcgdegRwBxy6gFNGxGmkTBRxN+2HskDSuqYMN5xHuqzbHv d3SNrKN8D9pAQbT5Mfu2oIz3RW4I5zhQD1AK5bYHyQ== X-Google-Smtp-Source: AA6agR5OYcw/xET3GCFep7z8eRGZJMrBD9QCWerywjCpk+i4kdACYjgQfgkQgG8hBAobADAOe4YqLUeKcgH2COjgavA= X-Received: by 2002:a17:907:3ea5:b0:730:8b95:dc69 with SMTP id hs37-20020a1709073ea500b007308b95dc69mr8449191ejc.34.1659476237901; Tue, 02 Aug 2022 14:37:17 -0700 (PDT) MIME-Version: 1.0 References: <814dee5d3aadd38c3370eaaf438ba7eee9bf9d2b.1659399696.git-series.apopple@nvidia.com> In-Reply-To: <814dee5d3aadd38c3370eaaf438ba7eee9bf9d2b.1659399696.git-series.apopple@nvidia.com> From: Pasha Tatashin Date: Tue, 2 Aug 2022 17:36:41 -0400 Message-ID: Subject: Re: [PATCH v2] mm/gup.c: Simplify and fix check_and_migrate_movable_pages() return codes To: Alistair Popple Cc: linux-mm , jgg@nvidia.com, Andrew Morton , Minchan Kim , LKML , John Hubbard , David Hildenbrand Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659476239; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OKtGK5sIPibPNqcR6q99LYNIzHJsqP/Ejs1dmn/8SIk=; b=MdOzlmns8WEfeGK+nx66xGgPmvAB+QIGOkVYNBb9BbzWAWqXASdQZhOmbMlQ3qeoDNof+y njmar1RupddkB884OiIswoPOdfUpdS0h84G2t2pd4ZdJ7gSXoc23hoMPbdfo/wSzLolws1 L2kPEFB4U4M1PY+0e5kFsIBP4swAGOE= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=Mj8eI2OC; spf=pass (imf23.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659476239; a=rsa-sha256; cv=none; b=s/BxcPDpJajCHoDRR8nYIEgpzaou6FQF5OICfK4w3Kl/cpQm9wmXdcDMpcGoEZY/H3NtAm VnI5YEF/BOGho61JfxBGjZZt7qllOKYO6W3tAYJ09sObPDsN920u+7aIkDGdRiQFAkZ0n/ 6IJroO30HJ2gsUgdw198H3cO6vq4cF8= X-Stat-Signature: 1af1ue1gftunciqb4hofcxqgrot5kir1 X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 5364A1400F6 Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=Mj8eI2OC; spf=pass (imf23.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=none X-HE-Tag: 1659476239-431610 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000156, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 1, 2022 at 8:32 PM Alistair Popple wrote: > > When pinning pages with FOLL_LONGTERM check_and_migrate_movable_pages() > is called to migrate pages out of zones which should not contain any > longterm pinned pages. > > When migration succeeds all pages will have been unpinned so pinning > needs to be retried. This is indicated by returning zero. When all pages > are in the correct zone the number of pinned pages is returned. > > However migration can also fail, in which case pages are unpinned and > -ENOMEM is returned. However if the failure was due to not being unable > to isolate a page zero is returned. This leads to indefinite looping in > __gup_longterm_locked(). Hi Alistair, During prohibiting pinning movable zone development, there was a discussion where we figured that isolation errors should be transient [1]. What isolation errors are you seeing that lead to infinite loop? Why do they happen? Pasha [1] https://lore.kernel.org/linux-mm/20201218104655.GW32193@dhcp22.suse.cz