From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A8BDC3DA4A for ; Thu, 8 Aug 2024 19:03:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1F1D6B0089; Thu, 8 Aug 2024 15:03:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CED66B0095; Thu, 8 Aug 2024 15:03:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 896B46B009A; Thu, 8 Aug 2024 15:03:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6FD446B0089 for ; Thu, 8 Aug 2024 15:03:54 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1E6CAA526B for ; Thu, 8 Aug 2024 19:03:54 +0000 (UTC) X-FDA: 82430002788.19.DD68589 Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) by imf14.hostedemail.com (Postfix) with ESMTP id 48F13100007 for ; Thu, 8 Aug 2024 19:03:51 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b="Q/AR/RFm"; spf=pass (imf14.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.210.53 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=pass (policy=none) header.from=soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723143780; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DJD3NMKxCdaaPWikegeFRbNee15HLPMi9fn1KjdIIdg=; b=MJsgF2oZ73wW9jJILn2hPF9fF3mizY9hqlYIsUZ2XaclIhOTbQsYAIvk/ZFfGF1udtLtw+ bY8b6AnaH8Kwt94HnWX8hMUEWS96spzBR4kFpiJhR4STwmXxAmph861JzKyKwNIhRdsN9W 2pp1dWeqVcUfNty4YkfDrVwt9EIbzN0= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b="Q/AR/RFm"; spf=pass (imf14.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.210.53 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=pass (policy=none) header.from=soleen.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723143780; a=rsa-sha256; cv=none; b=4mDIJ8iNCu0KoMmVpyw7IjTtdibhZjudd7uc34SD+hTigxpeZV+fihowYHf8QGBeOL7eLB xzPhu2wj4kkYrg1/ybEH23l4vb2P6A4MJ7pl9/0Liza86AtZJeslxN8+WceCv5oWjwQ12E G0U/cusJKWOT+ttKCgVpu4rqQ0PSwfw= Received: by mail-ot1-f53.google.com with SMTP id 46e09a7af769-709428a9469so820504a34.3 for ; Thu, 08 Aug 2024 12:03:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen-com.20230601.gappssmtp.com; s=20230601; t=1723143830; x=1723748630; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DJD3NMKxCdaaPWikegeFRbNee15HLPMi9fn1KjdIIdg=; b=Q/AR/RFmKgn25nGQMgfMRUo8w0Qv/gKRMQVO6aJeOfdQ6afm8emN4mrDHg+9J5Jfi9 xBCQmDYESjS9oGZK52vfyiLEQqVVkEXaIBzfvisNd12QHGnoy1fyvvPRXKtchljDGanI GcDFW5klVrqOz09R8EikWwGHFwDs0aO0w8PPvSg6ffVrjSKPUHSWjWqwzIjq8bg37jpX wAGufSGCn3Dc08y8oAzJa3q5qgWfy7mtyspxBEXTEh58g1QNcP79eIWFMXDxKiNCE+rC aXTTUTAzYGNluvBS1iLZayHf8I83uuj1zffD5ifMU2KJs58MD7LVs6PdqR56UR1Z7OsQ 199A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723143830; x=1723748630; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DJD3NMKxCdaaPWikegeFRbNee15HLPMi9fn1KjdIIdg=; b=aNMnpDSnaSnPfr09LxXlY+zW8Kt9rm6WZ9TXdX0D4ZE79rBgLoB9kKm8NmiWVbADdc 807G6Zuoukf5plH344DDqPgGIOkvbek0UwHQuO6wcmqWOjDWkTkvvSgS8fgq5X2fT6IT 7v5EnxTce2tSwLdoeRaz0DJ2OH5hQjfa78i1rY2FMNtFbrdcDo+e03mgAI3XE6WtwtDm 0r6fkUKcN9sWRq0NJMfgNB0MlrvrtTivrZNFBluwpAl7k585ygheqyEgLSrtSe1Qg556 kubKX/rK7Rs7rOEtKOtvCUYJrggVv1fS165J+qTjlyEaVBhUu0yrLz63PFRwkII8p9zN 1PhA== X-Forwarded-Encrypted: i=1; AJvYcCVDvhvZGjts+fOkpXs3WsPO8gdoDt7MibkkvI+LPARnkrX9w6Npm1G5OYkLjfSm4TSBOqzKFQj629zZw/xhC93H6qs= X-Gm-Message-State: AOJu0YyGvuGQi12gjbwT1vCjNsWV+VP9sc0wP6d2NJL1j0htAnfdPCus vrXXb9uZmoNgMdY+8xlqOOz2j1CNRvHiqNv/HA3o3dhgrBONs1Jp2/S9+i7GAFwZaUZxUIHxuxj WnkexlH3anihZTcTuz6o77kKswBZhrpSDhA1Shw== X-Google-Smtp-Source: AGHT+IEQca1KIhdNSUI2/4IjEdXBF2eDVBstcisCNWacbs8Zj90oeDvngeCX/YUYlKJXyS6Mli9xj1i7zvInvyLokXU= X-Received: by 2002:a05:6830:d05:b0:709:4578:8e06 with SMTP id 46e09a7af769-70b4fc266damr3494134a34.4.1723143830208; Thu, 08 Aug 2024 12:03:50 -0700 (PDT) MIME-Version: 1.0 References: <20240808154237.220029-1-pasha.tatashin@soleen.com> <20240808154237.220029-5-pasha.tatashin@soleen.com> <490ae360-50a4-497f-b148-ef077b73e911@redhat.com> In-Reply-To: <490ae360-50a4-497f-b148-ef077b73e911@redhat.com> From: Pasha Tatashin Date: Thu, 8 Aug 2024 15:03:13 -0400 Message-ID: Subject: Re: [PATCH v3 4/4] mm: don't account memmap per-node To: David Hildenbrand Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-cxl@vger.kernel.org, cerasuolodomenico@gmail.com, hannes@cmpxchg.org, j.granados@samsung.com, lizhijian@fujitsu.com, muchun.song@linux.dev, nphamcs@gmail.com, rientjes@google.com, rppt@kernel.org, souravpanda@google.com, vbabka@suse.cz, willy@infradead.org, dan.j.williams@intel.com, yi.zhang@redhat.com, alison.schofield@intel.com, yosryahmed@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: zet4cgacm6i8zmibijz8wi13cukqb5eu X-Rspam-User: X-Rspamd-Queue-Id: 48F13100007 X-Rspamd-Server: rspam02 X-HE-Tag: 1723143831-154067 X-HE-Meta: U2FsdGVkX1/uj7r3BGmxnPsPNx2WPksHPTfAKq4NbPMbrB9CV6fNFpEl5RLp/q0OslZcS9NP5vak+csW8yxn9K4GC0YeB12AQTOziySRkUKnUH20HK6/EZacRj0GFxZ7wDs/AoO2UASb0VJYJz1TOjthz7JDCKkjw9vE/EKIG1x91BkADG17Q5wXo1roAyN0nGrBGeBUgKIB8nmGIQmomwjXFJ3VqPsH+hVCLGMbN/JPCmZquTJAlb1LZSxRPk1hN04C6qY2VwkWwemVKbdneHVvr8j6o+SkjEzokNZQRZfhDFrAfaORRoMBCgIeO0bkK5Hj/Ggn0HPA2AffWDkojD7fWmtcvEt7zq2d7MTvuSdz9QJnB7LghSmryeeH1MbRjnC9pA5o+3/C8AhMwi/3tg0PFv8f08SlO799wnv06SrDjZQpz+upNNDnjZplMMQc20IheSpOwCF1XUIsWp0/CUJYiOWjvbMRLbCo2V9m6h8bGwBH1MBjUAdUajKBP8/I/kRbhf1fVHVYi0c66cxGmxotFixtHolGkKc1DGeFEoQHi3FF+ls9oZimRriIIp1oCwpu8ilk7kgDyVDG7yysicD5gpp+C53k4IAAKEfL+u6TWGRWPLmp3mC4fTmcGIbHWhahg+ANkTXk8Tr8+Ad9UN7pE6XrhqR4kkXnhSLm5SwGElhGGxJFghbCFCa8gTrQ4h+ggR4QEuWb6I0aGKNpAdNeltOKtVPsIfL0FKH+ampxMWOUEBbvZPN6w9t36/X8wzPDy2LSpYi2uPoUiuv9FnYEyyFuvY2IZDD/j+hR9MvUFwTYAZoICMg4WbsYsS3jI4oAdIHJqMfGbIT9SzzZo7+WjC/0a12J1CErzJIZy4BINRCIrXQsUOGON9tEksbkWdd8Hc3WJYCekk3HifWREuGW3CbYkKQ3YnB8K5aV9LFtfPd9RXqZ8/3/WW/krT0PACjG8V4rjAeU0TuBRH6 SlqMqG3p vFk1aZYE4c4m7sisUKoOV1H/WB2DK+S+HQDSoYXgBtPBzgk6anC+sJvS5bgW89SUaI24nqVugFvCZxA66fizbHG4EcjqJvxJVoIS1AHrEe2tWOZ9KvHn4FFD364Pn84dJtdon2ezzE1mxe25hOlTBz4DHt2ooU3ZyANZ2rtdo2DF6qrlArqzJHqxS1NCDIfdanvxT7JZjXqJvSgwu/gRhg6bmjdvzsjmNd+2cgtpkyDA2UCUFB07RT6KVuA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.083970, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 8, 2024 at 2:26=E2=80=AFPM David Hildenbrand = wrote: > > > #ifdef CONFIG_COMPACTION > > > > struct contig_page_info { > > @@ -1255,11 +1272,11 @@ const char * const vmstat_text[] =3D { > > "pgdemote_kswapd", > > "pgdemote_direct", > > "pgdemote_khugepaged", > > - "nr_memmap", > > - "nr_memmap_boot", > > /* system-wide enum vm_stat_item counters */ > > "nr_dirty_threshold", > > "nr_dirty_background_threshold", > > + "nr_memmap", > > + "nr_memmap_boot", > > While we're at it (sorry, I should have found more time revieweing this > earlier!) ... > > What is the unit here? Should this be "nr_memmap_pages" / > "nr_memmap_boot_pages"? Like > > $ cat /proc/vmstat | grep pages > nr_free_pages 3618323 > nr_zspages 3 > nr_anon_pages 1053316 > nr_file_pages 3199210 > nr_shmem_hugepages 546 > nr_file_hugepages 0 > nr_anon_transparent_hugepages 0 > nr_page_table_pages 15215 > nr_sec_page_table_pages 0 > numa_pages_migrated 0 > > > Nothing else jumped at me. Good idea, I will add _pages