From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50F08C52D7B for ; Thu, 8 Aug 2024 15:24:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CFBE56B00F3; Thu, 8 Aug 2024 11:24:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CABA76B00F4; Thu, 8 Aug 2024 11:24:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B73666B00F5; Thu, 8 Aug 2024 11:24:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 927F36B00F3 for ; Thu, 8 Aug 2024 11:24:13 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 13BA7A1553 for ; Thu, 8 Aug 2024 15:24:13 +0000 (UTC) X-FDA: 82429449186.01.B89E861 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by imf27.hostedemail.com (Postfix) with ESMTP id 310D840002 for ; Thu, 8 Aug 2024 15:24:10 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b="t8Iw/S0n"; spf=pass (imf27.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=pass (policy=none) header.from=soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723130586; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qx18uaar07tjK8QW0faH95Ubd3Yujuqs2CBIHWPUeWs=; b=3UVZUO4tfPTTDnGTE8ovGZhubXjFy4c5iUxkA69emkyGSQOjPjOu9tS/oE/W6878SjNUAI Tpmf1qYcHEk8ntsPVdkdEgX05I0SnGFEj55uSIrpNihLZR8TBDd1ItiOgjRHsDFnbYdSWy uZkxzbWfsIzYdMn5pssgat/M06WVIP8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723130586; a=rsa-sha256; cv=none; b=HxDp6hhsNOa1F5Jol+w25wiqFPGWP0/D6M4cLtz5E+s7s6y6DiwZIju3Fvo4UTAKINm+DC 1puFYd8lgHHOM9NJCNzSWCOGbq60o7vuSJE00DfffFZubsGRA+x8EmJYZMDpBW9+WxqDBw TSfgSIFO4xLYeud5Wda2ML/kGy6DFXM= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b="t8Iw/S0n"; spf=pass (imf27.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=pass (policy=none) header.from=soleen.com Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-52f04b3cb33so2333114e87.0 for ; Thu, 08 Aug 2024 08:24:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen-com.20230601.gappssmtp.com; s=20230601; t=1723130649; x=1723735449; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qx18uaar07tjK8QW0faH95Ubd3Yujuqs2CBIHWPUeWs=; b=t8Iw/S0nAzrUbxSg1iGByN3Q7aXXruqzgs8gL5BnfApyFN46XffS2vGZWabB1lhwme ZV2uqez/hI65/x3RF58ALlABe+sSoUAy1+BE4prvk7H+9yLxHFCpdFzq45p/2f2AbtLF VrMbVq6Qojx+qXTbpRYD9lybUraGa/EZtsLdrA4MWBDwpA8VNHP+/awUwT5C6Gt74rn/ o9j1KfZMw92iPBm8eX6ce8+/DIcDaHTWM8Y853pAi6LuflTsc9GXMjURvWtYXEwCdgl5 jJ0S62kDHtSINjij+Bi9xgvX2psNAfwX4fdYpTJIWT72h6BsnC9VmZ6939U+U49z3kvn TdjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723130649; x=1723735449; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qx18uaar07tjK8QW0faH95Ubd3Yujuqs2CBIHWPUeWs=; b=PUWH/l45Mj7hCEYWJIBjqp99aQll6lBD8XT2ZTczV2EJQpwyAf9+aNXlBw+V+TT/KX 2BdEnHpd+UfpUZbVm1DzEZpXKordf6ldD+lLq/nYfV/G+bAteeMBRP4nhxaIw1VsRete v5CN42gsFIgDxWMhINzb8PxXAnzHM2yOJChRa44kwd6pGKokO3/WC37iJkSWUJhjoZM8 IrvsXIOcD/WmpXJPNw/KD6MsaRZHVkW5Epr8yzAp8r7+qjHrZekXqE/KXxLwFwcxft8e 9eEKLRkXRVQzjwsKu3h1BIM14s4NnYCdc5Y71CQ+7lCN8BvThGKJHGBarUBbx/eEqn40 cyng== X-Forwarded-Encrypted: i=1; AJvYcCWDkdW+f3KduSMR3Oz2KkbXjonLNVOljGu6p1pQTzThh2cjop6VL3Ug8VSx9eauhmmVMLoGVs4l53uqZkjOtmJ2tSU= X-Gm-Message-State: AOJu0YzSYThjqru2x+Plaoh+/gn4MVpvH6QZbjtdJSYopQJHHiAzZTDx UcJCD683b/ORLOsq2U9JRJyHPUdH09rTrRTKz2p9obEnVK5GszfEQB6gR4lrnCB2VKVy7UtYSGE hwtZHS+IrEu8em+ChxUi4CwWPN6ckeEu9M54BjA== X-Google-Smtp-Source: AGHT+IHQfJk4XwPcOfo9+O99r2JxIMlQxBCThMQWtoh/L0V+CtPk6/Rgp2Ne++2MFrhPmJRgmXKE8nv3eif8DzEPJUA= X-Received: by 2002:a05:6512:1107:b0:52c:c9e4:3291 with SMTP id 2adb3069b0e04-530e589929fmr1646154e87.60.1723130648939; Thu, 08 Aug 2024 08:24:08 -0700 (PDT) MIME-Version: 1.0 References: <20240807211929.3433304-1-pasha.tatashin@soleen.com> <66b3fc8d39391_2657d52945e@dwillia2-xfh.jf.intel.com.notmuch> In-Reply-To: <66b3fc8d39391_2657d52945e@dwillia2-xfh.jf.intel.com.notmuch> From: Pasha Tatashin Date: Thu, 8 Aug 2024 11:23:30 -0400 Message-ID: Subject: Re: [PATCH v2 0/3] Fixes for memmap accounting To: Dan Williams Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, cerasuolodomenico@gmail.com, hannes@cmpxchg.org, j.granados@samsung.com, lizhijian@fujitsu.com, muchun.song@linux.dev, nphamcs@gmail.com, rientjes@google.com, rppt@kernel.org, souravpanda@google.com, vbabka@suse.cz, willy@infradead.org, linux-cxl@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 310D840002 X-Stat-Signature: 6ifhfwk9d6cy1sqiir4so1b79b9ctugx X-HE-Tag: 1723130650-896202 X-HE-Meta: U2FsdGVkX1+wTahm1WHmaMxtdjcV3wn0gNIEMN9VaT9CQ+enmv5dvx5V+0vR3zqZcVwq0632R0JLPEf03pnjLYpz7OzYfrsZIoT+7VGlDvR9j4Kgjwcz74+WzcLuv7CwvTXLwiullLOmSppSDqTGiiSdDimvjwLxGjLmYYD8KEZbFCjpDQ6oA2hqO652bcaGzLkZEXHFzJKI67AvWvKRDFFlvb7KNiW8TcmGR9674ifVP3Hb8nK654YHRtjrsnB6gF8+2+aUWFXDh0YwPa+2hwiiP3Ct3f1Zeeri3MfbC1zXf3GNUmrj2g3+SdAsGe8ATJuY90r77LsN3mbTuYtKjc+jx2XPgpXLYjbO++x9gIS42agA70Vn3UcXvsY/HZwz/XE03B8ZFXthXPS9+qPMhuiHvAqwnrL1pKlPbx/owNgRT5hfxl2B5pxvOXAkwEgp2QqTFDkBm3TYMtn8uB6CbVfrPDdoC3Q8fKue7Vp9v0VhUapJEw2UrJtM1DtGWTQNfEM2bjWtm9ZebfcdruqzCPote3fVCr4tcXgvq/kOFbW4m/CfM9mhsU15cgdK/ov1D6He5oRTZLeSqsrbnNWhzeeCjCizRSE5qpPGQ+5A9O3u9A8V2OD7iczVx2j7zXWxBgmdaVbXCf7wvSwZ1Pz8kmdMBdl4Sq8zmZvZ8z240l4chMq4sU4WB4gWknxUjGx82XsIgcU/iHhyzaCmn43F8xTgvjVNFdzgueGFqAZK6OXMmxsz7zKTaQyRMmhVaxgKIXI4wcWfFsX7kasiZFviJQjZV9b7/9Yc0Nd465IISr2G3TbLnc5OPzpY+Bb148M0lVH+l4JIx9qP2hQcgrSUlZXjgULWcBqMMhxmYHeKfQ2msb+oZflL3Z4dCxugXSV9pKBvB1pQVEtZvVxsAXwojLcSzCJ0YEmr1Up73F5eU/KvdO1MyNA/cqcf8wElG5otTWhIgherLxphTOxcMeB xitsoceg SDzd47jDlzyO+2Euhhi2pN38bWetE4lOYaQQs84+bVeqYBLuv4pkJZCVLKfGVFoNlwXRv81FVhcOk64ERvzR9rpFoz6nJslEPjb8fSAKH93vZ/hsMYjMxshIBGlscU4sF9+vAwuXlXORZs1llZABfoXVPu96fGElugWdf9VmfipcGZR/OrsrrKpZnojAjI18t6+4nX/+FKx64iWSFJkfx86PFdBc2QfYfG3ljTF6gjNwqdyuGnQ6a4i1kWpVxiHOMNjKKg+B0iv5nO4jvJsvJQn7Z+ohjuIzi62JnzrsODbZ9pTRNnO/hWljf4uV3njE3c1HDz+xUNgEYsDOx6c5HCmXs6RM9RNwawnG9hJwk6YV7HK2Bj065FFExNQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 7, 2024 at 7:00=E2=80=AFPM Dan Williams wrote: > > [ add linux-cxl ] > > Pasha Tatashin wrote: > > Memmap accounting provides us with observability of how much memory is > > used for per-page metadata: i.e. "struct page"'s and "struct page_ext". > > It also provides with information of how much was allocated using > > boot allocator (i.e. not part of MemTotal), and how much was allocated > > using buddy allocated (i.e. part of MemTotal). > > > > This small series fixes a few problems that were discovered with the > > original patch. > > > > v1: https://lore.kernel.org/all/20240806221454.1971755-1-pasha.tatashin= @soleen.com > > Changes: > > - Added patch "mm: don't account memmap on failure" > > - Changed from using nid in hot-remove functions to non-pernode > > system-wide accounting for memmap data. > > > > Pasha Tatashin (3): > > mm: update the memmap stat before page is freed > > mm: don't account memmap on failure > > mm: don't account memmap per node > > Hi Pasha, > > Thanks for jumping on this debug! > > We almost missed these. Can you update your scripts to auto-cc folks on t= he > Reported-by line, and optionally include the lists where the report origi= nated > next time? Thank you, I will add them. > > This is looking good from my tests, you can add: > > Tested-by: Dan Williams Thank you for testing > > ...but I still want to take a look at some of the implementation choices. I am about to send v3. Pasha