From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42EC7C0218C for ; Sat, 25 Jan 2025 16:03:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7BF092800DB; Sat, 25 Jan 2025 11:03:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 76EA42800DA; Sat, 25 Jan 2025 11:03:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 636B32800DB; Sat, 25 Jan 2025 11:03:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 464932800DA for ; Sat, 25 Jan 2025 11:03:55 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CE8F1A0312 for ; Sat, 25 Jan 2025 16:03:54 +0000 (UTC) X-FDA: 83046445188.06.E79B748 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf30.hostedemail.com (Postfix) with ESMTP id F1EEC8000B for ; Sat, 25 Jan 2025 16:03:52 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=PkLvQ5Qj; dmarc=pass (policy=none) header.from=soleen.com; spf=pass (imf30.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737821033; a=rsa-sha256; cv=none; b=h3sBTXzetQrWrct4Rg4Lo+4/dh/bA5nJpZFmoj3y2cP0ZPUO3IECsaV8GNMXkWTouwW6Dw Ix7N0Ocn5kVbboHH5Ymix0mYhG95CjAAIR8RKA0JvxKe6wnyUNJUmy7Ff7XNl+HfrLWcIH A2ydEzYA+W4SbfhCAmjF0sZnp1NBHwI= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=PkLvQ5Qj; dmarc=pass (policy=none) header.from=soleen.com; spf=pass (imf30.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737821033; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EXngduFaoH9TpVldk/iLaPJJtKalDQpqOwOlO1f3lik=; b=iPmPpE5mFoCNCrwvS9/fnbz0/D3K84x/DtLozUVw0zP2+vyrJGYAAcdVXm0c+yL+aCUBd2 1RNo6yHxhU/tAJaRb2mtNWep0Hn7QUecad96mGN3g9XvdC2ADMKXJQd+OfNSc8/Ctbwwzs DeNbKh0J9ubW/nl1ZHNPofApTUMqbxY= Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-467b955e288so34327321cf.1 for ; Sat, 25 Jan 2025 08:03:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen-com.20230601.gappssmtp.com; s=20230601; t=1737821032; x=1738425832; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=EXngduFaoH9TpVldk/iLaPJJtKalDQpqOwOlO1f3lik=; b=PkLvQ5QjB44aEzdiTohdMxh9m1aIXKTk9nmY8cN5xPIFl4zyjYrqxaXdO/+zad4z29 SFf8gwNw7umMJOwVINJriQwxHk8D7MXlSAQm2Wlj/rGySZAZeMf8h0PBIuc8fH+lNzNG dBB0Tq7ZpkNOZ0tckbI1rEGIs4QudiG85HLQxWA13L/8Dg1COKLRFN/HyuF/2rSK8MAO VDGHfVoqIElC1TclbsAX2MLmf24xx7uO2zYHUlq+QkfzJqDCEON8DUf3Idn+Wf7i6yzP KFvY1iQnp/rsHYsqsiObBhA5rkEmm0R2iyuq9LwCV/+Xhch6RLPvfIU52pxBfbl7n5ye 0Lkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737821032; x=1738425832; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EXngduFaoH9TpVldk/iLaPJJtKalDQpqOwOlO1f3lik=; b=kw7Wm6HU7K2gtIZtMtEzHJceymQPkaZCYx1koETtQWPsDjtZfum4N03/aFe0uHbhbZ tS4CAKHhE9LPgwjv8pmCc7XCpm+xzkBGF3O8/vUo66nHh8vEU6h5XYa8UJ1nxuyDmOpF hS5k4BlpGHOIh++y5y4lVwea2pjCT4dBmR0d1D2zZK+aJRj1Mh4QgNZpjbm1sf+W4cbD OxYhXOacTjyU7KDJc0GRtKj61WPf775U15oyjibcmtYJecqw79B5RSe4tIAgriSJ35cg 1ZBgLlaBIgw+8pZqrXmM3l7flQHyBvzovKEgnI/Me1Z7R6sEdT7Fs7GsqWjsKlezWlHd 6mPQ== X-Forwarded-Encrypted: i=1; AJvYcCULhMzCXggO9aT13wZTV3/5ynaAbs/ZiRGlETkwRJ5RswpMtxmtB92TA8X+n3oagIQ9YxO5IKg3pA==@kvack.org X-Gm-Message-State: AOJu0YzQDAnFeGr7uRxbt8foFbnn+PgMhajSibz/sfAP0uIUFOtzRDyd bJQ3dULsfLPaYuClqHr1hEKn9gS/ttnou8oBvBRlPGf4aBIkA0DbiDNVFMcdwfEq51myC4ySgcA Bkj9rkCV4BgAlvXYEtby9nB+mw50V/iyvHWL6NQ== X-Gm-Gg: ASbGnctD7mASJVdiQef64zgVWxnnLX7N7IhIJWSo/reNgNuxCV6YP7+LYk3Rgz28R3l 9KqlR29FBzaZPAyOZQq+bbSDd96BPGbgv3Bf0vG/fDluhzaevly2GQpo/DjCx X-Google-Smtp-Source: AGHT+IFLNnWBvEzANe+myv8ReQLR6mZbTTW0X8EFia5AjC/vxBFwwM2I4HEzBgdeh1alDNF7XRLt/JG6kx9knpxxxPQ= X-Received: by 2002:ac8:7d16:0:b0:467:53c8:756a with SMTP id d75a77b69052e-46e12aaf8b3mr468764371cf.26.1737821032118; Sat, 25 Jan 2025 08:03:52 -0800 (PST) MIME-Version: 1.0 References: <20250124182140.2243862-1-mclapinski@google.com> <20250124182140.2243862-2-mclapinski@google.com> In-Reply-To: <20250124182140.2243862-2-mclapinski@google.com> From: Pasha Tatashin Date: Sat, 25 Jan 2025 11:03:14 -0500 X-Gm-Features: AWEUYZkqTI40L6aSg6-WrGxKd7cG7XG5V1LualprYarL1dW1TDKIoD3DqbfpWD8 Message-ID: Subject: Re: [PATCH 1/2] mm/compaction: remove low watermark cap for proactive compaction To: Michal Clapinski Cc: Andrew Morton , Nitin Gupta , Pasha Tatashin , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: F1EEC8000B X-Stat-Signature: dwwr47orp6o9976rqexm5qzrd3p7rzdr X-HE-Tag: 1737821032-142864 X-HE-Meta: U2FsdGVkX199D0g4Z5eRf2rmN++vscR7PHyUqqxEuRLuZtQwbG/JmaKG5o7R6Rxn7JiNziijI53jQftBfp503smizGsYDzE7j4vCsigSizADRsiq9R0lGmi2FAWcGHIppXH3yTJoW4ckbo1l6pKf8XHvDaajZ7aEmQGtZ8IC1G1Jmyhy29zgqOLORh5as3Z7vKVB4E7JG0dIpU94NIBWxLnxrPmdrti+7LVGYcz11/EroI7yIxi+TgMcBNXG2IelUP0qQgbZi2P8V16NsHC/oETHQ9CxMbvzgv/gGx7CgzowL0Z4tTQgvGDQnuMb09QJVW0fFjrpNEQYuiUBuqYTjto/0kpluDq5Mv6Ju9d77G7Pr/Ciu0kBoKLlMwrQprkQIVsRiLJd96nYD1EF1nZxBVJ+PRsEQDfSJa4SUNGklPrS4S7+W/59PJJj33DMaS15MJOsqeoQNFXxqImUFQ4gFPTrHBAwVnOp/VCceiVIXm1a+QT/qE/h/NhQwJqWVQdTQbqOftz4t1ixrm5R2aIUWJIuy1RP4nkuULq0ylo8q0ZQUKnwOiGbYekLkcr12rDVkLZ1HbUZGg4nyF8i846M3JNeWciEe01IlzpdjJkBdOAJb4YcnEXBrXvia/ZGqsCPtwdNx9LcCIfne6NVakVaZTEnsXgPHs97y1aeD/yTNAzu003jdKroFoWsDbY9bYqTvz5tP/4Gj+wrw1PKLZxRo3ksO8kmNd/mRaz988gxE/Ets7ttYQsptTYJxk/vb3OBz1MukxfqnlpiSNN3gTHf/xJnPtO2DY1Ku6QcQ9Q2u62fyeMqXp1fNbAXApRK2rxnFmwIiHfz11qd7qkqOzr4aVoMkI2gCfKkTyIJc72GRcXhDAHFlXJXAWrl2lzauShpnvhBuYFBNfYBFyEO5hhQontm2qbnISHr2GXegoYLyk5atdqK5qMuUmGwKaJ8Dobi4aHLKnQx7G7gB8QwAXg MtfofKAW QqDDiXArMSYKy1jfE8dDVKOzzwIK6j7xFbo6a2F/K6yGf422R6trpFwXlWU9e0uXIMdPsQCiLVe/0pJXHjL8e0V3uQYPNKiLv64IzK0W4l/NP3LbGYp5NB/jOmy0Zx3bPIzWsmpIap5C9my15dT+LnLALtqYphIctTWABtS2iuIKDPDkhiFhaiDM56wQRiksDobQamNTY9hSejOE7Qmkqm52/Uc2eB+DucyO7fwxX/qAfBfGC4vwc6h2SMY95TVErUUdSCFHYBCj2d2KsUhPF9gxQ4ru1UKujgkOoa9aokfcMdU/KGtBUhHKv6r6r8jddGpoXLk8QYo7A2ws= X-Bogosity: Ham, tests=bogofilter, spamicity=0.182034, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 24, 2025 at 1:21=E2=80=AFPM Michal Clapinski wrote: > > Previously a min cap of 5 has been set in the commit introducing > proactive compaction. This was to make sure users don't hurt themselves > by setting the proactiveness to 100 and making their system > unresponsive. But the compaction mechanism has a backoff mechanism that > will sleep for 30s if no progress is made, so I don't see a significant > risk here. My system (20GB of memory) has been perfectly fine with > proactiveness set to 100 and leeway set to 0. > > Signed-off-by: Michal Clapinski Reviewed-by: Pasha Tatashin Thank you, Pasha