From: Pasha Tatashin <pasha.tatashin@soleen.com>
To: Michal Clapinski <mclapinski@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Nitin Gupta <nigupta@nvidia.com>,
Pasha Tatashin <tatashin@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm/compaction: remove low watermark cap for proactive compaction
Date: Sat, 25 Jan 2025 11:03:14 -0500 [thread overview]
Message-ID: <CA+CK2bCqwEz7SEsn5=VcdpuMBEThC2T3oy399JBGuEvHXYFOAA@mail.gmail.com> (raw)
In-Reply-To: <20250124182140.2243862-2-mclapinski@google.com>
On Fri, Jan 24, 2025 at 1:21 PM Michal Clapinski <mclapinski@google.com> wrote:
>
> Previously a min cap of 5 has been set in the commit introducing
> proactive compaction. This was to make sure users don't hurt themselves
> by setting the proactiveness to 100 and making their system
> unresponsive. But the compaction mechanism has a backoff mechanism that
> will sleep for 30s if no progress is made, so I don't see a significant
> risk here. My system (20GB of memory) has been perfectly fine with
> proactiveness set to 100 and leeway set to 0.
>
> Signed-off-by: Michal Clapinski <mclapinski@google.com>
Reviewed-by: Pasha Tatashin <pasha.tatashin@soleen.com>
Thank you,
Pasha
next prev parent reply other threads:[~2025-01-25 16:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-24 18:21 [PATCH 0/2] mm/compaction: allow more aggressive " Michal Clapinski
2025-01-24 18:21 ` [PATCH 1/2] mm/compaction: remove low watermark cap for " Michal Clapinski
2025-01-25 16:03 ` Pasha Tatashin [this message]
2025-01-27 10:38 ` Vlastimil Babka
2025-01-27 13:31 ` Michał Cłapiński
2025-01-27 14:13 ` Vlastimil Babka
2025-01-24 18:21 ` [PATCH 2/2] mm/compaction: expose a new param " Michal Clapinski
2025-01-25 16:20 ` Pasha Tatashin
2025-01-27 10:40 ` Vlastimil Babka
2025-01-27 10:36 ` [PATCH 0/2] mm/compaction: allow more aggressive " Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+CK2bCqwEz7SEsn5=VcdpuMBEThC2T3oy399JBGuEvHXYFOAA@mail.gmail.com' \
--to=pasha.tatashin@soleen.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mclapinski@google.com \
--cc=nigupta@nvidia.com \
--cc=tatashin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox