From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66363CDD0F4 for ; Tue, 22 Oct 2024 21:03:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D9CF16B00B4; Tue, 22 Oct 2024 17:03:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D4CAC6B00B7; Tue, 22 Oct 2024 17:03:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C14556B00B8; Tue, 22 Oct 2024 17:03:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9E75D6B00B4 for ; Tue, 22 Oct 2024 17:03:50 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DDB53A02B8 for ; Tue, 22 Oct 2024 21:03:19 +0000 (UTC) X-FDA: 82702464306.08.A796631 Received: from mail-oo1-f52.google.com (mail-oo1-f52.google.com [209.85.161.52]) by imf18.hostedemail.com (Postfix) with ESMTP id 5923A1C0019 for ; Tue, 22 Oct 2024 21:03:41 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=XiPJsDF+; dmarc=pass (policy=none) header.from=soleen.com; spf=pass (imf18.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.161.52 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729630861; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SZYynItr3002glGRtAhKYMoiHc4P/Z4cdPRlYmwfRaU=; b=XOusrK5y5fZBYbRi5774lGQiizm/BJvAf0Rkq861Nff3kVC8ktGK5H7wNGFZbAizJsYG3y mOfiuiBon8e175Y5/jsXJ0NqqCZkUW8qYWM86+BdbkOdUJaIQPLCU0tbcpmJoAUEq6sruS qiz3pHXGEFfKYpLOX2cp3LurM88KhEQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729630861; a=rsa-sha256; cv=none; b=qZsyNlyb8DecioNkUTLEmn7B2g0p1dZ33cf0LPIqpSabQoEiZADm1PQgIInKlRUZWZCybE Wxq2T4Q7Dz+WYPyw/+6xUM2O9gQAhUd/AFco177RPVJB/JJAoGVYeKy5JtB1xK0YlOuWO6 Pf/y36G5cUCIalPAaf/H0II1WddkpjI= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=XiPJsDF+; dmarc=pass (policy=none) header.from=soleen.com; spf=pass (imf18.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.161.52 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com Received: by mail-oo1-f52.google.com with SMTP id 006d021491bc7-5ebc52deca0so1369861eaf.3 for ; Tue, 22 Oct 2024 14:03:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen-com.20230601.gappssmtp.com; s=20230601; t=1729631027; x=1730235827; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=SZYynItr3002glGRtAhKYMoiHc4P/Z4cdPRlYmwfRaU=; b=XiPJsDF+t/8BbZorfGyzLZoOnqXzOTk59fiyKMw3agbDItB3EEnrAYsJ0CeAlV/KL9 5IXA5l9cF5vCaV53evbEMbV1zj2uLwVCimH3M4x1j0iUVs7IChJAD18Ou9bh1h2cKakh SIjXOdibD9bSu8beg3TQPGYZQbD8oZuE61VteTKSVewKzOMlN97/1O3WBvE95nI0YjrZ gs6QLVGcwwh++fFGLkqVvE8D2C4qhy+GwQSWnCc1e3iWWe3/AKw+tWPFNTbQYlG0Qbrc 6lLTmxBTQNQynbge/j+Bq6CXWHMoscbT1PqacIGsEr7UjdQBoyKv0cUzKFyasSN9aMvw cdGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729631027; x=1730235827; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SZYynItr3002glGRtAhKYMoiHc4P/Z4cdPRlYmwfRaU=; b=ltKW8lH+naUhzubZhvcvF0fjFh+GbmKlhBbgBkEeX/FY9ZcKlMOjz9ppcUewelcX+w FvUcXiuwwBNV8LJLJiqygLapeKUnVf4QvUUUqDCBlaNAGFecO/6urCJCcL/MYQ4L96dA 32WwSouG1Ih+05RQ9XUJ4eEys5iihbw/kXO7QzES2LjP34gShZkC6lTK72ojlPIo5VUB 4z88Q+BXpO1dv/bpKuXfLxG6vaLXe9wvjghDEWnxgWTu4DjsLqBR8v/2wckHSdIrRfF9 95SWS63IOwPqgPjv0rCt2KR3FukHegSwrzGtuRSTKiMSFLbSh+6D4oNeJqPtBeiPH7DN Qk7Q== X-Forwarded-Encrypted: i=1; AJvYcCUKcCEiIrYhkYARqZJ01aLwdkvDFoinhqEbLX4yGLcNW7NvCrG+R5VJHe5qhgMK4J+9UOYRFGJD1Q==@kvack.org X-Gm-Message-State: AOJu0YwtVZxtxby4dnMqCxEU6MlXZmxU9yviKZEoi8sOyvaXdlo6gNwI NigSAR8CzN5N2b0R8bA07N7HezOP7WcBNkomkcaSwNFm/oI/WsfoDDESgsBPtR0ZFAHoliuR79f yM3l0jw7XdAfrwJW7V4MS+onrxKg2OFrFqSK/hw== X-Google-Smtp-Source: AGHT+IEGkLwDV8Hk7DGupvh45K/EdV0qi8GDuIXpLoxjcrecG53W/vss05MygFhNIl9wlAh1otGQu277VwFw92Wm1SE= X-Received: by 2002:a05:6358:560c:b0:1b8:32b5:4e90 with SMTP id e5c5f4694b2df-1c3d81b404bmr25550855d.27.1729631027330; Tue, 22 Oct 2024 14:03:47 -0700 (PDT) MIME-Version: 1.0 References: <20241022205622.133697-1-souravpanda@google.com> In-Reply-To: <20241022205622.133697-1-souravpanda@google.com> From: Pasha Tatashin Date: Tue, 22 Oct 2024 17:03:09 -0400 Message-ID: Subject: Re: [PATCH] mm/codetag: fix arg in pgalloc_tag_copy alloc_tag_sub To: Sourav Panda Cc: akpm@linux-foundation.org, surenb@google.com, yuzhao@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, weixugc@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 5923A1C0019 X-Stat-Signature: hfxtujjhfyqkau6md3jeon4rnooh1a3e X-Rspam-User: X-HE-Tag: 1729631021-876366 X-HE-Meta: U2FsdGVkX18RAMRuOm4qz5j5PT1kzDtD4UITJHsijynraZ/biYMCqsCZLizBKb8TvxHC7NRk5RNqMlkbPue8LcyvDVJ+KPeDuhRBzX+YqBaBJ1TnkGFJyiLSMP7fXOiAEXi2dlCzweFd/ipVSW7DFICjbWB/05OXhckh3IhkIRP95WmmBtcpwI2npfwE0LPMVbF6jaPfCax86dEKdVRslkDRYtcsh7hbIGYvgoThd8lVQBe2qf4tAD68M+JMfnSN1VmvgUG3CU9JknIPr4EFlyHZ+E4s12rz748J5Gt+CzldIUSFmu99B39jJhQbp79rx/sz1N9nB6aHvWyGOThuK3PqlTAwOaVPu0WmW/B5Ezt6MFU7O4rKgkmYChKjLp63uR6WP71y/w9qLzpM3v7iUL7ytnE/zIutc6Cyd4E6EFwbfggO1W8IwdzYxGzypZKrE/IfMDaaPBSutc49bV38iTiXJUvnbFKCrKgn4/YPF8m+WLPJRavExwdsw3EMoE2aEUj8wtUafC+i0/tY21TiAgi1RJvBXMHcN0OlunyoeSyimIzRlLwK4T36EeNfenEhgTIP1XfgR5UDN4br5htg//diVnr4F7Hc5Tw+fBj3CMEC4FlQY1b0q3IzZQgxg4bSUAWtVtyFWpqoshqPxAPUFGQRW5eCF33pOhXw1IzlGVDSDS901trN6eOdbm7athJDSFemiIl8uaptnGJ+sCPo3Z+CbInQMr1TWEEGM0lZgJtdzLLkbsuQ8PG3veEnk0FpGJcyWuFaUfLWUt38F77Gmk7hOQ3lIezgc6/6p/mqHBILityh0+uHNXLdkQCUA3DSBO+Y/MKXdEU78V4IBctjwEU2/NJRpqXtCxbS8Crx23shkn1bjFM8QXqTbL8wVJ3WsaFFmKRKni0BlRy+EEYrVVnUICHtao/4/YRrFLuY7vGaqw3e7Cn6U9RwOnndkq7mVRAc9gVlFYwbDh/DNsC B26/6vMO jD9vvNtCx6WgsW/cA4u6ckjD+dPhW42z5dvX5VJa4m1vHxiQwU4L+66CmZLA9aEakfY4FlU+5e1hzxkSmLR0JZy5naRm+xBqxJAZiEoIRf4PXb+T/nz+CDVLF5vANQAe0DxMx/TLBeljoKz6J0wTvnCW0fJ/Tm6wFQ3RqknFNvwti3fALZJMvNWEUs0dSH6MtoYnndOsDRTHFsjmZBlbW0BRNJ99YvrNgjHm98LS2jUikDdBbUcFhzYu+FIcSkGxOlyRVUvbq8emdcFGwEHUnnlzd7VZuvxaFd/6+fHD67VPvKSxmfOxJO43vCkwo31q4FkmgVr1x87DP0nJXAZaJFTi/pnF4o1p+7NLu1zHTaxFTRR/jwt+lHyIE3JQyt2EPGJw3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000493, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Oct 22, 2024 at 4:56=E2=80=AFPM Sourav Panda wrote: > > alloc_tag_sub() takes bytes as opposed to number of pages as argument. > > Currently pgalloc_tag_copy() passes the number of pages. This fix passes > the current unit, which is the number of bytes allocated. > > Fixes: e0a955bf7f61 ("mm/codetag: add pgalloc_tag_copy()") > Signed-off-by: Sourav Panda Reviewed-by: Pasha Tatashin Thanks, Pasha > --- > include/linux/mm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index ecf63d2b0582..2890001c8b97 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -4203,7 +4203,7 @@ static inline void pgalloc_tag_copy(struct folio *n= ew, struct folio *old) > /* Clear the old ref to the original allocation tag. */ > clear_page_tag_ref(&old->page); > /* Decrement the counters of the tag on get_new_folio. */ > - alloc_tag_sub(ref, folio_nr_pages(new)); > + alloc_tag_sub(ref, folio_size(new)); > > __alloc_tag_ref_set(ref, tag); > > -- > 2.47.0.105.g07ac214952-goog >