From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EF99C4320A for ; Fri, 20 Aug 2021 17:20:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C1E92611AD for ; Fri, 20 Aug 2021 17:20:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C1E92611AD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 5EC5D6B0071; Fri, 20 Aug 2021 13:20:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 59C3B8D0001; Fri, 20 Aug 2021 13:20:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4650E6B0073; Fri, 20 Aug 2021 13:20:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0197.hostedemail.com [216.40.44.197]) by kanga.kvack.org (Postfix) with ESMTP id 2D56B6B0071 for ; Fri, 20 Aug 2021 13:20:01 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D2C5E181B04AD for ; Fri, 20 Aug 2021 17:20:00 +0000 (UTC) X-FDA: 78496121760.30.4F62D30 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by imf22.hostedemail.com (Postfix) with ESMTP id 7B2BF1901 for ; Fri, 20 Aug 2021 17:20:00 +0000 (UTC) Received: by mail-ej1-f52.google.com with SMTP id gt38so21503639ejc.13 for ; Fri, 20 Aug 2021 10:20:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VG5fvfC7Y3KRpzRAEA18KK6WLNMl8L5Q75OcNDfJ9CE=; b=ikO/PAfJFQUJKrFFQ/NFHitlqiVnSUoUDXWSXtMkcNNf3CTyeoUUBonwMIloJflLz+ huCrEfJaHgg3yivM5K/LSRVwBXVVx8Cqt5AscZBDAgGk4vznRFQKdUYPARAZm0U6CIzp SAe2uTox4gKHqT+v9zOqVvPi1dVz1FzM89vkyWsaTpW0nfihPX1We9/zCONW6DGd14iu wzeMLiPOy6tH2FaUAFOcbMTg/3hdjjIdNB5IDiB+ptLssyR1OgWBCcm1laO5aK7wKbHy ftSiDq5k4ONSQlNKbgwXWoKTMviBV+PrjJsNVKoHhjGkil6MpnoXMiN17NtXMjOotIQ8 870A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VG5fvfC7Y3KRpzRAEA18KK6WLNMl8L5Q75OcNDfJ9CE=; b=TniMyJ3xVvR6gGkJe/JqSzepEjqP6ijGQef9KNQiURiLxmnccpYPV/inByZWrE+L2p U3/EsJJHN7ga+ysG6BRnK3UVtjN8pFE1oJ4iT8L0fOxJQeGDmrPw6kvVgQWD21bmHJQF BjSjyAmFhRhhmdS0CVCGP6WJrnnbEQ/ggiaGJ4t4MBnBn8UDSbAWtAqZYwk2rNms6BWj narWasPwDJ6DDxCTv+FepmppeinLFzpUadWHcCnTO/P1AudXEhC9SZ6IjfagxQxPis3Q 2xuC9tD+FDq6OqZPhSkj9mw6L0xxjq03hjL9LNjMdm3axFNktuGcROzXSzgc/9dOcbA5 0gQg== X-Gm-Message-State: AOAM5328MQOp5yWYNzMAk9BOw9GZ1u5IpgfPpgcwN7wfxCsqugGq2b9O QSWgU1GjJXiaULEJHI/4WcaqEnqUNJpfh1D1s7PhPA== X-Google-Smtp-Source: ABdhPJzZ44FgY6pUApX5hPDqNCIo2OwFIw6hYut4MVzZrKycVCcmV2eZ4QHyQbe2adBLdBie0AsK7xzwIaZvqRqovFg= X-Received: by 2002:a17:906:d20a:: with SMTP id w10mr23610197ejz.426.1629479999204; Fri, 20 Aug 2021 10:19:59 -0700 (PDT) MIME-Version: 1.0 References: <318b946ac80cc9205c89d0962048378f7ce0705b.1629386192.git.zhansayabagdaulet@gmail.com> <20210819162953.GN5469@sequoia> In-Reply-To: <20210819162953.GN5469@sequoia> From: Pavel Tatashin Date: Fri, 20 Aug 2021 13:19:23 -0400 Message-ID: Subject: Re: [PATCH v3 1/2] selftests: vm: add KSM merging time test To: Tyler Hicks Cc: Zhansaya Bagdauletkyzy , Andrew Morton , linux-mm , linux-kselftest@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b="ikO/PAfJ"; dmarc=none; spf=pass (imf22.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com X-Stat-Signature: fga7pair9dr8hj4isnb9kgs59jzj1n18 X-Rspamd-Queue-Id: 7B2BF1901 X-Rspamd-Server: rspam05 X-HE-Tag: 1629480000-343176 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 19, 2021 at 12:29 PM Tyler Hicks wrote: > > On 2021-08-19 21:33:41, Zhansaya Bagdauletkyzy wrote: > > Add ksm_merge_time() function to determine speed and time needed for > > merging. The total spent time is shown in seconds while speed is > > in MiB/s. User must specify the size of duplicated memory area (in MiB) > > before running the test. > > > > The test is run as follows: ./ksm_tests -P -s 100 > > The output: > > Total size: 100 MiB > > Total time: 0.201106786 s > > Average speed: 497.248 MiB/s > > > > Signed-off-by: Zhansaya Bagdauletkyzy > > --- > > v2 -> v3: > > - no changes > > There were no changes to this patch since v2 so my previous review still > stands: > > Reviewed-by: Tyler Hicks Thank you for addressing my comments in v2. Reviewed-by: Pavel Tatashin