From: Pasha Tatashin <pasha.tatashin@soleen.com>
To: David Rientjes <rientjes@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Paul Turner <pjt@google.com>, Wei Xu <weixugc@google.com>,
Greg Thelen <gthelen@google.com>, Ingo Molnar <mingo@redhat.com>,
Will Deacon <will@kernel.org>, Mike Rapoport <rppt@kernel.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
Jiri Slaby <jirislaby@kernel.org>,
Muchun Song <songmuchun@bytedance.com>,
Fusion Future <qydwhotmail@gmail.com>,
Hugh Dickins <hughd@google.com>, Zi Yan <ziy@nvidia.com>,
Anshuman Khandual <anshuman.khandual@arm.com>
Subject: Re: [PATCH v3 4/4] mm/page_table_check: check entries at pmd levels
Date: Wed, 26 Jan 2022 07:46:09 -0500 [thread overview]
Message-ID: <CA+CK2bCd6OXW+PEB6NYvAN61xaaPzT5dWr=REidWX1=e1jrNCg@mail.gmail.com> (raw)
In-Reply-To: <61833f93-31b5-206f-b8c7-a2e55091ac@google.com>
On Wed, Jan 26, 2022 at 1:45 AM David Rientjes <rientjes@google.com> wrote:
>
> On Wed, 26 Jan 2022, Pasha Tatashin wrote:
>
> > syzbot detected a case where the page table counters were not properly
> > updated.
> >
>
> Is there a Reported-by tag that syzbot wants us to use to track this?
Google internal syzbot found it, so I did not add Reported-by as there
is no public e-mail to reference. However, I added all the necessary
steps to repro this problem to the cover letter.
>
>
> This looks right, I'm wondering if we want to add a
> mmap_assert_write_locked(mm) to collapse_and_free_pmd().
Good idea, I will add it in the next revision.
Thanks,
Pasha
prev parent reply other threads:[~2022-01-26 12:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 6:05 [PATCH v3 0/4] page table check fixes and cleanups Pasha Tatashin
2022-01-26 6:05 ` [PATCH v3 1/4] mm/debug_vm_pgtable: remove pte entry from the page table Pasha Tatashin
2022-01-26 6:26 ` David Rientjes
2022-01-26 6:05 ` [PATCH v3 2/4] mm/page_table_check: use unsigned long for page counters and cleanup Pasha Tatashin
2022-01-26 6:29 ` David Rientjes
2022-01-26 6:05 ` [PATCH v3 3/4] mm/khugepaged: unify collapse pmd clear, flush and free Pasha Tatashin
2022-01-26 6:34 ` David Rientjes
2022-01-26 12:34 ` Pasha Tatashin
2022-01-26 6:05 ` [PATCH v3 4/4] mm/page_table_check: check entries at pmd levels Pasha Tatashin
2022-01-26 6:45 ` David Rientjes
2022-01-26 12:46 ` Pasha Tatashin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+CK2bCd6OXW+PEB6NYvAN61xaaPzT5dWr=REidWX1=e1jrNCg@mail.gmail.com' \
--to=pasha.tatashin@soleen.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=anshuman.khandual@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=gthelen@google.com \
--cc=hpa@zytor.com \
--cc=hughd@google.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=pjt@google.com \
--cc=qydwhotmail@gmail.com \
--cc=rientjes@google.com \
--cc=rppt@kernel.org \
--cc=songmuchun@bytedance.com \
--cc=weixugc@google.com \
--cc=will@kernel.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox