From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58B69C433EF for ; Thu, 30 Sep 2021 02:45:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C0098613A5 for ; Thu, 30 Sep 2021 02:45:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C0098613A5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 1784594007C; Wed, 29 Sep 2021 22:45:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 128D594003A; Wed, 29 Sep 2021 22:45:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F321994007C; Wed, 29 Sep 2021 22:45:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0062.hostedemail.com [216.40.44.62]) by kanga.kvack.org (Postfix) with ESMTP id E0E8194003A for ; Wed, 29 Sep 2021 22:45:02 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id A41A2274DB for ; Thu, 30 Sep 2021 02:45:02 +0000 (UTC) X-FDA: 78642697644.16.0D821E1 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by imf14.hostedemail.com (Postfix) with ESMTP id 4B49660019BD for ; Thu, 30 Sep 2021 02:45:02 +0000 (UTC) Received: by mail-lf1-f46.google.com with SMTP id e15so18974506lfr.10 for ; Wed, 29 Sep 2021 19:45:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Rbhsc9J7XsMrioXJqfrxY/zmGhcXPZ+JV/XkI67QIjQ=; b=IwaYxISK5oSeVmHWe75HUpypgzEmLhpIY5wMJH92Lj4/2lNQSxa95Oq7sCfF3Bq/l8 QcBh4WdW2wMf2WHlaUvQx9amF8G6tBphTKNN7prwZo2IdiKrt2mAyqIXD4RtJ2KW8XVx q52Wnl7mt+ZZxHZ/4LjUzlxhsi/kvhB0OL4YAqfdCn53/UnKxQY502s1PhvHQuJtCQHu gm77meiCKmO3Nh8bPkl56cgcwf74w4Q4RHqu6p65vmCZn157xUz3PyVYX5FTe3GMLqeH 63I9qj5KbiefBz1k1e1A+g8bAP/iwvx9Mm8Us5EmGX5JOYIxotojnP2FE/By/q37x1kN HyvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Rbhsc9J7XsMrioXJqfrxY/zmGhcXPZ+JV/XkI67QIjQ=; b=r+sjwg1syZp2jAy88hLI61JD9tLvZg1iU04pNs0dZveA2HD0DDXl0iz2yUIcwfYdd7 5ZQ7kbGUWiZhVcqz50JSxOVlbKfEK0RxtAS9v5KpBxu7K5OXOeU2zkJN4BL3xXP+JFUf HTFaKNlaKlD+IuD2nbDwoIff51bjwKkdzvhsM1W9A/A++3HXbSyLWHQUgXooPOROEOJh WnTcBWmxR86myEQoqgpqc+VQlrNO/R0XZoorXYSGF8L4usgiU6ddhvSc30eSs2i6DBi+ AQTVlSQLdEGADBy7N1b4p61YMIshjiGwjsEPIZMNDnZOQIrxK9l5nAdlRcu0UcwKuVSz d3Lg== X-Gm-Message-State: AOAM532JK6VSOSLHEJ8PXhdcuOcXalt1Z2wlU9xiQUZPy1V3KOJCnBxQ 1QPmx+d1pe/zO7APwxR4qo7vH8bZ8LWyA5+ACVF8Uw== X-Google-Smtp-Source: ABdhPJyQJRVQGyEYu5wfNE6U6Pt+vKWE6vtHQppYUn0Bj+uAdeYrnCq4LIUiSjO0TXF1W62OsGwC3pRNI5s3rOVYJ40= X-Received: by 2002:a05:6512:b08:: with SMTP id w8mr3159158lfu.505.1632969900574; Wed, 29 Sep 2021 19:45:00 -0700 (PDT) MIME-Version: 1.0 References: <20210916231325.125533-1-pasha.tatashin@soleen.com> <20210916231325.125533-6-pasha.tatashin@soleen.com> <20210929121336.GB21631@willie-the-truck> In-Reply-To: <20210929121336.GB21631@willie-the-truck> From: Pasha Tatashin Date: Wed, 29 Sep 2021 22:44:23 -0400 Message-ID: Subject: Re: [PATCH v17 05/15] arm64: kexec: skip relocation code for inplace kexec To: Will Deacon Cc: James Morris , Sasha Levin , "Eric W. Biederman" , kexec mailing list , LKML , Jonathan Corbet , Catalin Marinas , Linux ARM , Marc Zyngier , James Morse , Vladimir Murzin , Matthias Brugger , linux-mm , Mark Rutland , steve.capper@arm.com, rfontana@redhat.com, Thomas Gleixner , Selin Dag , Tyler Hicks , Pingfan Liu , Andrew Morton , madvenka@linux.microsoft.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 4B49660019BD X-Stat-Signature: a7p3n1z3wn7964irtjpty5ryg8f1or4e Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=IwaYxISK; dmarc=none; spf=pass (imf14.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com X-HE-Tag: 1632969902-666115 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Will, > > + cpu_install_idmap(); > > + restart = (void *)__pa_symbol(function_nocfi(__cpu_soft_restart)); > > + restart(is_hyp_nvhe(), kimage->start, kimage->arch.dtb_mem, > > + 0, 0); > > Why can't you call: > > cpu_soft_restart(kimage->start, kimage->arch.dtb_mem, 0, 0); > > here instead of open-coding it? This is part of a cleanup to remove cpu_soft_restart() wrapper and the header file that contains it. The wrapper is simple enough and has only one call site. It makes more sense to do what is needed directly from machine_kexec(). Pasha