From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B592C433FE for ; Thu, 10 Dec 2020 13:30:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 71FE423BAB for ; Thu, 10 Dec 2020 13:30:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 71FE423BAB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DBF376B005D; Thu, 10 Dec 2020 08:30:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D6E816B0068; Thu, 10 Dec 2020 08:30:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C5C516B006C; Thu, 10 Dec 2020 08:30:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0105.hostedemail.com [216.40.44.105]) by kanga.kvack.org (Postfix) with ESMTP id AA6066B005D for ; Thu, 10 Dec 2020 08:30:41 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 665B21EE6 for ; Thu, 10 Dec 2020 13:30:41 +0000 (UTC) X-FDA: 77577457482.29.sock75_1c0c73f273f8 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id 4154A18086CCF for ; Thu, 10 Dec 2020 13:30:41 +0000 (UTC) X-HE-Tag: sock75_1c0c73f273f8 X-Filterd-Recvd-Size: 5593 Received: from mail-ed1-f67.google.com (mail-ed1-f67.google.com [209.85.208.67]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Thu, 10 Dec 2020 13:30:40 +0000 (UTC) Received: by mail-ed1-f67.google.com with SMTP id p22so5462730edu.11 for ; Thu, 10 Dec 2020 05:30:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qIiXZlbTMuOjaSEMVqtFB6pB00HTPLen1qKXz/tc/w4=; b=d/xbjFBJuPt09Moenjfm3UdGX4TVhWRqyMqX0ktZwR79L40k4GEKzIkKORO2Z0CINr 4T7jaqdKoxk5yuKKjHoECVhW8+UraRZYdD/PFnTDuUNn6gKFU2/t1QGEs3oyHNLZfP9s f/RXGctRNpk3r1kQ5UUt/OfZfP36nQ0BXQBBw9fcPiWhKmxYhVcOBuZ5zoy82p9a2Mww fI1y1QEiDQ1tXs1csraPkHWGPUh61JMtkYH7lstW8pdNCZ8iG3MId4ewJ55x1dGWx97f q2wZxVdAGrBJhpwUSYgNBwIeWdz+5Jm9lpFOeZ9v6Tt7S6IKoQWy4f7SRpOk7A2y4Ls+ zXEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qIiXZlbTMuOjaSEMVqtFB6pB00HTPLen1qKXz/tc/w4=; b=pLuj4yUkaIox+EiOUhhAYEcSTHyyWQKOHfbkxHL9VQcmUwXrHBdUNg+BXeXJFC9VbQ UnQiSs1mPTaOV/3tWMzbdDZDJ20Ae0HdzT7jfAAGRsENIlEjH63n78Bl8t60riF3dTis C88P1LrYXht1LBB6zbz4eHjpUa0znmTciYz2cNAmp1s/Fu18rKNgHFDXuzV+uYtrOrER 2ebgBRoTBg2wu4w9etCQaz1HvZpKUzYK1vnir6K4cmsxJXR+HOoGqrRfHUWdML5Eeu6C FTUz7MCdcMn3QLWusYo72Vok8hSH8DM1sjDvau8bWiUTbMp781/NjRxPJud0092mQSWu P8mQ== X-Gm-Message-State: AOAM5333oEATw0CZMzjTE4REUrecJWoFD3AkEg2K4TLd+mSqsJLBJKD/ RMxqZ9+es35VQ5C3yx1Zu6JinOUEG+zYWoAsK4fG6A== X-Google-Smtp-Source: ABdhPJzbv+0w87d8raPbwJYgG4lQqkPBXI5t6mWVFwqoR7W+om+Oee3IcTAbGBN3WSP8/XgWKhc5sKqsUR60nXXGBSs= X-Received: by 2002:a50:e00f:: with SMTP id e15mr7078798edl.210.1607607039197; Thu, 10 Dec 2020 05:30:39 -0800 (PST) MIME-Version: 1.0 References: <20201210004335.64634-1-pasha.tatashin@soleen.com> <20201210004335.64634-4-pasha.tatashin@soleen.com> <20201210040618.GR1563847@iweiny-DESK2.sc.intel.com> In-Reply-To: <20201210040618.GR1563847@iweiny-DESK2.sc.intel.com> From: Pavel Tatashin Date: Thu, 10 Dec 2020 08:30:03 -0500 Message-ID: Subject: Re: [PATCH v2 3/8] mm/gup: make __gup_longterm_locked common To: Ira Weiny Cc: LKML , linux-mm , Andrew Morton , Vlastimil Babka , Michal Hocko , David Hildenbrand , Oscar Salvador , Dan Williams , Sasha Levin , Tyler Hicks , Joonsoo Kim , mike.kravetz@oracle.com, Steven Rostedt , Ingo Molnar , Jason Gunthorpe , Peter Zijlstra , Mel Gorman , Matthew Wilcox , David Rientjes , John Hubbard , Linux Doc Mailing List Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 9, 2020 at 11:06 PM Ira Weiny wrote: > > On Wed, Dec 09, 2020 at 07:43:30PM -0500, Pavel Tatashin wrote: > > __gup_longterm_locked() has CMA || FS_DAX version and a common stub > > version. In the preparation of prohibiting longterm pinning of pages from > > movable zone make the CMA || FS_DAX version common, and delete the stub > > version. > > I thought Jason sent a patch which got rid of this as well? Yes, this series applies on the mainline so it can be easily tested. The next version, I will sync with linux-next. Thank you, Pasha > > Ira > > > > > Signed-off-by: Pavel Tatashin > > Reviewed-by: John Hubbard > > --- > > mm/gup.c | 13 ------------- > > 1 file changed, 13 deletions(-) > > > > diff --git a/mm/gup.c b/mm/gup.c > > index 3a76c005a3e2..0e2de888a8b0 100644 > > --- a/mm/gup.c > > +++ b/mm/gup.c > > @@ -1567,7 +1567,6 @@ struct page *get_dump_page(unsigned long addr) > > } > > #endif /* CONFIG_ELF_CORE */ > > > > -#if defined(CONFIG_FS_DAX) || defined (CONFIG_CMA) > > #ifdef CONFIG_FS_DAX > > static bool check_dax_vmas(struct vm_area_struct **vmas, long nr_pages) > > { > > @@ -1757,18 +1756,6 @@ static long __gup_longterm_locked(struct mm_struct *mm, > > kfree(vmas_tmp); > > return rc; > > } > > -#else /* !CONFIG_FS_DAX && !CONFIG_CMA */ > > -static __always_inline long __gup_longterm_locked(struct mm_struct *mm, > > - unsigned long start, > > - unsigned long nr_pages, > > - struct page **pages, > > - struct vm_area_struct **vmas, > > - unsigned int flags) > > -{ > > - return __get_user_pages_locked(mm, start, nr_pages, pages, vmas, > > - NULL, flags); > > -} > > -#endif /* CONFIG_FS_DAX || CONFIG_CMA */ > > > > static bool is_valid_gup_flags(unsigned int gup_flags) > > { > > -- > > 2.25.1 > > > >