From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAC78C47073 for ; Thu, 4 Jan 2024 19:13:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F4B48D001B; Thu, 4 Jan 2024 14:13:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 17B158D0018; Thu, 4 Jan 2024 14:13:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F36E78D001B; Thu, 4 Jan 2024 14:13:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DE60B8D0018 for ; Thu, 4 Jan 2024 14:13:05 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BDA4EA09F5 for ; Thu, 4 Jan 2024 19:13:05 +0000 (UTC) X-FDA: 81642576330.28.4D52404 Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) by imf08.hostedemail.com (Postfix) with ESMTP id E35BD16000D for ; Thu, 4 Jan 2024 19:13:03 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=TSQigsPR; dmarc=none; spf=pass (imf08.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.210.45 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704395584; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/+vYEuDAPJ/iEdESxX2pInRN4g9EPXyQ5h9FSdd/4u4=; b=YTOYvHuuaqCqECsjmsullO00lAjCunffY4xZhUIkV4zdfJxEKwS7W9O+AL+F31r9ci2JnR Bd0gDcRODIJY4tez/9C1YJ+5JbYEWFhAarSSc+lwBoyPoSVbFIKF1Hh6B0OIaApNiOXsg6 aGdy+Z07M3sMvNSOnlUAbZpUFV0smOk= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=TSQigsPR; dmarc=none; spf=pass (imf08.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.210.45 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704395584; a=rsa-sha256; cv=none; b=s5KW3lmWhaZ16Oy3nQo+xuQjvKmf+X2NK2Fz3UteFSspJaFulKdUuYXmtgHzSqUHCpsSN/ rsBiCjmoHcw3zN6Q7nN1VWbr1ALpHKt9e08sO/IHalX3npBxIVhY9tMm9M5Pj17L1sMlum eeYIYABzmQYbvUg+IBUn/e0dWpCB0qs= Received: by mail-ot1-f45.google.com with SMTP id 46e09a7af769-6dc1fdc19b6so521008a34.0 for ; Thu, 04 Jan 2024 11:13:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1704395583; x=1705000383; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/+vYEuDAPJ/iEdESxX2pInRN4g9EPXyQ5h9FSdd/4u4=; b=TSQigsPRPYeVXvIm/Z4KkxaatOjHppO7204+cP54UlUHFSvkfDRqQgXgtLQeBrqtJl 1ynaCouUhjMzeoCsCYwamB/Nc6bLDXnDq26aPGqb1ZRRbKnWTYzX4CtVpcrZxvPa0uuM 4rMG1QsKPsvj1lKiZVKhcP8k+r975ScNo2Bhb+kkDKlY7DfONlomX46oejUOZlNZruxo vjhLCQ+FOB7FmyqSaLLHDaGGmSz1+8pCCTfSOALwItKnDeQwL6hngm8cLa+0P8R2kS3U qPC5GN2MfZK3y82IJxqV+67Sjsz6RwwzOYE6JnCwwiP9P3ldDUyjhbvWycTikpU3EWW/ 3b1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704395583; x=1705000383; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/+vYEuDAPJ/iEdESxX2pInRN4g9EPXyQ5h9FSdd/4u4=; b=akra0R5fyhfHKmGlk3IZhAGJO1Y3F+yQdFkTUNlIyEH/x0hvOoYGG1EEhJAygEfjvM +4JH7Rff28oe6hApganWUV4y10hqauJ20yxz1gZ24R7rVJOMJSgPD2VJFraYNOPeURJT llXoqG8wS11YOkyxL12gx9yuLV6P6KA57iO6KpKq5vRrO7WewfL+wRWJFiVzq7JrAW1Q azh7VU6BymLynuh2+x7bmjJ5TwJxx1GGYxgn4gmFYWj12CRLuE3zZKCInrhBhgMKf5Zv xe0pXUyWNVhlJZ3NZ66BL2/7pWWQI/ezIx731RfHFswmUdO1XLfNO9kOmCum9dCn1O/6 /jTw== X-Gm-Message-State: AOJu0YwBfqZY3CuqSAp7h83mAkXmgZUnmLw42qbiu8XnwzR31XetfiE+ X//d39NyVTF6eri+0yDfGsxhHD3UqgGAV5S1vo3xrh9IcpoAQA== X-Google-Smtp-Source: AGHT+IF/5x1qWEeEN53jwIdamLjEry3P/nE1f12xa2taaKft/YlEJdrBP6aDzExJ1bDcrqKpemuFKkiIEAFmrNQGE5k= X-Received: by 2002:a05:6358:8828:b0:174:b7f2:51db with SMTP id hv40-20020a056358882800b00174b7f251dbmr1188037rwb.19.1704395582852; Thu, 04 Jan 2024 11:13:02 -0800 (PST) MIME-Version: 1.0 References: <20231226200205.562565-1-pasha.tatashin@soleen.com> In-Reply-To: From: Pasha Tatashin Date: Thu, 4 Jan 2024 14:12:26 -0500 Message-ID: Subject: Re: [PATCH v3 00/10] IOMMU memory observability To: =?UTF-8?Q?Michal_Koutn=C3=BD?= Cc: akpm@linux-foundation.org, alim.akhtar@samsung.com, alyssa@rosenzweig.io, asahi@lists.linux.dev, baolu.lu@linux.intel.com, bhelgaas@google.com, cgroups@vger.kernel.org, corbet@lwn.net, david@redhat.com, dwmw2@infradead.org, hannes@cmpxchg.org, heiko@sntech.de, iommu@lists.linux.dev, jernej.skrabec@gmail.com, jonathanh@nvidia.com, joro@8bytes.org, krzysztof.kozlowski@linaro.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, lizefan.x@bytedance.com, marcan@marcan.st, mhiramat@kernel.org, m.szyprowski@samsung.com, paulmck@kernel.org, rdunlap@infradead.org, robin.murphy@arm.com, samuel@sholland.org, suravee.suthikulpanit@amd.com, sven@svenpeter.dev, thierry.reding@gmail.com, tj@kernel.org, tomas.mudrunka@gmail.com, vdumpa@nvidia.com, wens@csie.org, will@kernel.org, yu-cheng.yu@intel.com, rientjes@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E35BD16000D X-Stat-Signature: m5f5xbpqf457yht3uuicgsfenhxqberh X-Rspam-User: X-HE-Tag: 1704395583-570196 X-HE-Meta: U2FsdGVkX19lkAJnJS8II1iUcEG8tWX0jc+VxrqWtLqLJurFsfCPkSZSO+qNgNeocwoOGU/YcgHyw7yVPA0RzzhGPChyx+oktyqsTqhMNH0JjG7k60DSAxO51EA5xpP+dXdINiz6gtp+b3/jcQ1cGAH64WivQ2bGtihz+Z6PHekV8eZZLCPuGZlRaPlv68GmeBS5U6vMtQTsiP6O+mVmVe116Hcja5YwxKsQ6i4eJEXwRG+rh4UaYZCFc1xTrw4JyKBxzD9rNPJ1qOTUSSTohliDrQJKieieme1ADDwlMGL3mkGBqlnez0EpioSFY1joznS9F2rs1sOF3DB/fgF8/cOuVw5JrZRj62kXBm1hbdeVQVxIAQeR+ILPA1LhLkROizSEIfEZa7/ZTuNtCvtYWcdanmyka1xUBtBgsRNGkq+Ebi8iZX6OyBTkJzTCzfJWa74D/UKUXRmyfUUX3T+vzrhhZYnohhfFSn5qYNMQ+TMcLcnsOyE3XIVGuTVYzMnKJpoF7WCnpCuATPCexzkxI+9hUM8P3p8PP3sp1VeI/G2K/32A52LPhOmXhx7/oxsR9dK1BYtDUdpSe5hafARprJF3JYtuCDRLWikWJZtAf2V74SCKSINU6ODmn812bc5XjwLqDhEtoo1rLKYTc1q4WNZ5fYoh/KG+V8kmR08x7v4ggt9zxlo1tBDFu0ViJ+hGBgfmvycVwZAGn4VMbTdabXK1I2To/dXzDvpjj7T92urroYejbD0bsyBi7PhQ/QegYGQ9aEYwIaTDYsI2zR1ZJYuV+z+BUKIgLLIMQkcZL7jCK2ZLV6jC+a4drdY9uqOPPZD0CV80n+qZy+JIG7SdXemjH+WbWWm2oRGZxIHY1dJAFhDsVM++clb8hegU6c9Esykff4iOq5hXb8KGoddyqQrIRI/1TZ0qmjz0yTKGkuk4Z7r1B/7KIBVMyUqwxbzAqi6fMUmMXerqTa1hhun hqBr97x/ 2+PpzzJEvaATSFMZ2LKRkerAQHcfx0nIJZXKAoGzzJyI0Gx3X4MS25BZTXgdeNRMwFyHw5V77LKkglD7dHeBOV8ZfhkoGcrwMq8UX1+mBiLx2CkfdOJ+G19yduUKX1dg6oUURvTFhciz3xDTFrWH2mbjmNVniqhjDQHKnwH8KdII1yRNaieNg9QFzXZf4ptXA7nhPeiUP/UOzVvFvIA/MpDP5gw6u2UoXX9jPrpM38tehokC+y4fPXZazlBytJb6wQx52Q7EDagy0LabTznPr2qAFTa35Of5Mgco0QDQnUkVm1HgtQs2ZbvNCkocrBWTtAs24HWEfKvcRnzJ7D7QIOoUu/6+7bunA24OspoiKlbB5pkxSl2dm1ukruA3dWHnH7ZKJSX7YWBO3Phc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 4, 2024 at 12:04=E2=80=AFPM Michal Koutn=C3=BD wrote: > > On Thu, Jan 04, 2024 at 11:29:43AM -0500, Pasha Tatashin wrote: > > Thank you for taking a look at this. The two patches [1] [2] which add > > GFP_KERNEL_ACCOUNT were sent separate from this series at request of > > reviewers: > > Ah, I didn't catch that. > > Though, I mean the patch 02/10 calls iommu_alloc_pages() with GFP_KERNEL > (and not a passed gfp from iommu_map). > Then patch 09/10 accounts all iommu_alloc_pages() under NR_IOMMU_PAGES. > > I think there is a difference between what's shown NR_IOMMU_PAGES and > what will have __GFP_ACCOUNT because of that. > > I.e. is it the intention that this difference is not subject to > limiting? Yes, we will have a difference between GFP_ACCOUNT and what NR_IOMMU_PAGES shows. GFP_ACCOUNT is set only where it makes sense to charge to user processes, i.e. IOMMU Page Tables, but there more IOMMU shared data that should not really be charged to a specific process. The charged and uncharged data will be visible via /proc/vmstat nr_iommu_pages field. Pasha > > (Note: I'm not familiar with iommu code and moreover I'm only looking at > the two patch sets, not the complete code applied. So you may correct my > reasoning.) > > > Thanks, > Michal