From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 711A0C54EED for ; Mon, 30 Jan 2023 17:20:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0382E6B0071; Mon, 30 Jan 2023 12:20:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F2A986B0073; Mon, 30 Jan 2023 12:20:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF18E6B0074; Mon, 30 Jan 2023 12:20:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CC27A6B0071 for ; Mon, 30 Jan 2023 12:20:38 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9637BC0AC7 for ; Mon, 30 Jan 2023 17:20:38 +0000 (UTC) X-FDA: 80412129756.13.4FF46CB Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by imf20.hostedemail.com (Postfix) with ESMTP id DBD971C001C for ; Mon, 30 Jan 2023 17:20:35 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=e+ydzywh; spf=pass (imf20.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675099236; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BrsBUBgNgJpeJwfPSLgPW4cYzXKkUkqJeLurEgVFBvc=; b=cV7P7mDkYszfGUmqP7gfpB39enSwJ7izk0y/CFgM/A+MGOr4PlEuf4ha5xuHkTn8/G+jp/ 9TyNfId0ZUv0hypsww5IXxpKXtLyiSursUCB0m9XTa/kz/2ZjrQQI4Zaf+m2QAxo3p1n5y VpSNPTurM0HpEIk69/mqb89qI7oSBK0= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=e+ydzywh; spf=pass (imf20.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675099236; a=rsa-sha256; cv=none; b=rzBZRG0uubADkielBBwLwg5ndoDOQlIb6AAOy2hqaVMuIlUATTTXraXDAmh08tmfOLZIJX 5BR7W3n4vWGTCIDf7V7XnMSoD3Racn3RGGKWR57C7iM9fqQaWK1mqUVvmqMJ+ANeH6cUro ItGkbSuLqN/u4bkTqAUCTx78np1uulc= Received: by mail-qt1-f179.google.com with SMTP id z5so1154719qtn.8 for ; Mon, 30 Jan 2023 09:20:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=BrsBUBgNgJpeJwfPSLgPW4cYzXKkUkqJeLurEgVFBvc=; b=e+ydzywhD50AlIneG126hNOaWzSz7WikqeahTj6y7F0YaCURJalHIeVE4ABw/7sxVO m/3ONdqr9MSPu7D7CTSai9UauHJI281QP2hXt+MKIGoOscPaGV2whzM92UsCoyo5J4EB fLz3E2evnvdnTZMAvV987t7Qn7dSJZrOEBt6WQHVY81jkBD57jqajUTYkpesy9Dx4Yw3 8pVoPOscYE/k3Pbq+VlvjaD0oE+QFDrtJ4zQ4LWxCn3ZvJPkkAudndDCOswBZEvCnHvT MCfSPE84Ugnh4GEZkABPP+/k7rWmEUv1qM2mVsFn4+Ntxte4gbeuqF2ESRrIsV69GYUK Lgdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BrsBUBgNgJpeJwfPSLgPW4cYzXKkUkqJeLurEgVFBvc=; b=GxZPeh5N9i2Q9uDpeWPLplgTJTTQy9Mnmb2xlLAaNpfGRP6BzzvVdQsZPVOXzx5DBM gqbeatzPx5RkKtDUrWScnN5kRvtWTRGxXNrcC9W1VTt/0FhisP7reHPB9vhVUqUvDh3B 1drswozCRCyD/UuthtJFIWXCEg09F5K6mUimnGWdEgQx8A9BYGR60XQLKc/MNzFJ05uZ WQOpNtpauR2+Lkeb5ohqyKId5vExBww2U9TXBBwMevPmZDFkxTfYBzvm1LQ7hff9saHe 42w7EVAODXMUpLA1pYYWsajYE6XwKPVOVyUQf4smunElUUVXRE5k7JPsgPpUFrSIP4nJ w/kg== X-Gm-Message-State: AO0yUKVORyOuKfYlWBlq2LqOtYMKOCe2cjiiVKJ7Rac6QcV/E5/ifTIV RVgGiq8ALH05T4DUOJBMqZvagO3yLHZM6/rlPMZBTw== X-Google-Smtp-Source: AK7set85qwFb9Qlw4P1CLRjHWKhUUqR7Y9GnLcrwx2XjDh1/2RDOFjTZjB3GMRx2Q2qm8ZWsz1MqPstnRa5cu1JQ+z0= X-Received: by 2002:a05:622a:1a0a:b0:3b9:a428:68d with SMTP id f10-20020a05622a1a0a00b003b9a428068dmr97209qtb.482.1675099234975; Mon, 30 Jan 2023 09:20:34 -0800 (PST) MIME-Version: 1.0 References: <20230130130739.563628-1-arnd@kernel.org> In-Reply-To: <20230130130739.563628-1-arnd@kernel.org> From: Pasha Tatashin Date: Mon, 30 Jan 2023 12:19:58 -0500 Message-ID: Subject: Re: [PATCH] mm: extend max struct page size for kmsan To: Arnd Bergmann Cc: Andrew Morton , Alexander Duyck , Michal Hocko , Pavel Tatashin , Alexander Potapenko , Arnd Bergmann , "Matthew Wilcox (Oracle)" , David Hildenbrand , "Liam R. Howlett" , John Hubbard , Naoya Horiguchi , Hugh Dickins , Suren Baghdasaryan , Alex Sierra , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: DBD971C001C X-Rspam-User: X-Stat-Signature: 3bknkoopuqbzo1t5ghocjj5q6wq4kf7j X-HE-Tag: 1675099235-684059 X-HE-Meta: U2FsdGVkX1+uL2ucsFS5hCk4+Dw6NqKZYlsXT5diyR+vG1SY4W/RWA4X674a1d8wcjko5Fml2FwBL2c9sbcW07H1s5rg9cEnF1gmOPnPRIliXPDJ652UfYfrKlmylUd39H6H2/nj2B53h5BjkR+2RJb2Wa6Mo5S2pPJOTej40/S9VOrWhfwpCqAg3v1N7Ho4BDtHapC7a+W94fWaPDq54f2hK6CeG8J1F77CVCu6DyXOYC7YIrXYZXXWxmD2pRcx+LqgPeO56mzPFpM/nESt3nHaZ7SxrQkPlBYiMIj6QKesMxvlPQC6a2DEhn+9pbWJzJwbIh0r1T+MN2ht/RYBz9h387mXWDWKTmjEblTY/zwvUk1dFw0VWDct28xhQyT4yaB/pRJlTaP/iRYxnt1YSGAjYCXHni85H7WPL8sxdU/nLpL9C4+kwmCwM6hXD/On8mhoHnYaXphzTvzE9uWe5L0HFKBN9JOGu2cctv8+R6ayjt3cai5VKYRVaoBsPCWQPLZXaQgPhMLzkMLiMhLvOjnYD6vDAHUwNi9cu08SdWCDtotqlGQJkUio+6e7oOJcscHASGEGf8vAZABkDIbrbAMLTiNwdZYgSwtpyGT/wf3WAKyHa0cM/hHjdsTsb5i/Tdczy4kOtPS06Xh5VKQuk6iJOQ7VViy2GGhAZIWkpz6bZZAR9BZaX/kCQNl7uoepTOZdNPKJuF89rRvi37EcP58AThSJyOvW3ugIgSbCbYywXaLrQOK0xiSOuRlEkjkGKb3oFcxM44Y/o6uOuXZFG7R+P4HzGoBvKi11FyiO5ixU+YIJefnM+0WTdgWSmJwAt5vIQ4WSV1ozHyt0wl7FWs0CbGfzkcOvRF/CfFD2Yl/jsNlu1GfLyFDcQ2Oa1ketwzoYvLIUEz/PhtilUiOv5Tqz342+5ZJSn9APbVZ7WG2j7c2EY1ZIw/nAAXk9M5iZ1Z8Rk6FzmvbwCB4xfz7 oIKcd9XL cAxGExZuKlAW55Lp1y7dY1qr62BoQtkKp7JMPjCHE+O3E/5/2QqpLtq8G7uPDG3V4LIrhggHo8mK1WN6lrNnKSpgWCx7veKF6HGviP09fFBkov5mrkuXFBJkuWVNpD9uTeF0PFtUwrBJxQhHl7T/LzLFe7ewWGzbhrHWBesmWoP6aLMeHpxVTu+KseMLXcHyIhE8qFcVkeFmcBtF8mCTuEalyyGg2+bRzSy2Kaumfbov4Yy0xcejwlUXgZSK2OguzhnCmVxiFU/D0LaTf4eLLINQa3WnuyCjkrxfvkkthPr/ZtgxJdkZheVIprjDkgm8aSIHgfVXunYga/vuJCPZ2w3K9RQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 30, 2023 at 8:07 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > After x86 has enabled support for KMSAN, it has become possible > to have larger 'struct page' than was expected when commit > 5470dea49f53 ("mm: use mm_zero_struct_page from SPARC on all 64b > architectures") was merged: > > include/linux/mm.h:156:10: warning: no case matching constant switch condition '96' > switch (sizeof(struct page)) { > > Extend the maximum accordingly. > > Fixes: 5470dea49f53 ("mm: use mm_zero_struct_page from SPARC on all 64b architectures") No need to add the above "Fixes:". The above patch works as expected everywhere where the struct page is 80 bytes or smaller (as specified by the comment). I also agree with others that the KMSAN should be part of page_ext instead of increasing the complexity of "struct page". Otherwise, Reviewed-by: Pasha Tatashin Thanks, Pasha