From: Pasha Tatashin <pasha.tatashin@soleen.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Alexander Duyck <alexander.h.duyck@linux.intel.com>,
Michal Hocko <mhocko@suse.com>,
Pavel Tatashin <pavel.tatashin@microsoft.com>,
Alexander Potapenko <glider@google.com>,
Arnd Bergmann <arnd@arndb.de>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
David Hildenbrand <david@redhat.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
John Hubbard <jhubbard@nvidia.com>,
Naoya Horiguchi <naoya.horiguchi@nec.com>,
Hugh Dickins <hughd@google.com>,
Suren Baghdasaryan <surenb@google.com>,
Alex Sierra <alex.sierra@amd.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: extend max struct page size for kmsan
Date: Mon, 30 Jan 2023 12:19:58 -0500 [thread overview]
Message-ID: <CA+CK2bCQPxcXX0uAZUkfjEAHyyCfGz08s0=iDkWr0_9O19nRxw@mail.gmail.com> (raw)
In-Reply-To: <20230130130739.563628-1-arnd@kernel.org>
On Mon, Jan 30, 2023 at 8:07 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> After x86 has enabled support for KMSAN, it has become possible
> to have larger 'struct page' than was expected when commit
> 5470dea49f53 ("mm: use mm_zero_struct_page from SPARC on all 64b
> architectures") was merged:
>
> include/linux/mm.h:156:10: warning: no case matching constant switch condition '96'
> switch (sizeof(struct page)) {
>
> Extend the maximum accordingly.
>
> Fixes: 5470dea49f53 ("mm: use mm_zero_struct_page from SPARC on all 64b architectures")
No need to add the above "Fixes:". The above patch works as expected
everywhere where the struct page is 80 bytes or smaller (as specified
by the comment).
I also agree with others that the KMSAN should be part of page_ext
instead of increasing the complexity of "struct page".
Otherwise,
Reviewed-by: Pasha Tatashin <pasha.tatashin@soleen.com>
Thanks,
Pasha
prev parent reply other threads:[~2023-01-30 17:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 13:07 Arnd Bergmann
2023-01-30 13:38 ` Michal Hocko
2023-01-30 16:47 ` Matthew Wilcox
2023-01-30 18:20 ` Alexander Potapenko
2023-01-30 17:59 ` Alexander Potapenko
2023-01-31 15:14 ` Michal Hocko
2023-01-31 15:17 ` Alexander Potapenko
2023-01-31 16:03 ` Alexander Potapenko
2023-01-30 16:29 ` Alexander Duyck
2023-01-30 17:19 ` Pasha Tatashin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+CK2bCQPxcXX0uAZUkfjEAHyyCfGz08s0=iDkWr0_9O19nRxw@mail.gmail.com' \
--to=pasha.tatashin@soleen.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=alex.sierra@amd.com \
--cc=alexander.h.duyck@linux.intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=david@redhat.com \
--cc=glider@google.com \
--cc=hughd@google.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=naoya.horiguchi@nec.com \
--cc=pavel.tatashin@microsoft.com \
--cc=surenb@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox