From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9282C64996 for ; Thu, 15 Jul 2021 18:22:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 32A94613D0 for ; Thu, 15 Jul 2021 18:22:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32A94613D0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4F4E28D00F4; Thu, 15 Jul 2021 14:22:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A5148D00EC; Thu, 15 Jul 2021 14:22:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 344EE8D00F4; Thu, 15 Jul 2021 14:22:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0201.hostedemail.com [216.40.44.201]) by kanga.kvack.org (Postfix) with ESMTP id 12FD78D00EC for ; Thu, 15 Jul 2021 14:22:00 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E23298245571 for ; Thu, 15 Jul 2021 18:21:58 +0000 (UTC) X-FDA: 78365641116.25.543968B Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by imf23.hostedemail.com (Postfix) with ESMTP id AB41490000BE for ; Thu, 15 Jul 2021 18:21:58 +0000 (UTC) Received: by mail-ej1-f50.google.com with SMTP id dt7so10801107ejc.12 for ; Thu, 15 Jul 2021 11:21:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=a64fucJ3nradLqS8b0xWylaDujzNDAEVUEg6XMLQFh4=; b=oGH/EaFLiAckIljXb9GhTC074m/Bzr0mO99DSaKBORzBZFLFBYKy2BliXNavS0u6La deOvQrRK5tkJf+6NTJlln66+wnNcuKrxrVAodVFuhhIIsVm7aXOAJScpcqwySp61DCz5 5CYoJ8Jo4eEjWkZFHAjmHt4tF/1FfU9Wr4jLoNDz8FUy3twADpH4N1BfFdDKE+6sKLSO WveCBYvueMge/KVLiziNUAfZq0E5LHT3DYZ3AK0U3CCBaiE6bRK5I6rM8580AAOaXraY oNsPEcnyA2zSvUfs/JwkIz37zusaRh8N9SbLr0E8mVtysJuQyWoZDZAFxWCoJUmsQo+v 6pYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=a64fucJ3nradLqS8b0xWylaDujzNDAEVUEg6XMLQFh4=; b=Lw2cNv4Bo2lODS3fN6RtCK11tFvV5su7I2KVWzqHQdPKmTcPAp6cCE73KncA7Kr5u9 1V2T/P8mLJMla87lwuhlNNvFn2PKMbV7Pnn7l+edwPzofryt92OTunRasFRR/gk6M3BD JVwS5+qXhMovcE7BRYhjf3IAKPe1pTtb1rG3PYnzwQj5kakMFAE6nN5TNQ/y8oBn7G+1 UyaVMJpzMtXU29mRwQk32jVB2UZ6fHjwrOWmHvkRP7T//qw5GVul9YaK+N/NQ+/Rw4f6 SW9PuLjHvNLMYxXAz0OrbL5G9RkX+PIDELdBH5brRLxkzELA+JNddxJt2jNXGn5xHYFq GAZg== X-Gm-Message-State: AOAM53363UhH420avZf9KXg9tJedmyx+LnqgxlRN87NIE6DSDZzstT3t J+RhSw7tPSrWrVnudRj9fqCb92yN45PfH2t9Ygi7LA== X-Google-Smtp-Source: ABdhPJwUWWrVhb+RuCQTmMau2LEvFNXiuDituncPfCEBDqHpnmdXtiGSHtOykRFTgPSvB33znKqlBmD0mVkN4GchgsY= X-Received: by 2002:a17:906:fb90:: with SMTP id lr16mr6978465ejb.541.1626373317450; Thu, 15 Jul 2021 11:21:57 -0700 (PDT) MIME-Version: 1.0 References: <343394260f599d940cacc37f1dcc0309239ae220.1626371112.git.zhansayabagdaulet@gmail.com> In-Reply-To: From: Pavel Tatashin Date: Thu, 15 Jul 2021 14:21:21 -0400 Message-ID: Subject: Re: [PATCH 1/2] mm: KSM: fix ksm_run data type To: Matthew Wilcox Cc: Zhansaya Bagdauletkyzy , Andrew Morton , Tyler Hicks , linux-mm , LKML Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b="oGH/EaFL"; spf=pass (imf23.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=none X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: AB41490000BE X-Stat-Signature: qe3un5t7xim5ktgs5ptr47mofptfcq6z X-HE-Tag: 1626373318-981957 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 15, 2021 at 2:18 PM Matthew Wilcox wrote: > > On Fri, Jul 16, 2021 at 12:01:01AM +0600, Zhansaya Bagdauletkyzy wrote: > > +++ b/mm/ksm.c > > @@ -289,7 +289,7 @@ static int ksm_nr_node_ids = 1; > > #define KSM_RUN_MERGE 1 > > #define KSM_RUN_UNMERGE 2 > > #define KSM_RUN_OFFLINE 4 > > -static unsigned long ksm_run = KSM_RUN_STOP; > > +static unsigned int ksm_run = KSM_RUN_STOP; > > Should this be an enum instead? I think "unsigned int" is OK here, as it is exposed as uint to users: Documentation/ABI/testing/sysfs-kernel-mm-ksm /sys/kernel/mm/ksm/run run: write 0 to disable ksm, read 0 while ksm is disabled. - write 1 to run ksm, read 1 while ksm is running. - write 2 to disable ksm and unmerge all its pages. Pasha