From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6DFCC07CA9 for ; Tue, 28 Nov 2023 23:00:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 57D8E8D000A; Tue, 28 Nov 2023 18:00:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 52E118D0001; Tue, 28 Nov 2023 18:00:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F6768D000A; Tue, 28 Nov 2023 18:00:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 312A48D0001 for ; Tue, 28 Nov 2023 18:00:53 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E81F5C03A0 for ; Tue, 28 Nov 2023 23:00:52 +0000 (UTC) X-FDA: 81508884744.04.1F7D29F Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) by imf14.hostedemail.com (Postfix) with ESMTP id E2949100015 for ; Tue, 28 Nov 2023 23:00:50 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=b9S18z01; dmarc=none; spf=pass (imf14.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701212450; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i5qTeYLca2e2he2/h7lciNlkt/VVLJwBuHOteswziYE=; b=kX2/n2v0Je85p6UptjVuo5UlJqSqdH5QyCVAigaxoBsyp7LINzQqUDrXD2EUz+4aPaxcny oUOwN684ljEcQdRSRl5aPSDackg7AqJ5UPea5lvjqVnX3AQKoPZG68pZFpzMhJmJAxmwfL 9fyz8WwvFbfTP3q9XrTlmtp+jGOzsWw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=b9S18z01; dmarc=none; spf=pass (imf14.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701212450; a=rsa-sha256; cv=none; b=vQAJz30ccEsua7B0Ut0j2vWfU7iBXB6b1Dxy+hpo2W/lI6GZJEGR5Ey3JNxPJNoFFlwPM4 WbN27OfH1FZaO75ncaLhlVN5QBcAcdV1lRfQBR4ITLxAVkA5k/EADiFUcdsDSX5V7q/UiW tQDGBKEebb0llxsuBOuvkBR/afNSUX0= Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-41cd4cc515fso33926101cf.1 for ; Tue, 28 Nov 2023 15:00:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1701212450; x=1701817250; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=i5qTeYLca2e2he2/h7lciNlkt/VVLJwBuHOteswziYE=; b=b9S18z01aLtorq16SaUjtHhAUZrxO6LtPU87WjAkiPdDf9sGecFmHRd6aolL9/+7/W NYOtjvp5B7BY/ymP1av2gDMzWBI68nhdbbq8+MGpnLAPScunHXBV9J/UcNAyic2/MHoq 9Y/vcTN6L095TEO0amEYxq1NjSMQufEdOubpNPT0nJ9VjwCniWVOOWQMN/59o0seetqQ v0vSpowQIBLIH3SPrvGdPJ8uGHosX1c0JUZFu8fqls9CEz9+JM6jxWtj1t3Mkq3SU6dU kb9r5ikWTlRUYkkCIafMc8mMRYVB0T0k3BhvKjoaRKr20EuJJC4uInk3dKw6fF9rPaEQ pyiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701212450; x=1701817250; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i5qTeYLca2e2he2/h7lciNlkt/VVLJwBuHOteswziYE=; b=A2KUOSUJEELrfoz2ianVbyRQkBFWLaVCGhZfj9ptj2+N+ObkDTnVZSkFjLcEObeqyM VTM4fbiH/+CsWKRM3X52VV4weCt+WIP5IhGl/va2Ki59rW7VqhHq3UlpTWPxkgUGj0b5 wVN1qY4JG/6lbjYVJlicQD1WjHonKnkxa9ncrw2Wn3SzH9xkxLlQCznkOYexFuKHFDT5 hMpNT+uYmY8QpbaWtawDYszTmql7JU4RyfQ9es7KMC/3tW6c9Vl2JGBRWbDc4aqwtMoj MRyvn3k6Fg+3Y86JQRiUOQSZf/M+O9U+yR8xx62ABwsUxHr5y6uNdt9ww+SDhdnh/l/Y IyIw== X-Gm-Message-State: AOJu0YyT8MC5fUDDRx5Ew72br1MNBS3C/XKlZ8O32zErAD2p4x/xQ8di +tVxHSXEke9mAspz4xgk6INHrIIgTMoXlmoXCZFbZA== X-Google-Smtp-Source: AGHT+IEPyMHIunggDlyG5iB0FMPH+mJhboCaVsS2S6rrqwyBMR/AatdaxBsSOQb0215dRYgwc4yOM/dAMVD+X08yuok= X-Received: by 2002:a05:622a:34c:b0:41e:213d:3c8e with SMTP id r12-20020a05622a034c00b0041e213d3c8emr18601609qtw.32.1701212449795; Tue, 28 Nov 2023 15:00:49 -0800 (PST) MIME-Version: 1.0 References: <20231128204938.1453583-1-pasha.tatashin@soleen.com> <20231128204938.1453583-9-pasha.tatashin@soleen.com> <1c6156de-c6c7-43a7-8c34-8239abee3978@arm.com> In-Reply-To: <1c6156de-c6c7-43a7-8c34-8239abee3978@arm.com> From: Pasha Tatashin Date: Tue, 28 Nov 2023 18:00:13 -0500 Message-ID: Subject: Re: [PATCH 08/16] iommu/fsl: use page allocation function provided by iommu-pages.h To: Robin Murphy Cc: akpm@linux-foundation.org, alex.williamson@redhat.com, alim.akhtar@samsung.com, alyssa@rosenzweig.io, asahi@lists.linux.dev, baolu.lu@linux.intel.com, bhelgaas@google.com, cgroups@vger.kernel.org, corbet@lwn.net, david@redhat.com, dwmw2@infradead.org, hannes@cmpxchg.org, heiko@sntech.de, iommu@lists.linux.dev, jasowang@redhat.com, jernej.skrabec@gmail.com, jgg@ziepe.ca, jonathanh@nvidia.com, joro@8bytes.org, kevin.tian@intel.com, krzysztof.kozlowski@linaro.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, lizefan.x@bytedance.com, marcan@marcan.st, mhiramat@kernel.org, mst@redhat.com, m.szyprowski@samsung.com, netdev@vger.kernel.org, paulmck@kernel.org, rdunlap@infradead.org, samuel@sholland.org, suravee.suthikulpanit@amd.com, sven@svenpeter.dev, thierry.reding@gmail.com, tj@kernel.org, tomas.mudrunka@gmail.com, vdumpa@nvidia.com, virtualization@lists.linux.dev, wens@csie.org, will@kernel.org, yu-cheng.yu@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: pc3tkusixfa9w4j9p9ndytkfi1kztpd5 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E2949100015 X-HE-Tag: 1701212450-549256 X-HE-Meta: U2FsdGVkX19WzR9ZBwXWSdiRlC5wNws7T6kToSPs8Vc6aI/wm39DNv4jTMx/fLoyvYUJhtUeInZfOwARUedJZEaKAmOYXrB6pKrTE2hYbyEQY9Ja9qKcWxHlnWiNtRUFTGxcihu6tbr4SUYA0uD8niDXG3YuSrfokWJ7J5HJMrxbUIxyGcVNYONDoqb5tRTPbQR5akH+abe+MMVCsRVCkpBUE/aoaW/EMeqzCmOBIF/LpctcVRWKUEIh10W8eLmrRpsGf6Gdchqgz6GjtQioYny6GuTK5YSA/GCaCBtbT4xNjAI+WbtoD7BECFZcA2SU8T2dLewxH6O22/OenOrDck8oD9kqf8JVbCcmBw4R0gHin5MwidfJkwoveI11qVBW0ypB12ZtaZjNISoNprgQePUC38TMx9quc4T7AKVVZIZAtbON09I7SuOR7wwkQ9Z4Av/9lPJbTqDPzX++3pJizxQIGu3ZD2H5vev5sTw9wJjS9RzUsW1+hrW1zEt3ngx7UHtrppYSMP9nnyslluC5MzEfbrZliB4LzTB0NxVYaQhSonwKvaaFDHlFKcgZwn2FO7foQUGZpyAjuBmXF1r0j1KPVnwyERzb1euyhkRQZ2uXYx9w3Gl2hBl4gkVnmyBrTCFQZLZZfuTP+llTPY5JdOHGSE9lQwBg8tRn9XpnHPV5wRw8foqszVZXM9BENpuWf+y9El/Z8doUnzIHMzUPGDEx6QyGII0WSnbhwEexweN30O6pLJHGxPA8scUZluSA3KHM/97EIT0vi75izh/26ZfPNN3b2EJMuH9laHnpkd8BM8v4nEgKnCjP13PfaWwZQ8c408JZghc6/1mQF4q6ROG2E4JX0n3UD2dhLTcaCN8BLHttzDBrFSnTvmTqL4eNt2FHLJruP0IHVbDnpe/OIUawfW83PQYaQhkJqGV/GtfQQdiAKcy/bmSC/4hnvB2fwMcThi2FfKIQbN2dk/K hEQ/mZg/ 6Qx3Dc6JPN1nVHknJnVq7OFxn3/vts5JHPKGwtq/Za8goi/cOtCyRh1FwvZmhVVb8PyDtvSq82gOjPK4368qY+f3VWgEc//dMkotvMV/U0dW7MjBuhiOxBZ3ocvdwZG7oKLN4oUjTQ8kazFoMbqDE5+586A9lja56QPfAoElQO6Hnf8iR+7iHwkZI8VArqURk+apFZJW+EkXTdbBU5QQ+vIZ5xhfIZ9l48pWWUrvDer4NMLVtbdo1hevuYJTsWWms7g1GQI1BOmUJSeItT5+JRt4HBlIuA5Kb8CtibP1G/XmMvatRcbVOCrs1aGzzknV+Y7JSUiXy6hAqL0cRmjeamPiIMBDisCh1+lXx2c4P+R2LWmlt7w01dEP5KUTacMuG9o6E5Wn3aUz+01s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 28, 2023 at 5:53=E2=80=AFPM Robin Murphy = wrote: > > On 2023-11-28 8:49 pm, Pasha Tatashin wrote: > > Convert iommu/fsl_pamu.c to use the new page allocation functions > > provided in iommu-pages.h. > > Again, this is not a pagetable. This thing doesn't even *have* pagetables= . > > Similar to patches #1 and #2 where you're lumping in configuration > tables which belong to the IOMMU driver itself, as opposed to pagetables > which effectively belong to an IOMMU domain's user. But then there are > still drivers where you're *not* accounting similar configuration > structures, so I really struggle to see how this metric is useful when > it's so completely inconsistent in what it's counting :/ The whole IOMMU subsystem allocates a significant amount of kernel locked memory that we want to at least observe. The new field in vmstat does just that: it reports ALL buddy allocator memory that IOMMU allocates. However, for accounting purposes, I agree, we need to do better, and separate at least iommu pagetables from the rest. We can separate the metric into two: iommu pagetable only iommu everything or into three: iommu pagetable only iommu dma iommu everything What do you think? Pasha > > Thanks, > Robin. > > > Signed-off-by: Pasha Tatashin > > --- > > drivers/iommu/fsl_pamu.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/iommu/fsl_pamu.c b/drivers/iommu/fsl_pamu.c > > index f37d3b044131..7bfb49940f0c 100644 > > --- a/drivers/iommu/fsl_pamu.c > > +++ b/drivers/iommu/fsl_pamu.c > > @@ -16,6 +16,7 @@ > > #include > > > > #include > > +#include "iommu-pages.h" > > > > /* define indexes for each operation mapping scenario */ > > #define OMI_QMAN 0x00 > > @@ -828,7 +829,7 @@ static int fsl_pamu_probe(struct platform_device *p= dev) > > (PAGE_SIZE << get_order(OMT_SIZE)); > > order =3D get_order(mem_size); > > > > - p =3D alloc_pages(GFP_KERNEL | __GFP_ZERO, order); > > + p =3D __iommu_alloc_pages(GFP_KERNEL, order); > > if (!p) { > > dev_err(dev, "unable to allocate PAACT/SPAACT/OMT block\n= "); > > ret =3D -ENOMEM; > > @@ -916,7 +917,7 @@ static int fsl_pamu_probe(struct platform_device *p= dev) > > iounmap(guts_regs); > > > > if (ppaact) > > - free_pages((unsigned long)ppaact, order); > > + iommu_free_pages(ppaact, order); > > > > ppaact =3D NULL; > >