From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2158C433EF for ; Thu, 9 Dec 2021 01:26:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 240126B0071; Wed, 8 Dec 2021 20:26:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1EF6B6B0073; Wed, 8 Dec 2021 20:26:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DF3B6B0074; Wed, 8 Dec 2021 20:26:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0157.hostedemail.com [216.40.44.157]) by kanga.kvack.org (Postfix) with ESMTP id F2FB76B0071 for ; Wed, 8 Dec 2021 20:26:10 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id BC2CC18522C58 for ; Thu, 9 Dec 2021 01:26:00 +0000 (UTC) X-FDA: 78896514480.28.44C8902 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by imf14.hostedemail.com (Postfix) with ESMTP id 6821C100002 for ; Thu, 9 Dec 2021 01:25:59 +0000 (UTC) Received: by mail-ed1-f51.google.com with SMTP id w1so14386236edc.6 for ; Wed, 08 Dec 2021 17:26:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=w+fuNXLJ3fQkPjB7+VT61GrrAWzjVIzpFysNrMVt/Cc=; b=g3rfkKvF6kzXSfsCgWvrU21T/Ck0C4i9MxJJBdmYZzdAAWjdS+EbZSKCmvH2hmgLi2 BBjRf0i4fVJwoLJGDs0DIh2LMKKm14ht/n0drXR1DcaqyOXwnX+fapyn97W9fsD7R4kY QhdIfS8ujS9yuv0ETgNo1Eq7RHzj5HkMwtQWKVb1CiTEtPQMIpw0qxPN+YSFQebSodj0 pdplRkcyKOqp325cl+kJ9JTgm1PfmghTy6UTHhmvqeq7seXMeii+b6cYwJn5TfmdGK12 LNf6JhV1d8etfWFgdWzCPZHMFfgbLR0G4piURqkIJiiuJpPLho1I0turb+fO8DNpwO6q aN+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=w+fuNXLJ3fQkPjB7+VT61GrrAWzjVIzpFysNrMVt/Cc=; b=4PqMWB61CNKuCwmVtqXJyUAXQUv2VOJQkxXumO4qzayipc54RvJl3b2klpMpapf6pP H4mjN0EmPE9tJA4/2lsHZr2UQSE3EleZWHOMph4CBgiAA+6A/jP4qUBStChn5bbKLA7g 6liNMx6OqvR3pBpZaq59df9PxkPD4N8y8OnkpkgcZ2IVY73PakhpS9EA9GAsTNaIsLYc TcIM4mvKPjF4ucd2afFGjX2DWYAi2TDF+bM14jWaKudzkyibOqSEVLQuV5MO2RD367z2 hBR6UvjVjO1jnacALKyeGRAbiEZppMvE4HPBpPnRrbjMIOvGh33AjwvNFkPbq8A2Dgac Ds+Q== X-Gm-Message-State: AOAM531CtxsIpMQt6CI2kgqdoPZxoCwbswPh4Vz+L4b3Y5/1qX2r1HDO s+5SjZbl6mMHztZ+TOK+QRm+NjAmLfxTMo3mQbBvYQ== X-Google-Smtp-Source: ABdhPJz8C2Y7erRJC6NmYq7ap+UoZBDEPHFWBCGse7K+mEgnOYzI2F+CDkmK3hjtJMdGob6dVFc0G22KDL74Lels1tM= X-Received: by 2002:a17:907:608f:: with SMTP id ht15mr11470872ejc.300.1639013159172; Wed, 08 Dec 2021 17:25:59 -0800 (PST) MIME-Version: 1.0 References: <20211208203544.2297121-1-pasha.tatashin@soleen.com> <20211208203544.2297121-2-pasha.tatashin@soleen.com> In-Reply-To: From: Pasha Tatashin Date: Wed, 8 Dec 2021 20:25:22 -0500 Message-ID: Subject: Re: [PATCH 01/10] mm: page_ref_add_unless() does not trace 'u' argument To: Matthew Wilcox Cc: LKML , linux-mm , linux-m68k@lists.linux-m68k.org, Anshuman Khandual , Andrew Morton , william.kucharski@oracle.com, Mike Kravetz , Vlastimil Babka , Geert Uytterhoeven , schmitzmic@gmail.com, Steven Rostedt , Ingo Molnar , Johannes Weiner , Roman Gushchin , Muchun Song , weixugc@google.com, Greg Thelen , David Rientjes , Paul Turner Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6821C100002 X-Stat-Signature: 4ryr17tkzag36z1zybghyzi6qh9c7k6d Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=g3rfkKvF; spf=pass (imf14.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.208.51 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=none X-HE-Tag: 1639013159-248033 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 8, 2021 at 3:55 PM Matthew Wilcox wrote: > > On Wed, Dec 08, 2021 at 08:35:35PM +0000, Pasha Tatashin wrote: > > In other page_ref_* functions all arguments and returns are traced, but > > in page_ref_add_unless the 'u' argument which stands for unless boolean > > is not traced. However, what is more confusing is that in the tracing > > routine: > > __page_ref_mod_unless(struct page *page, int v, int u); > > > > The 'u' argument present, but instead a return value is passed into > > this argument. > > > > Add a new template specific for page_ref_add_unless(), and trace all > > arguments and the return value. > > The special casing of '1' for device pages is going away, so NAK > to this user-visible change. I can drop this patch, as it really intended to fix existing oddities and missing info. However, I do not really understand your NAK reason. Can you please explain about the special casing of "1" for device pages? Pasha