From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C0CCC4332F for ; Thu, 2 Nov 2023 15:11:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70CBB80031; Thu, 2 Nov 2023 11:11:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 695978D000F; Thu, 2 Nov 2023 11:11:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 50F9280031; Thu, 2 Nov 2023 11:11:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3FDEA8D000F for ; Thu, 2 Nov 2023 11:11:43 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0A1A34100B for ; Thu, 2 Nov 2023 15:11:43 +0000 (UTC) X-FDA: 81413353686.11.A063A31 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by imf07.hostedemail.com (Postfix) with ESMTP id 3609840007 for ; Thu, 2 Nov 2023 15:11:40 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=GajrfKoI; dmarc=none; spf=pass (imf07.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698937901; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cAw9sv/T68KQfbkbViSCXGIX3HBnIacj63UFeeK2mDo=; b=QIIk9SV7l4JiwyzxBl617hFBP2k5iN7yATdppvyfsa5SpXgOp9B39g7M9ESL2v3GZXBLAK 7bvUA12dkupPT12f4dg0UdZNRc8Lw19Mc1ntreeWV8xFRCvckd2rMVHGojxeZviwWbyP3D L4HmNMZCPFMwmhYMjD3DO1OMqaPfjTQ= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=GajrfKoI; dmarc=none; spf=pass (imf07.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698937901; a=rsa-sha256; cv=none; b=WAKK4v3gHHLCjOYJmmpZ3ADF8IPU4rLlU0Ni5KLpTgN1QF2VL8S3url/NlIXPHMswJhmCy P5yyFLznXooSWw+nLbmqY+onmfDrA3jd67omYQhj0xp1egOXhMTuPKdr4LGK7/qyHx+k9H 5Q97MPJ+u48jug3l+AU4q0CRkTU+Z8o= Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-41cda69486eso5631721cf.3 for ; Thu, 02 Nov 2023 08:11:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1698937900; x=1699542700; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=cAw9sv/T68KQfbkbViSCXGIX3HBnIacj63UFeeK2mDo=; b=GajrfKoICCIgUTxAYgEgoFZsbXXbfn8FuyO2zb9IvzF6th9EABYoriy3UV5nUPX5sL 9Vzx8N0HNvb9wK36SNnqjhNyhOyHGw3S2PWuvOlRKjbwK5xDaebtIQchYMtlFjH+ZSG6 taYcpNeQcYnpTy1Dd2qdEpTqteI6BLMtzOyrYsx7GtMiqMHV64mcARdyuOcDqGhEf8P8 xawxLNdFOmBuVXvE5qrrtE/UwYdZQuodl7wvoWVOkUGRf4207Ozmu79SOZ1kvR68N3E5 cpgzZUmuvT9Ur0EqeJimG0tKxMPyrFKkw1ByQLUZ150XaUAC8agFdF3KdDeD4PS3Foga b8+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698937900; x=1699542700; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cAw9sv/T68KQfbkbViSCXGIX3HBnIacj63UFeeK2mDo=; b=iRwthh2c96kRoqRv3I6qPvs0+UwI4Js0AyBRACTn1GR+wyEBfDCSViCkggTHV0w1R6 zkQl7IJHUMLKKvd0Eu7qxyA/rpq0CSSpcNcIA3g0DsHI/TnvxAMXfeqmolZb2xCBq8ip Petp4AIey487rbS1oC7blK8Wwc3bNGjFxBOUdFjhmEG04IePa6kgc7HUwSi1nwqFkZv0 QoqjrQfuuz3JycAoS4OuMFeaCVDTW1XerWh1JLeNOr7PS4Ti4v9ySnzkbu80fCpPxfa5 B8CPMvvo0b1tsGbmYxm9ntaDf9jvvOzKqk1WeT8d9fH2aRyQt0aHpWdtif1HIqRPWALu 6iYQ== X-Gm-Message-State: AOJu0YymuxFiR3JvwgIosJPqWRwPpE1fQrFY0SSnCKLn3G1vnZxgUpjw 2SBuzlRf+NVXGx8MdfWo7VG/Mdsf7SWtmNQL7z/Xyg== X-Google-Smtp-Source: AGHT+IHcYzPWiAFmBoXSyJoDI64wpvja1WI+ECLeWeUah15PFIwLSppZZtojijKSQdF7suJdY1SYkg/gdOmnHPwYHJk= X-Received: by 2002:ac8:5f06:0:b0:41e:2112:611f with SMTP id x6-20020ac85f06000000b0041e2112611fmr20358911qta.39.1698937900089; Thu, 02 Nov 2023 08:11:40 -0700 (PDT) MIME-Version: 1.0 References: <20231101230816.1459373-1-souravpanda@google.com> <20231101230816.1459373-2-souravpanda@google.com> <2023110205-enquirer-sponge-4f35@gregkh> <2023110216-labrador-neurosis-1e6e@gregkh> In-Reply-To: <2023110216-labrador-neurosis-1e6e@gregkh> From: Pasha Tatashin Date: Thu, 2 Nov 2023 11:11:03 -0400 Message-ID: Subject: Re: [PATCH v5 1/1] mm: report per-page metadata information To: Greg KH Cc: Sourav Panda , corbet@lwn.net, rafael@kernel.org, akpm@linux-foundation.org, mike.kravetz@oracle.com, muchun.song@linux.dev, rppt@kernel.org, david@redhat.com, rdunlap@infradead.org, chenlinxuan@uniontech.com, yang.yang29@zte.com.cn, tomas.mudrunka@gmail.com, bhelgaas@google.com, ivan@cloudflare.com, yosryahmed@google.com, hannes@cmpxchg.org, shakeelb@google.com, kirill.shutemov@linux.intel.com, wangkefeng.wang@huawei.com, adobriyan@gmail.com, vbabka@suse.cz, Liam.Howlett@oracle.com, surenb@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, willy@infradead.org, weixugc@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: mc1syjtunyefdi6ysaqq7kpgqbbarntz X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3609840007 X-HE-Tag: 1698937900-670713 X-HE-Meta: U2FsdGVkX188I33jZ8roDcU0nPyV/CHejw3eZCQy/yzjVAi4PCoLp8cG9hTeMK7nPIK2eFhWerqBUC2qmLazeyr/HOx+dRmCQ+iUhpaOh5EbDBzGZlV2fweiE2aR8mQCPm+LIdm6SjyraNb6ml8SUdwL9CAOW/A25SUMUmh4+3vjm2o9TGCZ7J41IfPPAf61l5+qa3CJO438DeOb9U7fiyQZ+wlljl7BxO742C/sCApFLbMOvekO1xY8cdfBiETocWVeVJR9nGPyrCplizW4C8/DJ7aOLn+qeeo4xekSHU9lsi3t9PslkaBumMWScVD3+H0Kyzm7Ys7PTo7anorJ/U3TXKAfXapow/7jG6kP3vTy+LV9dBa2Cbo/iTaXQ7r99mIGdnRnNVSInTl8jRbmNkd4gEoMUIlY8iwVoIeAG/Zg5DW1gG6+Tf9QkmjtmK6qiCnZ+xjUi6awmwlp3KN6Zj8IpWviAaKS/0MHutUJXD7+yHW88xM89sMlsvM1Bo9cRol7aGLU4mTd3AmxeiFU2dcxfQFNHauIcKMB18fuLG6MpAbOKpt4J/fGqlovUq18xVEE6Txjh9vUfft4k9Q6zgIvD1Vm1GXU7Vw7zG5aBU+oMrqchRCMU2V5BcC5tqdG0Gy64kulr+uY4n6o/aZUy2hr1Ve0Z1gILqkHNyZ5UOilsQHgOz5QP+AbsCCwVGYFoo9ZJt/vc4FZZrH6gDkwlpglQlGRzG/Hb7Rv+b/ygemB/wTBfKVJKGeOrgtZiEWOFN4pPxQrYOmaX0v2Sv+IA6Om81Dtbt0xyYclCUWHfNqJ0K8y/NsfKTuBiY9Gz1cUHk4xqONDYzR4uV0GvE2IZfgbf0QlBTeHRYVI8qZagerQQDAB3R8rohvGGlO8Jx926CeG2q11wgJhjO5SypRj6D96+2unLgVYLLygygIQbZUg/mzI1BPsT9M0Cj28nP9dCxBA9ELQrElAFSrV2SH iWidKBw4 rzXXPeliblTM3OTETT7/XqXluwSB+aWRV2Sr9fOR7wMWOvgWG4bf8757nN7YUM4W5v+FYWDURPqY6K8SnF7HITCjLWa9SMk5AsiLvDn4Z5g6/uDwxReRNHr5yShizZdZL5XEJEUTDpgbR1jOVmX1Ch6xX7nIE7u18i4g4TpnWnQQuqKjNYKQBY1WGX0zOdo3qI4PdlsevtBcEtrdhzd6/WiTG7F/Ox402XKB36pwkh5K++7mtqA+GqMiQSDxjyIx+1n+hHeXHrNXVvc5oX98sFZBtaVpceoAxLFw+K277k04QWGvZNYJoGZSfhvXXbzzLtY4CPzEki1XjRRl1QJnV0n2Arg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 2, 2023 at 10:29=E2=80=AFAM Greg KH wrote: > > On Thu, Nov 02, 2023 at 10:24:04AM -0400, Pasha Tatashin wrote: > > On Thu, Nov 2, 2023 at 1:42=E2=80=AFAM Greg KH wrote: > > > > > > On Wed, Nov 01, 2023 at 04:08:16PM -0700, Sourav Panda wrote: > > > > Adds a new per-node PageMetadata field to > > > > /sys/devices/system/node/nodeN/meminfo > > > > > > No, this file is already an abuse of sysfs and we need to get rid of = it > > > (it has multiple values in one file.) Please do not add to the > > > nightmare by adding new values. > > > > Hi Greg, > > > > Today, nodeN/meminfo is a counterpart of /proc/meminfo, they contain > > almost identical fields, but show node-wide and system-wide views. > > And that is wrong, and again, an abuse of sysfs, please do not continue > to add to it, that will only cause problems. > > > Since per-page metadata is added into /proc/meminfo, it is logical to > > add into nodeN/meminfo, some nodes can have more or less struct page > > data based on size of the node, and also the way memory is configured, > > such as use of vmemamp optimization etc, therefore this information is > > useful to users. > > > > I am not aware of any example of where a system-wide field from > > /proc/meminfo is represented as a separate sysfs file under node0/. If > > nodeN/meminfo is ever broken down into separate files it will affect > > all the fields in it the same way with or without per-page metadata > > All of the fields should be individual files, please start adding them > if you want to add new items, I do not want to see additional abuse here Sounds good, in our next patch version we will create a new file under nodeN/ to contain per-page metadata overhead, and add an ABI doc file for it. Thanks, Pasha