From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FE96C433F5 for ; Wed, 20 Apr 2022 16:44:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C60226B0071; Wed, 20 Apr 2022 12:44:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C0F486B0073; Wed, 20 Apr 2022 12:44:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AAF506B0074; Wed, 20 Apr 2022 12:44:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0210.hostedemail.com [216.40.44.210]) by kanga.kvack.org (Postfix) with ESMTP id 9C5F86B0071 for ; Wed, 20 Apr 2022 12:44:45 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 51A881828D81B for ; Wed, 20 Apr 2022 16:44:45 +0000 (UTC) X-FDA: 79377831330.31.20F48DF Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by imf22.hostedemail.com (Postfix) with ESMTP id 66E8EC000F for ; Wed, 20 Apr 2022 16:44:44 +0000 (UTC) Received: by mail-ej1-f45.google.com with SMTP id ks6so4793958ejb.1 for ; Wed, 20 Apr 2022 09:44:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=AfxWSlxIEICGSyTo5UTwMPZe6Q55PvAA0DKxMflvlU4=; b=nC9D+qQY6zO1b5+6ctalBsBld2Gklo1raloLX7LprQ0sz5ZMyJeK4iWk33WJIMlBys sWrGm3frGJHX0al+4QCmYIKE7/xB/nf2dHq34Kz/P8+KRaTi2tfXM3zPx31zCAO/b1Rx KsZ2TB/vy3W4s+buZh6s672JbmkLoKKCcRCzSZc7IaxWMIbQ8/G6krCr2AeARLmX0PBe SYuPncrqbw/hmoPenwsyTTApQEjuiClFf78tTK4ef20HmQPibh2pVeKqEKo9Ii8LvUcM aj/x9FkzcoYXASEDuyIQkrrZOcqOIfXVN9KydRiHmMBD6cNygUpxKXPQR8YkW0vJZwzS B+kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=AfxWSlxIEICGSyTo5UTwMPZe6Q55PvAA0DKxMflvlU4=; b=N487ZbBourOeA7P6Cdn9cbmnl/SYZSgNBxYG19zpmnHWZfSb6ejjCWCqdp0jwDve0I yAoUIefwiFfGxIem/XFaeW8ltPEzR/UWnsHj1p10P3b+lbywRum8D/3TsORZm5K7UTyL aJPXgv5Mc8U68oZHN1M+NDBsCRpPM9qsSugejeljWCLU5rnxp3f4Kz9m6Ek3IgQfYTXG 4WWL7daTnoXF+rIvEvurkFTQ4vPRNmXpU3Jc1Hk8RdUzuZvrmD9Tmoe5TU1P4+ZEA9Ae Sn/h06q3IOoH4rYxMDpQzapxcyrR94CPCXswv01Rgf34uyWeO6BJHUHk048lrp569kN5 2vbg== X-Gm-Message-State: AOAM533RTtfVurOSRwCSD+2PcECbvxMb+ENAZj4W1B7C2Qj6xm4nvEg4 fdqHFujI2Un1ZZrW6G3mNQvTjISaaNco+K034wGZeg== X-Google-Smtp-Source: ABdhPJyZtJ2OiQqRMqkArjaqQ1FeKnI5zVUYHqY6VjiqjAqVr53rH54QfeTBwC+gpwXOjHnNJhHpdYKW5AxpfxLyFmo= X-Received: by 2002:a17:907:1c8a:b0:6e9:2a0d:d7b7 with SMTP id nb10-20020a1709071c8a00b006e92a0dd7b7mr19095476ejc.572.1650473083179; Wed, 20 Apr 2022 09:44:43 -0700 (PDT) MIME-Version: 1.0 References: <20220418034444.520928-1-tongtiangen@huawei.com> <20220418034444.520928-2-tongtiangen@huawei.com> <1671baf7-046e-7c52-183f-fd654125fd67@arm.com> In-Reply-To: From: Pasha Tatashin Date: Wed, 20 Apr 2022 12:44:07 -0400 Message-ID: Subject: Re: [PATCH -next v4 1/4] mm: page_table_check: move pxx_user_accessible_page into x86 To: Tong Tiangen Cc: Anshuman Khandual , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , Andrew Morton , Catalin Marinas , Will Deacon , Paul Walmsley , Palmer Dabbelt , Albert Ou , LKML , linux-mm , Linux ARM , linux-riscv@lists.infradead.org, Kefeng Wang , Guohanjun Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 66E8EC000F X-Stat-Signature: 31d6ne6qc44ikbd59jhmanggqq6jfs1a Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=nC9D+qQY; spf=pass (imf22.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=none X-HE-Tag: 1650473084-430700 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 20, 2022 at 2:45 AM Tong Tiangen wrote= : > > > > =E5=9C=A8 2022/4/19 17:29, Anshuman Khandual =E5=86=99=E9=81=93: > > > > > > On 4/18/22 09:14, Tong Tiangen wrote: > >> --- a/mm/page_table_check.c > >> +++ b/mm/page_table_check.c > >> @@ -10,6 +10,14 @@ > >> #undef pr_fmt > >> #define pr_fmt(fmt) "page_table_check: " fmt > >> > >> +#ifndef PMD_PAGE_SIZE > >> +#define PMD_PAGE_SIZE PMD_SIZE > >> +#endif > >> + > >> +#ifndef PUD_PAGE_SIZE > >> +#define PUD_PAGE_SIZE PUD_SIZE > >> +#endif > > > > Why cannot PMD_SIZE/PUD_SIZE be used on every platform instead ? What i= s the > > need for using PUD_PAGE_SIZE/PMD_PAGE_SIZE ? Are they different on x86 = ? > > . > > Hi, Pasha=EF=BC=9A > I checked the definitions of PMD_SIZE/PUD_SIZE and > PUD_PAGE_SIZE/PMD_PAGE_SIZE in x86 architecture and their use outside > the architecture(eg: in mm/, all used PMD_SIZE/PUD_SIZE), Would it be > better to use a unified PMD_SIZE/PUD_SIZE here? Hi Tong, Yes, it makes sense to use PMD_SIZE/PUD_SIZE instead of PUD_PAGE_SIZE/PMD_PAGE_SIZE in page_table_check to be inline with the rest of the mm/ Pasha > > Thanks, > Tong.