From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AFE2C4167B for ; Wed, 29 Nov 2023 22:00:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EDB1A6B03F0; Wed, 29 Nov 2023 17:00:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E8AFF6B03F1; Wed, 29 Nov 2023 17:00:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D53606B03F2; Wed, 29 Nov 2023 17:00:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C60926B03F0 for ; Wed, 29 Nov 2023 17:00:24 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7ECA28062B for ; Wed, 29 Nov 2023 22:00:24 +0000 (UTC) X-FDA: 81512361168.01.AE23EFF Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by imf11.hostedemail.com (Postfix) with ESMTP id 9AF8640004 for ; Wed, 29 Nov 2023 22:00:21 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=AhdmsoDH; dmarc=none; spf=pass (imf11.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701295221; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aiOfm5uGDMrP0UYnHwC5BRUcA0oU3b2DbcdcIFPiI/Q=; b=pYsvE62eUg10XGypE9KutWV/dlBNl29vjk7G8iXTwIIM9s7iMLplvWbrib9Qa5PxEhuJM5 mCS+vqerR1okTbo96SX//dkzidYgItn42YKi0x8dkfTBkxH2fbJoeI3j5LkO3NUz8QIdhG 2i1uq2ZproJJwpcU/BlVUP7QVYqjODQ= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=AhdmsoDH; dmarc=none; spf=pass (imf11.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701295221; a=rsa-sha256; cv=none; b=UtMIZJ0qvVYKa3naTVbNOeoUDvGvqlXObYsZdeLRXZXrevuoQaWjBQC9oKKBT32n0r1HBS zIAiohjh5t1uOI5yC1tJQ2tnXYzJgkVfL8HjKLOs/UN76RaVQBBnynWNUHYX8gqOwKDKL8 S2UmIzFPQd2G3YvrVn4wEbdA0kxBXQQ= Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-423dcd5d060so2417181cf.0 for ; Wed, 29 Nov 2023 14:00:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1701295220; x=1701900020; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=aiOfm5uGDMrP0UYnHwC5BRUcA0oU3b2DbcdcIFPiI/Q=; b=AhdmsoDHXnoEY1cRzy6ER46xbOYfDzp7aTdLm8ZKCL0bj9727i6q+MbQiyMw2eOOhB X+D44EYNI7IVg7XA7vQm979zRCjDchOoVZmRecLmrsBXeVOF1j9qG+iq1FRAAc4oQHqX 30deCBPYaC0QPblaFTOF03HBxAwkIxJxNvJDjfKkfEK5aQbNi6bFDKWaJakYCvJJmPPC Hf3WeScpSr4A06OkmoZ69bQzIHiwNBajIyRjum0ea01tGbjOwjnjMkMsF8dp9S65FGhm qDmVwM3l/IdUsv6cfIg2VhTQmzwgve2O/FZlQ3hxOJyvTkOIodexcGcJkoQaaoNu1QS5 D1Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701295220; x=1701900020; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aiOfm5uGDMrP0UYnHwC5BRUcA0oU3b2DbcdcIFPiI/Q=; b=FMwfOkmNbNgj8JzpRwYkM+HCEjbTgV/7dee6O3VrdMeMwbaf+LKzDpR5I+LY7wJFqu CvZw89McoGZnE8oFuYZgNhrTHWpF1lndiZAmwx5v30gQKlcjkTWCsFatPypYUvUpWQeN j6ObTxTCL1+37iEukr9mN9b1D/hVcdXcO5/UqvcWyj5llLqNYplQPuoWpFn+CmG9ctWx v8LHnenXbTDdLHoA2BeYnaYCoGtj75aifH+Xod6mVmEu8MTv7WOU63gUVm+fWLUb2wtg fLq2geXeRDXPeOKkKIWN4S+RXKqLD2mLrGBMYpitiTOYxgv1PdptP1oFS5vG8faqCqbS PpbQ== X-Gm-Message-State: AOJu0YybBTbWtVN6ZFlRiuHyXPxVxgm9VHS0PbaL/y6eHWU6+KrXLlz6 pyv7o6ZnKPfA4Ih+0yh5/lc8XpctT9PL0FJGxf8lWA== X-Google-Smtp-Source: AGHT+IGmE/x/Q9wBAAP4WSVeu6Pzwkh80gJNXkwIoavJV9VXufokUhNCLXMfXFExg6GRm7Q1Y/p8TrFXYkay1vjqtA4= X-Received: by 2002:ac8:5ac4:0:b0:41c:d62b:fb51 with SMTP id d4-20020ac85ac4000000b0041cd62bfb51mr39263562qtd.26.1701295220560; Wed, 29 Nov 2023 14:00:20 -0800 (PST) MIME-Version: 1.0 References: <20231128204938.1453583-1-pasha.tatashin@soleen.com> <20231128204938.1453583-10-pasha.tatashin@soleen.com> <20231128235254.GE1312390@ziepe.ca> In-Reply-To: <20231128235254.GE1312390@ziepe.ca> From: Pasha Tatashin Date: Wed, 29 Nov 2023 16:59:43 -0500 Message-ID: Subject: Re: [PATCH 09/16] iommu/iommufd: use page allocation function provided by iommu-pages.h To: Jason Gunthorpe Cc: akpm@linux-foundation.org, alex.williamson@redhat.com, alim.akhtar@samsung.com, alyssa@rosenzweig.io, asahi@lists.linux.dev, baolu.lu@linux.intel.com, bhelgaas@google.com, cgroups@vger.kernel.org, corbet@lwn.net, david@redhat.com, dwmw2@infradead.org, hannes@cmpxchg.org, heiko@sntech.de, iommu@lists.linux.dev, jasowang@redhat.com, jernej.skrabec@gmail.com, jonathanh@nvidia.com, joro@8bytes.org, kevin.tian@intel.com, krzysztof.kozlowski@linaro.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, lizefan.x@bytedance.com, marcan@marcan.st, mhiramat@kernel.org, mst@redhat.com, m.szyprowski@samsung.com, netdev@vger.kernel.org, paulmck@kernel.org, rdunlap@infradead.org, robin.murphy@arm.com, samuel@sholland.org, suravee.suthikulpanit@amd.com, sven@svenpeter.dev, thierry.reding@gmail.com, tj@kernel.org, tomas.mudrunka@gmail.com, vdumpa@nvidia.com, virtualization@lists.linux.dev, wens@csie.org, will@kernel.org, yu-cheng.yu@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 9AF8640004 X-Stat-Signature: ojc99wb71bop6f5qdm3ocftu81k6nqtm X-HE-Tag: 1701295221-913317 X-HE-Meta: U2FsdGVkX1/xxu6Qn69TVHR2yAbMxpX857dK9wTm3mjwcOn3A8wJSoACt9M3NwsXyRNXDMxGeXQ7eI0Jpf27zTUTin5r3ZF5H+Bgkb3Cr5yF0dXKYMhovZv+4xRxYbUOppg3MfTI34jODtB/0EtJBd4GFob2Xhaq6SSTnZxZGDx+Cxy8CN7jUJ787VoHPYSbRgLz/VG0gwtZlI5DvWcy4h1BsreimixBihIFE7dlCESBHMxB+JhscyCN4DPyOisrVEIwhwGc9uvI92YWCvjkq3PNvjQ7iQvBsbKdQEwqG7DfJL0F79P9V1sDmF8J61oAHLmKofUXjOOcTetKnE0ql4D8Wzs7fZBBdwjvEl103qdXHgEObT7J8oYiOqPSMvumRKynDlep31EHTZJkCvkHOOH7vMO6ty1m4WPLLm9X3No9vjvSzI7SUf2059xSl5ENgQ7PE+nDO0AAifVzZeEJiHETwmczFsGB4GpBuwCN139E1+wHXU4P/jb/GffbusT+FZqObmLHAYGdrcHyiU5dYOaGSRvDzaNd+FPWntFIc2vnBsHyI/JEyYf/DP/LTUjYiVbkEOVLkxTAPDXYx5krptwWPDNkRzUPr8F2nvFCgs854Xheb8XHdFAhcK6lEMHGbEUQYivJmB1fXugJeesF15w+Ak0XGHJkRLgTvr+LLnJ+mm/CEcjxVrUv2ySjaB1oz/qh9M+6QrWiqW44Ptks2clxhq5p9zujuADaPPp38rKIFmq0AfYbO5H+xHZBDryFLevKKe6e11/wyrWYSfKYgI49JhJUOtOteCqLHyXoVHM0iYejyZQZBhDI7hTwFPGv8mEtf7DZ8ZXLBSKTpKZPEq9AnJh+xWJVeJgtYq9CVw+zyaQ/7xm9HgqkrX7Jhbzi0fhedjUBx24RAzIBaVIPqNV+YPYSd4+j+7gKf06UvwoDIkt4yxd8rQAIRf23jdJgjk0SxLlZCfjuuD3i01n jHQGjBx7 X4yK+2lJQPjjoVWAERf8Zj2jkJQECUw5dz/op7UMUqn/ss5F8DjZOoAt+Eo1VLWzLNKSLXy/fV0fecSFn0QZ/Z6bwefw/bQeVkz1p6Of3LExQpYpMP7GAkm6Y7e2ZSg4ytA8ntzCO5Uqx5XDcy3jCpkssfnHglRlAk5nbcipWCEpIzo4deWoI7UEoUuIZzVryjxjC+JFDFcRJCHJbQI1+SV2dxo1R+nI0mq+TXulpLToO1quYMtWRJqxUglqThBV/3irNEnLhznhDMszt67kdanf6OP2RJLy+NLTbgIZjNbh+APse7nzvVOtZlYF6UploCLy+3dDzNP9rbU5vgouVliSaDvNl27Vty6ijxcKmj5Ioc5ugHTBXp4crWtVFNuecQLCuATcNUtG+bEAcUTJ6CUNd3Of+Gg4oyZyD X-Bogosity: Ham, tests=bogofilter, spamicity=0.004135, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 28, 2023 at 6:52=E2=80=AFPM Jason Gunthorpe wrot= e: > > On Tue, Nov 28, 2023 at 08:49:31PM +0000, Pasha Tatashin wrote: > > Convert iommu/iommufd/* files to use the new page allocation functions > > provided in iommu-pages.h. > > > > Signed-off-by: Pasha Tatashin > > --- > > drivers/iommu/iommufd/iova_bitmap.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > This is a short term allocation, it should not be counted, that is why > it is already not using GFP_KERNEL_ACCOUNT. I made this change for completeness. I changed all calls to get_free_page/alloc_page etc under driver/iommu to use the iommu_alloc_* variants, this also helps future developers in this area to use the right allocation functions. The accounting is implemented using cheap per-cpu counters, so should not affect the performance, I think it is OK to keep them here.