From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 597E2D591B1 for ; Mon, 18 Nov 2024 20:41:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DBC5E6B0085; Mon, 18 Nov 2024 15:41:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D6BBF6B0088; Mon, 18 Nov 2024 15:41:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C0C6C6B008A; Mon, 18 Nov 2024 15:41:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A2C096B0085 for ; Mon, 18 Nov 2024 15:41:36 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4F2B780573 for ; Mon, 18 Nov 2024 20:41:36 +0000 (UTC) X-FDA: 82800384324.19.BAAA268 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by imf14.hostedemail.com (Postfix) with ESMTP id 8F53F100006 for ; Mon, 18 Nov 2024 20:40:39 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=Rrwpk4IF; dmarc=pass (policy=none) header.from=soleen.com; spf=pass (imf14.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.177 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731962428; a=rsa-sha256; cv=none; b=RgQ1Qr2ehRrSpxWhhRLrjMVIdMMrQGP8be1dop7Kb9bE+8E256morYUocPjQOK6b897HCk pbxJld+8CHnifOWGNdRv7gN3R5x+kZMRSwOh9ggWZ2EE7nfxAvAIEIjwenZMiWVP/0XcI4 9J4uFUTXXQBbm/0aBnVEGanFRiLWjts= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=Rrwpk4IF; dmarc=pass (policy=none) header.from=soleen.com; spf=pass (imf14.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.177 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731962428; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h7QbYKH9VPj+hOiY2fMyzgFnxLdVIg0zx+W2Cj3yPZY=; b=SRy+U/UeRg/kH7UNZHlKF+1oyhpVBnJ+K/KKx79p1fcfadEIIRm+TT5XsMvGriepGjFXb+ kJFpslQGkeqBaomizLpBV7qc1MBSdEY75Phz1WlbE7TExxkPxwV+MJ2SapJ316zDUkahR7 Z279p1EV1H18ZwtT4nwqQ2x4zw3P9kk= Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-460c0f9c13eso38572071cf.0 for ; Mon, 18 Nov 2024 12:41:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen-com.20230601.gappssmtp.com; s=20230601; t=1731962493; x=1732567293; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=h7QbYKH9VPj+hOiY2fMyzgFnxLdVIg0zx+W2Cj3yPZY=; b=Rrwpk4IFIhcQ6xmdPZljlLA/b1fWAye4+FcH3R7O32uIymtRtddhK/9o7CY5YbYUJl WFjmKBZso47yN9NkiMVf2CtxsOAk8Ju/yzDJDGecjsIhijF+aWozKl9jKR5FxURfQIHP iOzs3pXqSVUKiOV7gUdtgVMDLEVdIaGQ7nREkW77Yr57B14aYicreNeGx6wYopwkR+2u cWTdxaAzRY0I6is8OPvMUzpYY8WfXlFjFJ8aJBvNSs62b9gzhit4o4hdaNl/jlMvR8o+ nwm+N+65xAiK9yO8mhOJZhOvQFxszSB+5jYxuvkHi50I82nRrrY4/5XcDRO5doVPERVa DR7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731962493; x=1732567293; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h7QbYKH9VPj+hOiY2fMyzgFnxLdVIg0zx+W2Cj3yPZY=; b=PkW8bgoU4mqaKua/OZyF/zW3gWVeBrBVsCZHynvLG7vrhe5vWPRvBvkKze9p9w1SGE uWZiT9tjqIupU8CA1kpLcseAzrCNM5NqYyilwl8ODP7bKC53/VD7YERP4/Upw1j26GR6 CTimGhQmKLlrY+dG7lpRoU5iE0LXxXDqa90c+rcCclIwKPPA9bj4eFgjjlZgd43VWBXo cXE8Sn6H/7ichWQfwTLVH+1mtszxDCJ6S2tEcL/JiIqyz7GkSR4Euf3FWj2bcT9WeGwv 1p9JvxvdN6O1nHVMavMjddoEWpuC2FwViMsoDi5H1lb+jgV8OBT1C4ggxZ8GBjqMmqt5 bbpA== X-Forwarded-Encrypted: i=1; AJvYcCVCO5wTTkXsMV1BOaFKW4PaPeYdmUyhkEEXhQWiTQbRMew0qjwb2422cfoD955pEcRmY4Fh+c0Zvw==@kvack.org X-Gm-Message-State: AOJu0YwKcexkaCb8gR4MLI3qKEnEyyVEJbpu9RtayyucsXa4VOQGdZri O1Fccx4+H4EM4mSNbJj49tZ0oRrS05jxKXsURVNkjKgnbliuKs8P/ojmmWjfhsAS9oOAJQyjPam B5A47iWCyKzw2QCkz1ekePIFjPw9ztwtROjX9Bt4UjJh0AK7WC8J+Iw== X-Google-Smtp-Source: AGHT+IHPkTMdVsfpp0/RKbPrlEoVV8KzVq6dWNp5U77zumURe2jy0UVz6GBnOpAbjSuf9hSbp1U2atu8BDg1WdqwOVQ= X-Received: by 2002:a05:622a:1916:b0:460:854f:a1c with SMTP id d75a77b69052e-46392e19039mr13350021cf.27.1731962493580; Mon, 18 Nov 2024 12:41:33 -0800 (PST) MIME-Version: 1.0 References: <20241116175922.3265872-1-pasha.tatashin@soleen.com> <20241116175922.3265872-2-pasha.tatashin@soleen.com> <8871d4b3-0cd8-4499-afe6-38a9c3426527@lucifer.local> In-Reply-To: <8871d4b3-0cd8-4499-afe6-38a9c3426527@lucifer.local> From: Pasha Tatashin Date: Mon, 18 Nov 2024 15:40:57 -0500 Message-ID: Subject: Re: [RFCv1 1/6] mm: Make get_vma_name() function public To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org, linux-kselftest@vger.kernel.org, akpm@linux-foundation.org, corbet@lwn.net, derek.kiernan@amd.com, dragan.cvetic@amd.com, arnd@arndb.de, gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, tj@kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, Liam.Howlett@oracle.com, vbabka@suse.cz, jannh@google.com, shuah@kernel.org, vegard.nossum@oracle.com, vattunuru@marvell.com, schalla@marvell.com, david@redhat.com, willy@infradead.org, osalvador@suse.de, usama.anjum@collabora.com, andrii@kernel.org, ryan.roberts@arm.com, peterx@redhat.com, oleg@redhat.com, tandersen@netflix.com, rientjes@google.com, gthelen@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 8F53F100006 X-Rspamd-Server: rspam01 X-Stat-Signature: gjts3rps7tddn47iioc4u7id9tdpidbd X-HE-Tag: 1731962439-640771 X-HE-Meta: U2FsdGVkX1+lRijQoIGwQwzs5Uf/Mitbmx2ROsixGRlSDMCbFu2G6iLnabZCirSJ6mxjlL99BZzhflsUGxlBCG/zwwipCbtP+o9excIdrIIpg2jp7rAeAbJe9cMhIjrTmj/berOJ4bvhlD2pjZ4oPVApAB6o0flZfL6gR1Gl1OL+CEY4kObt9LgQUIQVY/CkTQ3qPj4mFc3DC191pXd3EnxY7FI/DwTk5NmZRm7rW3x4jRUN6nTEUo77Rbyk4U+h1RDi0Kw6D0hxIsONQmY41UK8pnuTHeLAdtQymhsmww1+/KgYIw5jnu4lyy8WkICYtEvxmYt9B2XclQir27KYb5DKF2T+S1AjkmeToi1RUDQfiSx76oiWYZzG88G920F1373shiK0Yk/OKek/ban1AkT9cZVTf8XyDhuw47wSOrVIJdVlLlXMlf6kadYrk6pL4XoqMmPfVA1P8sLlVEiubdlu12P6JOyf1zJSOlK6KdtDmyh44eFfX4KqedUICrtRhTGFlGGJiGXZnfSkZReQ95HTP8FwO/kYAxDSR2jzPOlu6nYI658kl/+Mtv6rIyBU1E/M9h/rjuThr2CCINXUEGbL2tyrpyVKOK5oAV4wYhYjtyvfwBl8Wm7o9Qy2f+71ybGjQlWv0j3/UGqv4ruyb4+OxRPox1wYqMWxEIio+YloPV1Drn5ax3xH1chl+hgKc+dcROcfXzwoFxkrvhQ+ASL33KckO3Z+D8XnnVaViu5e6t11Of2f0MHR+KT0Eo/y38c9I/oKnuqzOCeL59hdGCtyqPMn27KHw1P8oSIidCslXLiQMKifUPfbNfA0ZgyCspSV6958vWqscQuq/MvdtZmF2m1PsHocwuyXfnNPaTvoqxgGECPDoHSdeD9JkllmgnDmiZFke7CMPiYm2JdXkNJ5OgcIP5JWwBC8q4nI1pmpMBy93Rt+wDsPm4NwT0M40oII/ezRuNii7VoqWPX dGnPCDEi C6bhgLVZrRvpZzIjBUCbMH/Au2hp0JnnHKLUYjw7eA2hSN4ueEiEAzKPvIZZA7Pm+RARZvqhc7yeU+LEx8DwZelTa/Sl2VQioQ8AH1yH9y54W+6IoZY60a70r3JGqM/xY5vuD9/nolLz2mqhzR2H2EvEKVotx/o64rwwGVXnbvR3y0TH1m6PweJm7Yr1VQQKQREQnCiS2WeWRzNxT6FcJAwzZjHQz2IAsGtspga4Do33o8ikDfRJ2TItRotfyFFmIHk1goPKOD6TV/YT6weMNmCOjh0jjvlRg1gbKVACzT0wGJpeywN/bC/iKRX1r8/RI0MWy5dsfDxae0SI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 18, 2024 at 5:27=E2=80=AFAM Lorenzo Stoakes wrote: > > On Sat, Nov 16, 2024 at 05:59:17PM +0000, Pasha Tatashin wrote: > > Page Detective will be using get_vma_name() that is currently used by > > fs/proc to show names of VMAs in /proc//smaps for example. > > > > Move this function to mm/vma.c, and make it accessible by modules. > > This is incorrect. > > mm/vma.c is for internal VMA implementation details, whose interface is > explicitly mm/vma.h. This is so we can maintain the internal mechanism > separate from interfaces and, importantly, are able to userland unit test > VMA functionality. > > I think this _should_ be in mm/vma.c, but if it were to be exported it > would need to be via a wrapper function in mm/mmap.c or somewhere like > this. Ok, I can do that in the next version. > > Also you broke the vma tests, go run make in tools/testing/vma/... Hm interesting, I will take a look, this is surprising, as this patch should not really change the behavior of anything. I guess it would be because of the out of kernel vma.c build? > > Your patch also does not apply against Andrew's tree and the mm-unstable > branch (i.e. against 6.13 in other words) which is what new mm patches > should be based upon. > > Maybe I'll comment on the cover letter, but I don't agree you should be > doing mm implementation details in a driver. > > The core of this should be in mm rather than exporting a bunch of stuff a= nd > have a driver do it. You're exposing internal implementation details > unnecessarily. This is not a problem, I will convert Page Detective to be in core mm. > > @@ -3474,6 +3474,9 @@ void setattr_copy(struct mnt_idmap *, struct inod= e *inode, > > > > extern int file_update_time(struct file *file); > > > > +void get_vma_name(struct vm_area_struct *vma, const struct path **path= , > > + const char **name, const char **name_fmt); > > + > > You're putting something in an mm/ C-file and the header in fs.h? Eh? This is done so we do not have to include struct path into vma.h. fs.h already has some vma functions like: vma_is_dax() and vma_is_fsdax().