From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AB3EC54E41 for ; Mon, 26 Feb 2024 15:22:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E7976B0151; Mon, 26 Feb 2024 10:22:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5497B6B0154; Mon, 26 Feb 2024 10:22:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C4916B0156; Mon, 26 Feb 2024 10:22:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 274F46B0151 for ; Mon, 26 Feb 2024 10:22:03 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 79B16160666 for ; Mon, 26 Feb 2024 15:22:02 +0000 (UTC) X-FDA: 81834320484.20.C667854 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) by imf16.hostedemail.com (Postfix) with ESMTP id A5AE818001E for ; Mon, 26 Feb 2024 15:21:59 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b="EAs1B/4G"; spf=pass (imf16.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.172 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=pass (policy=none) header.from=soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708960919; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+YAsFvK90oUcyunlKypP0cgUIeYQWof3rSlBEnKwPsU=; b=BHgwXSvXL6/LUy1gcTE4BN8d7LdY7+jLWUTaEkdHCtmLgU+9HjxuZrxz51PTQUZsAs2K7e bUUUpaGYQfw1TF/uJTcRTLCYACl6jgrcJz4i9BfIWIRPUM5dpZmYUAnH0pNThCBFzxyM1F dIQDp/dkh+bcoT4rk8mI0NiYJlOmuk8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708960919; a=rsa-sha256; cv=none; b=n6st2nW4MgMP9Ty/+KUfAvYQ7nifwrCLTxgzjAzfRbK8aiQ8gxUrE1LZH5MiQ8RBi1/Wnc FHiSUkN4VZQmE9w+cqMD/hLmNVW2qZG9vK8VRluK/Ui3STVuLgYtCJiB/MksyrY8j+dXWQ CXONCrQ7B92FInIqd2YnG+ia8f9vkg8= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b="EAs1B/4G"; spf=pass (imf16.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.172 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=pass (policy=none) header.from=soleen.com Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-42a029c8e76so25377861cf.2 for ; Mon, 26 Feb 2024 07:21:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen-com.20230601.gappssmtp.com; s=20230601; t=1708960919; x=1709565719; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+YAsFvK90oUcyunlKypP0cgUIeYQWof3rSlBEnKwPsU=; b=EAs1B/4Gs00UYAJWEtiv2KHpSJLTdpsSzbBTdwmVJ5B8LxOp+PqD1GUNt2ZOyHSGUI +77U0ibCfxiddbuVNpCpEY5v0q4BtqMDwRCwB539XkiVmyWMDeQU5pNcHfdy51/LJ1Ms wB3UPGRvo17PtQQtfp19dH4PyOCLrUHdFL1NVdp4d5Fo9z9FK2qXy7FPoyTPM4m6kq6a xu+GYSu97JSieKyixoz2slGdu1ZKoTxHfP3r7yafSK3K7Rcb7aIebfAgcRNRu/lsAtKj VQQ09YSDZgmbRTtdC1Blmp4eTMRk1UFLXvTUtMEKFUR5l3XKQMiRnZM+1uIDmPlBGUc9 w5XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708960919; x=1709565719; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+YAsFvK90oUcyunlKypP0cgUIeYQWof3rSlBEnKwPsU=; b=egMINympWVPRVCsk8lHG0bGZ9DifIzILSyNHmMnDam/D9WmHvNHx3mZU7xzkk3Ucyn MN9ZJZ8XeMGgkY8usCf45TC+vWB8dmL2mJNxicZZreov4kCjylJj+yWx7VfssH2ECbKL YBT/V/25w09svuluuFcMvDAYKS2SKLxX/fPAu+Iny7CU5Qs9k7SEfpf5tonIasGWKpth LQtuBUUcXB4OZBN8XN0KiZPdF6QO/jfWzqK/pWGh4PxrmkFIWxEIjTL4V5Cqc9erB2um eso9e7GxJpnIWE0b0ft4D/QYImZtrrPPrvco0z7AS71CnNUU6ZJugEgPVEp6LhdDjK+x qNRA== X-Forwarded-Encrypted: i=1; AJvYcCWvMJJT96EbmZe7gdEBbsaF6GMZT2iHzoVjlzM7ePJjeSEqe6GVvp5J7hFCQFGGzkRX9FwfPleTzl0jmkxtDPxNS2Y= X-Gm-Message-State: AOJu0Yz/bq2icuUOpo+Jgf6GefFBp/9YSPbtWOUSI2Mw8Mes2bjVSMql ne4Dr2GcbB39kQWx336OfMcA0EPLBAy3LUeCctuEb0NszzDgy1ieWtahib0h0OvSCqtU0nb+nzN Rtwp702nWuzJu5Yla/9+ozCHceM7JmW94hPpo1A== X-Google-Smtp-Source: AGHT+IFLDgnLJs5zjBxOHHBzHhT4JTr+7OTmsWB7N+dFwRBO0sPRqi3K8LDXm8g5YivkUNVnWCKpkQ3ibQxOl0AIttc= X-Received: by 2002:a05:622a:1354:b0:42e:8b5c:fd01 with SMTP id w20-20020a05622a135400b0042e8b5cfd01mr1779068qtk.54.1708960918671; Mon, 26 Feb 2024 07:21:58 -0800 (PST) MIME-Version: 1.0 References: <20240221194052.927623-1-surenb@google.com> <20240221194052.927623-4-surenb@google.com> In-Reply-To: From: Pasha Tatashin Date: Mon, 26 Feb 2024 10:21:47 -0500 Message-ID: Subject: Re: [PATCH v4 03/36] mm/slub: Mark slab_free_freelist_hook() __always_inline To: Vlastimil Babka Cc: Suren Baghdasaryan , Andrew Morton , Kent Overstreet , Michal Hocko , Johannes Weiner , Roman Gushchin , Mel Gorman , dave@stgolabs.net, Matthew Wilcox , "Liam R. Howlett" , Tetsuo Handa , Jonathan Corbet , void@manifault.com, Peter Zijlstra , Juri Lelli , Catalin Marinas , Will Deacon , Arnd Bergmann , Thomas Gleixner , Ingo Molnar , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, Masahiro Yamada , Nathan Chancellor , dennis@kernel.org, Tejun Heo , Muchun Song , Mike Rapoport , paulmck@kernel.org, Yosry Ahmed , Yu Zhao , dhowells@redhat.com, Hugh Dickins , andreyknvl@gmail.com, Kees Cook , ndesaulniers@google.com, vvvvvv@google.com, Greg Kroah-Hartman , ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, Steven Rostedt , bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, Christoph Lameter , Pekka Enberg , Joonsoo Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Alexander Potapenko , elver@google.com, dvyukov@google.com, Shakeel Butt , Muchun Song , jbaron@akamai.com, David Rientjes , minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, Linux Doc Mailing List , LKML , iommu@lists.linux.dev, "open list:GENERIC INCLUDE/ASM HEADER FILES" , linux-fsdevel , linux-mm , linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: multipart/alternative; boundary="0000000000007e237a06124a7861" X-Stat-Signature: tj5onee7fycmhpsa5rwizq8uqwpmc51d X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: A5AE818001E X-Rspam-User: X-HE-Tag: 1708960919-658428 X-HE-Meta: U2FsdGVkX1/JkQIR/nX0uA3o0Y2o316B+vjKhFVZAcPX/NQ6njudn+DO9ifahPsv41gmsU6RDr6UeYqa+bfHu0pLQRcPWa8OiRV/rCeBwCFrkQEogCzsTOhEEF13ERMgA2s38hvqR7tNNN8vDsnVnNdzY41/iKkEhbUhy/YpQTeyHHchYT1eeN98hssVwC0VUbO1Oa8FWPuVnaDrvtpZG7n1g47dQ4SYArb7ZvypN2MWG6DCaYQ0xtq5Eps9QQJ1Gr+4psbzKC2NospJH2yoC8OdF0XyxgoWD0qg0ZElHNeyof+9l7d59cSJjPqllb22UfK9NW+jouykl+C1raGR+GqMVrtQzGpnEKvbv96k2Y2j2hBwtg8Z2ZMV25cTL4UEGtqm0zGv6lKGEjdcBbr7C2o7fvw8fdrLRbOBfFfG3iMEaJSmA/6AiMfqR+LiHJK1bWi9dckf5KKAyn1z6rwunAT8cx4Km1j+XT0bZCnHX2nWkXMBHPi675IdpWiq0/c9ZrtctP1vaqLWmzARoV8U4h8ELBSwsHvxwZxKpSi9p4B5ebmDM2rB/hkPPR1AN+zNK2a6bbxEfBlEEbJ5pHyDWhZsxakjAbtMdNJTjcVFDrDwE7ynDoz18q4sR+z0ucCGVKJG+dIv6BHZ7/m73cIzHK1+zzJolfLr4gcf2J5KokQVbmYVucZbIQrJGckiMK+41hKF2dRZTlFfKhoapXUJKgTH0ekBfYMV+84CWwEA2dON7UovIZA9Pnw8N1e0Zy7QKT9H/w5edUAM5w06HvBzeeT3p5J3RC0qtNFwfO2bHlOIf4eOr5bC0dAkP0ppaQDy7SH+gDhLyRf8fMMPAwW2E5l6hRe8hIaZyFFHGDdVBL+5BPC6Ds3vrM8OWWMBrrqfVB2sg00s3oXVxHBEsvsNjq+H8v+rFfA83w52rWh8lOadRuVN8TPEq3wyfreWQnSXTBYQUsl7QroIKl/oyVN h7A1johL qCzpMrhNUSnIVXi2T0xcqLuzFHYyUXxrlvHu1bCiREmQ5cFEKJEsOae3u0DpWc8rtSpNZMNTNceP3EPV3pDcmzCuvJE4qCanL7tuVeZS7Ku0S3/T1SgDNrAXdLUglnYrHvqoxxj+hMbigWUb1bUJRq3DuP0+napAMWEpGWiY6/8vCqnGzIPDxclAWD9rTibXLbHZmqffzTs5pQlwQJVBn+M8gLGJrU2B/Yr928IX0nxJ2ltpTAWmWnSWWvbJO6B0vnXGdJaVcbglSgaAtYmRwYjpQJNIah1v01ErGIwT610cMN0nKWtmId533GYkBKYSp0eIG8xRHnHIfSUfvJ4yhkFBPzrTFCUe36wtUcSbbjBpVyxg/X6UtVU/bZq1cCsmWu7IdWFezXUHvOHk7WSkG81rpXSYcKipCJvg8OybxIsKSCB+W2jeUPOeFcDIbsTMBuCPolZL2/ekr2WR4X0AEz9dUlAvT/U3YUhKKaLy0kFDGb+J3o41qmboDMqY6PaHMmqGzSEPXCywDINtcL3S+JMFnNLI6ciDA0wZGkUkM+HULc6sA/VIcA9We632O6+e7SNih2OokWTQsvmV+poMcKbXCWlrc8LF6Sx++h17NFsWYrhxAWTpJKFdzi0O51kXdbhnU9ORd2pzL6MU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --0000000000007e237a06124a7861 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Feb 26, 2024, 9:31=E2=80=AFAM Vlastimil Babka wrot= e: > On 2/24/24 03:02, Suren Baghdasaryan wrote: > > On Wed, Feb 21, 2024 at 1:16=E2=80=AFPM Pasha Tatashin > > wrote: > >> > >> On Wed, Feb 21, 2024 at 2:41=E2=80=AFPM Suren Baghdasaryan > wrote: > >> > > >> > From: Kent Overstreet > >> > > >> > It seems we need to be more forceful with the compiler on this one. > >> > This is done for performance reasons only. > >> > > >> > Signed-off-by: Kent Overstreet > >> > Signed-off-by: Suren Baghdasaryan > >> > Reviewed-by: Kees Cook > >> > --- > >> > mm/slub.c | 2 +- > >> > 1 file changed, 1 insertion(+), 1 deletion(-) > >> > > >> > diff --git a/mm/slub.c b/mm/slub.c > >> > index 2ef88bbf56a3..d31b03a8d9d5 100644 > >> > --- a/mm/slub.c > >> > +++ b/mm/slub.c > >> > @@ -2121,7 +2121,7 @@ bool slab_free_hook(struct kmem_cache *s, void > *x, bool init) > >> > return !kasan_slab_free(s, x, init); > >> > } > >> > > >> > -static inline bool slab_free_freelist_hook(struct kmem_cache *s, > >> > +static __always_inline bool slab_free_freelist_hook(struct > kmem_cache *s, > >> > >> __fastpath_inline seems to me more appropriate here. It prioritizes > >> memory vs performance. > > > > Hmm. AFAIKT this function is used only in one place and we do not add > > any additional users, so I don't think changing to __fastpath_inline > > here would gain us anything. > For consistency __fastpath_inline makes more sense, but I am ok with or without this change. Reviewed-by: Pasha Tatashin > It would have been more future-proof and self-documenting. But I don't > insist. > > Reviewed-by: Vlastimil Babka > > >> > >> > void **head, void **tail, > >> > int *cnt) > >> > { > >> > -- > >> > 2.44.0.rc0.258.g7320e95886-goog > >> > > > --0000000000007e237a06124a7861 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Mon, Feb 26, 2024, 9:31=E2=80=AFAM Vlastimil Babka = <vbabka@suse.cz> wrote:
On 2/24/24 03:02, Suren Baghdasaryan wrote= :
> On Wed, Feb 21, 2024 at 1:16=E2=80=AFPM Pasha Tatashin
> <pasha.tatashin@soleen.com> wrote:
>>
>> On Wed, Feb 21, 2024 at 2:41=E2=80=AFPM Suren Baghdasaryan <sure= nb@google.com> wrote:
>> >
>> > From: Kent Overstreet <kent.overstreet@linux.dev>
>> >
>> > It seems we need to be more forceful with the compiler on thi= s one.
>> > This is done for performance reasons only.
>> >
>> > Signed-off-by: Kent Overstreet <kent.overstreet@lin= ux.dev>
>> > Signed-off-by: Suren Baghdasaryan <surenb@google.com>= ;
>> > Reviewed-by: Kees Cook <keescook@chromium.org> >> > ---
>> >=C2=A0 mm/slub.c | 2 +-
>> >=C2=A0 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/mm/slub.c b/mm/slub.c
>> > index 2ef88bbf56a3..d31b03a8d9d5 100644
>> > --- a/mm/slub.c
>> > +++ b/mm/slub.c
>> > @@ -2121,7 +2121,7 @@ bool slab_free_hook(struct kmem_cache *= s, void *x, bool init)
>> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return !kasan_slab_free(s, x= , init);
>> >=C2=A0 }
>> >
>> > -static inline bool slab_free_freelist_hook(struct kmem_cache= *s,
>> > +static __always_inline bool slab_free_freelist_hook(struct k= mem_cache *s,
>>
>> __fastpath_inline seems to me more appropriate here. It prioritize= s
>> memory vs performance.
>
> Hmm. AFAIKT this function is used only in one place and we do not add<= br> > any additional users, so I don't think changing to __fastpath_inli= ne
> here would gain us anything.

For consistency __fastpath_inline makes mo= re sense, but I am ok with or without this change.
<= br>
Reviewed-by: Pasha Tatashin <pasha.tatashin@soleen.com>


It would have been more future-proof and self-documenting. But I don't = insist.

Reviewed-by: Vlastimil Babka <vbabka@suse.cz>

>>
>> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 void **head, void **tail,
>> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 int *cnt)
>> >=C2=A0 {
>> > --
>> > 2.44.0.rc0.258.g7320e95886-goog
>> >

--0000000000007e237a06124a7861--