From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 977D3C43331 for ; Fri, 6 Sep 2019 15:40:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5DCE620842 for ; Fri, 6 Sep 2019 15:40:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b="X+TZLFq+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5DCE620842 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E552D6B000C; Fri, 6 Sep 2019 11:40:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E2DA36B026C; Fri, 6 Sep 2019 11:40:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D43416B026D; Fri, 6 Sep 2019 11:40:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0196.hostedemail.com [216.40.44.196]) by kanga.kvack.org (Postfix) with ESMTP id B2E276B000C for ; Fri, 6 Sep 2019 11:40:11 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 3066D180AD7C3 for ; Fri, 6 Sep 2019 15:40:11 +0000 (UTC) X-FDA: 75904907022.14.salt20_3bb9440e62630 X-HE-Tag: salt20_3bb9440e62630 X-Filterd-Recvd-Size: 4738 Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Fri, 6 Sep 2019 15:40:10 +0000 (UTC) Received: by mail-ed1-f65.google.com with SMTP id f2so335146edw.3 for ; Fri, 06 Sep 2019 08:40:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CjF3fwI23SGTIbsZbebpupUjHvggvSShXHb+f7gohRg=; b=X+TZLFq+/8fiOOZaSxM4o7weyYJJYjKBVTcRCZfcxr2IxHAce/BmJfEXlo+kHisHhF mlpMhUTxWtcXV/LgdZFzuY7qNCrZaKMw8ItKcgilp5WTkQNFuCtZgPd4jGMxpgeusHKy +ahYXFtlTF+mSXTcvIEKTHM34JZSa4gUxMyQbY9ovXkeE1DqzeHziy0kVUOT9HDoGgh+ 86qEcJGuBwvEp64MJNk43vufsS6oXhTwJOTInG+rMeHXceUdYHOhY8j0CA+yEADsDreV fxhYTUKSD4lXhNC87Jhmdi20O2F9lotiaxFikDlzOtV2OTRHPhktK0wYcLrfjjdxvON+ FoEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CjF3fwI23SGTIbsZbebpupUjHvggvSShXHb+f7gohRg=; b=N0rD+sm1fRpcEcXtVp4fWLYzSoG6V3XXup8fQ/Yo6Ueh63Qh30da+I+Erg6FzePKDU SlDXlb4+ayO6HKnDJR2Nv3CXJ7EYnAG1+10NDqn+Rf/oFKdGCBjbwObJakVsJvwvbeAU i//UVQzB8+Bcst6EVpAAtVchpi2sxjiHZDpQXOs/Ha7plSmYMeVR1U9VQR730Ox8dcW4 C0be7Up97odVE3VCghhMn0gXq+XVgBTOXLAQWf6yxs8qucYSbGgof22Z++IOSdoS1iLW fG/8D9O4GWxz+bhSThPD1/6L+yjkqqM3/elOs0EQ/HVdkVfaivT0S0SzQNVydMNwY3TT Ykkw== X-Gm-Message-State: APjAAAW6mN5S2jkxhXO7d9nfQ9y+s9rbeOKQfZoHb8znGWUYHxnh07Ay hDdFRrMRbzvkM035kDvJt5B4TGyKOk3yOdwPNY5iJQ== X-Google-Smtp-Source: APXvYqwgWEKdsXXZDKUgZfHTTS/3PBS/mpsvU7NBgD+cDEAZM2KkwC32Gcr7KkyJWBr9wuGwTdTO2+WUmBcm/dqbcb4= X-Received: by 2002:aa7:dd17:: with SMTP id i23mr10239139edv.124.1567784409076; Fri, 06 Sep 2019 08:40:09 -0700 (PDT) MIME-Version: 1.0 References: <20190821183204.23576-1-pasha.tatashin@soleen.com> <20190821183204.23576-3-pasha.tatashin@soleen.com> In-Reply-To: From: Pavel Tatashin Date: Fri, 6 Sep 2019 11:39:58 -0400 Message-ID: Subject: Re: [PATCH v3 02/17] arm64, hibernate: use get_safe_page directly To: James Morse Cc: James Morris , Sasha Levin , "Eric W. Biederman" , kexec mailing list , LKML , Jonathan Corbet , Catalin Marinas , will@kernel.org, Linux ARM , Marc Zyngier , Vladimir Murzin , Matthias Brugger , Bhupesh Sharma , linux-mm , Mark Rutland Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 6, 2019 at 11:17 AM James Morse wrote: > > Hi Pavel, > > Nit: The pattern for the subject prefix should be "arm64: hibernate:".. > Its usually possible to spot the pattern from "git log --oneline $file". Sure, I will change here and in other places to "arm64: hibernate:" > > On 21/08/2019 19:31, Pavel Tatashin wrote: > > create_safe_exec_page is a local function that uses the > > get_safe_page() to allocate page table and pages and one pages > > that is getting mapped. > > I can't parse this. > > create_safe_exec_page() uses hibernate's allocator to create a set of page table to map a > single page that will contain the relocation code. Thanks I will rephrase it with your suggestion. > > > > Remove the allocator related arguments, and use get_safe_page > > directly, as it is done in other local functions in this > > file. > ... because kexec can't use this as it doesn't have a working allocator. > Removing this function pointer makes it easier to refactor the code later. Thanks, I will add it to the description. > > (this thing is only a function pointer so kexec could use it too ... It looks like you're > creating extra work. Patch 7 moves these new calls out to a new file... presumably so > another patch can remove them again) > > As stand-alone cleanup the patch looks fine, but you probably don't need to do this. Without this clean-up moving to common code becomes messier. So, I would like to keep this change. Thank you, Pasha