From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9940C54E67 for ; Thu, 14 Mar 2024 13:42:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2927A800A6; Thu, 14 Mar 2024 09:42:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 242FC80073; Thu, 14 Mar 2024 09:42:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 10B3F800A6; Thu, 14 Mar 2024 09:42:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 004AC80073 for ; Thu, 14 Mar 2024 09:42:45 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C86D2140547 for ; Thu, 14 Mar 2024 13:42:44 +0000 (UTC) X-FDA: 81895759848.25.D263EB9 Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) by imf30.hostedemail.com (Postfix) with ESMTP id DCCA28002A for ; Thu, 14 Mar 2024 13:42:42 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=GdMMnoek; dmarc=pass (policy=none) header.from=soleen.com; spf=pass (imf30.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.128.171 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710423763; a=rsa-sha256; cv=none; b=rJpDMI/2dlcq/cwyuvjf8HCPdmmQHx3oEOY0d5jN85ezzSoy7ItqE0Eowpo9MLAQz3quXX IT5YzuEpgtNUrXxCe7QGkugSkgjWUqzNMnBTbOFmcCFeHJK2puOsC+XQkA5mM0dRY0sfRi 71KFgXD0lpccAr/yDV+yg6SttBLJxcY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=GdMMnoek; dmarc=pass (policy=none) header.from=soleen.com; spf=pass (imf30.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.128.171 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710423763; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tFAZU9ltO4/NJyne7uET/FKWCg3e97DY7gCJUzC0+4o=; b=VsOvx6YGY/ix6oRLP5Z/dd75FKs0VpXjh7943i0JOx+7dzEe09haOggDaz6VJ0osf0ZlH4 nWCfz9BKVhIO0ahDnwHNAlYnvuphIxNMp9+I2qZIwvNfnVL6bmm1aZgwHNb+qA9JFdaJNg 3/V63cEkndRbk0nMcWlSgf50s+262qU= Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-60a068e26d8so11014727b3.3 for ; Thu, 14 Mar 2024 06:42:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen-com.20230601.gappssmtp.com; s=20230601; t=1710423762; x=1711028562; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=tFAZU9ltO4/NJyne7uET/FKWCg3e97DY7gCJUzC0+4o=; b=GdMMnoekHvfhVcyvmwNZTFJAEahjckjqaJzChJpPwRJyqX1sQ1ZWIbSpP5D0IxLlM4 cRjd+Et68FC4rUB/o2/DeL9Fji7plg+c34utuJjJOAh5XLD5OJrf3BcteA4zJ16osoH2 qLJ+8ISIOOeL0ckwt70a25YXo8Pt+SRdXoNusgP3KSk2dFiMZDMFyo7P31rKhJvNMfSp JDpPCibOWmUOoPmArZYv6+abJqSTi59UInH8knKfUOKsD18uby+wUXwQfHJSoFeagnm9 Pzt2AyLGFxD8K1l+GNVOECodAE73LoBdUS14UhLenB1MfiJg5Ayz+ZVlx2BjfxcW/TEX Ra1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710423762; x=1711028562; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tFAZU9ltO4/NJyne7uET/FKWCg3e97DY7gCJUzC0+4o=; b=SiuC4t+4m3fYIkm5276PKSln/39UEIec3Lh8HSOdTPzkq2krfWVeOJCF1Qdf8bb0/l TBZc1wyggRrNM++qO/O+YFcGovag4CsBCX8231AJENL4lfo77tFJKxGTOhnX5Id8zkAk /05tQvYtvHIP6dXR2j21+8sJLzCPUWAaKB5pMFyOQ2KDoalg0KDqo34uzA5/pRswVlb6 rFDRofWxG9kENncr14flJtJzCV/Efne4eOPNysWsasib5eckWSIVoKutlTUDMaN6Txk1 kHn2l/uvZ8hmEd55W3lPcIM7YBoxv9YnwkKTryMycBLQh3ZurhVeMuVaSLsTQXg875WR 453w== X-Forwarded-Encrypted: i=1; AJvYcCWkfU3IM8RplctHcbZm30Smw1QbFTS4sCjdESWruelWqdeuyieakswBCg20rmJuaLjLpVpKiT0Dg0Y5FC7a22y6sWw= X-Gm-Message-State: AOJu0Yyz/ajEj1w7w9m4m5d5eLqDlE5mB2XijVVujqeRM5+s4eMbT03X HmcolHZeLDDp5G+jGHUL1Qkad3zAl2enACuwo7izGWUPWTZxcez2B/lg4BLI+PGyRiIpGaddWKk QL84V/2KTzrdpLvvRe8flTpONZ1RPVDBJXlUYdQ== X-Google-Smtp-Source: AGHT+IFzzcSAl90VnCLvZimd3g0bzNXZxRAp/ul8mB1XTM9UGCCCa9yxtndGCwzS1Os/g+Yi59BMDjnUWnLh700inqA= X-Received: by 2002:a0d:fe01:0:b0:60a:2b18:6637 with SMTP id o1-20020a0dfe01000000b0060a2b186637mr724546ywf.34.1710423761902; Thu, 14 Mar 2024 06:42:41 -0700 (PDT) MIME-Version: 1.0 References: <20240313033417.447216-1-pasha.tatashin@soleen.com> <7af73776-06f9-42e6-9bfc-fabe8f8b002e@csgroup.eu> In-Reply-To: <7af73776-06f9-42e6-9bfc-fabe8f8b002e@csgroup.eu> From: Pasha Tatashin Date: Thu, 14 Mar 2024 09:42:05 -0400 Message-ID: Subject: Re: [PATCH] vmstat: Keep count of the maximum page reached by the kernel stack To: Christophe Leroy Cc: "akpm@linux-foundation.org" , "jpoimboe@kernel.org" , "kent.overstreet@linux.dev" , "peterz@infradead.org" , "nphamcs@gmail.com" , "cerasuolodomenico@gmail.com" , "surenb@google.com" , "lizhijian@fujitsu.com" , "willy@infradead.org" , "shakeel.butt@linux.dev" , "vbabka@suse.cz" , "ziy@nvidia.com" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: DCCA28002A X-Stat-Signature: b7a77jm6ht6ocg1id1nphm1ys8a1oj78 X-HE-Tag: 1710423762-983983 X-HE-Meta: U2FsdGVkX188jnJGrfXWDgsz0yaQ+ywANip/NsYzs/UIeoz08/qS+xgxVHtwBV5dPgF78QQZk9IPYY3Y16F+pLb1kc/b8NSV4Ec9181fmdCwfhO6Nr/kRiW0t2lPZE5j17W0uaSIjbwXIJn3hjPVOmx2tjOHW6xw7eL+qTd9MTv3j5YTmlaDtnYPRxD0X/D9WC8+RiaQerUiAREXg2RAQvqU6deAKEpd8633mJO24SsNDnYgetclZ3jn/H0fsA8Y9VkaYmDVg2dcCwikanCB5EwD+77tat2fsQZSaDXtDVz/0oPT065jXm+7kJflJsHiq+qWQQSrMKZyZ7r/dJperYhxN6a1rci5zDLEC0nYCOM/xY4wFe+bHqrFn4MmZ32FIBFOHYf58+TrNpEago0MKtZhKUYQlW/19OxmKexCcaF2PgAK6xQCTki/N+90UNZYWW+zBpCaH1elEddCPqEFaOSjsWU9cMY7pmNTTpWFcnuzASM37BolxSiK1S5xKyBSD0CdrTj4cIGFuiKJC9W5F8J+Vifwa3zqc12hzYyJgJkEVEG+6pbSA2OgAfC3N0FkKbOUK+Nbs7xi+NCyzXwSzEL+XEMU5sx2ndg4D27Q4jmT5TSd0f1z3+s4QWkk4+5UanD/Pzp20goqRwEUv33gIXdoH7srzdoF5gLSWcX32o0w3McnQ5oZmheRlmXhZDHVUX3tlADJLzk0J7oL8bNyZrB+vNqq2dws/Mx+M5BO6lhxuei5rrquPqN5KySr4+pt53OadlMRoBxHUJK8rA0xFZUD/HRQbC3ECcq8KWU0+qEg8yFzXsNiNxXVICXhVweOvBgqJns2EdciIr1u4JojtG2utO0o0GpVgw+NPIuBfsqI8Njw9CZwt1XOrtOTBSunxdk5uaQAZ9emZXThPW6LIx0EEYj4tiIpk8wWvcJ4W5TGLxEgiY6KDyiwdxvvYiD8zPHmWes5x1AzuYh+rqB dT/+/CbQ 6Eks7hbz4WUkMEOsIxyD+07p9BSj323PdMrVNGc2Qvy69Y7VsQMGiC3en19mZN1ZFRBXqfLIz5XWsiuJQKPXTouL5G9sB8/ShbxLKFxd6kiD9U9+KsSLvk6LB4WcZjAycGB5wbG3g7qlKRNtZMi9RzN5Zg8JB6ya9hDLCb+Yoi6M65B5NlDcwKY6NjSDndinvllGKYuVIH5bZTJCIo2csLergEPwI3gUVQuN2e1117rZIZOHzBgwJfw/0CACDzBJDJkSb0p+JmFQz5WIoEUJo6imDjBXiAkyWxCCe1aD9LM+bgrtrJ5FLpblKtieQrOM35SYKrTcHil5Ibb0TMpyeOfJcRQBMHWhkMfQLGphjMdu5Us9JBaqvtHbVLoBXI+FL5l+d X-Bogosity: Ham, tests=bogofilter, spamicity=0.006971, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 14, 2024 at 4:19=E2=80=AFAM Christophe Leroy wrote: > > > > Le 13/03/2024 =C3=A0 04:34, Pasha Tatashin a =C3=A9crit : > > CONFIG_DEBUG_STACK_USAGE provides a mechanism to know the minimum amoun= t > > of memory that was left in stack. Every time the new anti-record is > > reached a message is printed to the console. > > > > However, this is not useful to know how much each page within stack was > > actually used. Provide a mechanism to count the number of time each > > stack page was reached throughout the live of the stack: > > by "this is not useful to know ", you mean "this does not allow us to > know" ? Yes, bad wording from my side, I will change it to you suggestion in the next version. > > > > > $ > > kstack_page_1 19974 > > kstack_page_2 94 > > kstack_page_3 0 > > kstack_page_4 0 > > That's probably only usefull when THREAD_SIZE is larger than PAGE_SIZE. That is right, if THREAD_SIZE <=3D PAGE_SIZE, only "kstack_page_1" would be filled. > > On powerpc 8xx, THREAD_SIZE is 8k by default and PAGE_SIZE can be either > 4k or 16k. With THREAD_SIZE =3D=3D 8K, and PAGE_SIZE =3D 4K There will be two counters in /proc/vmstat, something like this: kstack_page_1 XXX kstack_page_2 YYY With THREAD_SIZE=3D16K, and PAGE_SIZE =3D 16K There will be two counters, but one will always be zero: kstack_page_1 XXX kstack_page_2 0 Thanks, Pasha