From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C5DFC001B0 for ; Sat, 22 Jul 2023 22:27:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2943D6B0071; Sat, 22 Jul 2023 18:27:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 243C86B0072; Sat, 22 Jul 2023 18:27:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E50F6B0074; Sat, 22 Jul 2023 18:27:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DBB006B0071 for ; Sat, 22 Jul 2023 18:27:52 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A4DBC80653 for ; Sat, 22 Jul 2023 21:49:12 +0000 (UTC) X-FDA: 81040588944.04.B26D15E Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) by imf07.hostedemail.com (Postfix) with ESMTP id CEF2740018 for ; Sat, 22 Jul 2023 21:49:09 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b="C4+k+Z/s"; spf=pass (imf07.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690062550; a=rsa-sha256; cv=none; b=bBMz8W7I6TNA+BT+FLu/tTDFQ023XouSvBZWZNXDxuG68xuNlSjc8sHhS2Z2MBSkkMD7D2 lGDHmJo4Is3MQ7Qf15TDedpkXL18xMcpUlr67CF3f8S8oF4Dgn2iS+zG7QNmb1jj5JJFYz P7wC/IXQShJEf/io0lEJsRK/HXX85/k= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b="C4+k+Z/s"; spf=pass (imf07.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690062549; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zFT73tDs5bq+8tXOEzAl6xxcGjb8CYVIC9WQ3Nlj2+U=; b=wYGv8ftmTQhT9OGOWvu+/yNNpVlNdwKCrBrddBj4TYUHa/0EVH6tPu0uFzatpwC4tMGW3G d89WbPKOsgCBzFVTcPH9oG1X/+E8oet8m2QeLqxFH5yThvxLkHuzCzj8cZQd0m902G5I+B 3lGjS2A36WoPRan8ehsJ9n3Md6K3w8Q= Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-403a840dc64so24513611cf.1 for ; Sat, 22 Jul 2023 14:49:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1690062549; x=1690667349; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zFT73tDs5bq+8tXOEzAl6xxcGjb8CYVIC9WQ3Nlj2+U=; b=C4+k+Z/sPWnkTz6g4tZlvc095VmUecXV7UlBTJrUc5Z0X+RNtogpdHI41KzMGbsZMI dEh5cuNnFUoPIUDM71Y6k57vsMmIdpbDIrEzq3M+ssuoaeqVt4+wXUbpECJ9IVQh2S6q +0Lp/l1EncHi8RLdOvM+nVegp2zV7BchkzXjlLowpc8OoAWv9JWM8V0EFSlj30g/7yBG UQkgqREF4LZfd1cpYK8/Sn49ebPB+GMa8o5NZOnA1iCDv7i2Pf2D4VXF4aGjGNwOaaOI cPed6Dwpury3UJTvbNhy92AYmngOhDmqgkci21vcc1mAX+DU9p2LMAoZ5QXD9DporPBL VOkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690062549; x=1690667349; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zFT73tDs5bq+8tXOEzAl6xxcGjb8CYVIC9WQ3Nlj2+U=; b=kpj8bKa6D2VGCOCHM1senZlR2260X0RbfUB7uIGQuxJiM5LL/5HaZ2NgRhKXObweBC V5S+YzbqLwHbCDsszikUxtpsA3+L7di+b/7DKVr7ZHKpyFhZcLEebbsGuPlzvpk9UeUJ LkNytXVA2rJS8jXZzzoMBKMLZrfAdt4Nax/6MLHoDIIg8e57r6aSl5JfdvMCFfKqHwE2 PRATj0Fho33VRcijcVWCWHgs6t28zTMrv+KBQUZHSOrrFYAMfNsThJi1jqhMg1pA0W5K 1duGL1ds0Aq39Ud4iNxxqNAwYXkUtDKY0yOGBI5eLkw/E1qPnJIYh6Tt9qCdUAzLMqP1 3H+Q== X-Gm-Message-State: ABy/qLafBmqvh7Jj3fRFeJ015MSjKqbikiasKjX0RfPw+FG0AtgSyeSf XCfJ+IuKOBV3ieuFpB9X8QUcGOvP9TSswnDgaa+wuw== X-Google-Smtp-Source: APBJJlG6wYMmFmsXZyQeCcMjr+jC03p7qKzxkb/2YA02gsPiQTpkOKYsIXX8LBz/BleMqul7hyptW8zi3qdpjQ/DKbg= X-Received: by 2002:a05:622a:11cb:b0:403:ea90:dfa9 with SMTP id n11-20020a05622a11cb00b00403ea90dfa9mr4863969qtk.60.1690062548963; Sat, 22 Jul 2023 14:49:08 -0700 (PDT) MIME-Version: 1.0 References: <20230713172636.1705415-1-shikemeng@huaweicloud.com> In-Reply-To: <20230713172636.1705415-1-shikemeng@huaweicloud.com> From: Pasha Tatashin Date: Sat, 22 Jul 2023 17:48:31 -0400 Message-ID: Subject: Re: [PATCH 0/8] Remove unused parameters in page_table_check To: Kemeng Shi Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: CEF2740018 X-Stat-Signature: 6pigo6cy3zqsbfskhskryj79nuaeqej3 X-Rspam-User: X-HE-Tag: 1690062549-695242 X-HE-Meta: U2FsdGVkX1+qh8q0AiPI1VbPSQ4mNHTrDW+WTpjiTxWV/fkEW+2zZCMKSINnJrJ85MXgjITLSbFwZn1s6VHNZh0fcJGesTF3H3cb8OAsqa3oxhl7SWK+nB6DgU8r06E32Bot+9p7Dr9+ys0xpWKGz3MYSvYTT4yGy8FlTlxQTb6vYoYYqltN2IRaIODzJU49RSzLHodnMtFgE9AIiEVXtrkUIIA2gSSBCvoHyL9YW41e68A4ugXaRG3SXCIlFxHA1SGKKdYBUB3kytm6mZPlH4TXt0bVaqN/VzT3TADhrKQQU6N4esa7UO6KoRd0eSOC3+SbgKT6oNE2ERwH0hC+hMMQAFecveAwz5Tgpdys+dbPVdqb3RbI0uw17L2ESGGJuvYNCw2bwKjJilNRwqXBDRlRRp/MICs8l1Igi+U7KmmEJ0jpT7b5DmNQiOHYkx1V+rDYIO9JJmvfAIbUjVPN5/lWeDqvJY0Gud/vqdXS3Gb5RYePwnJUThY2Ii4UsoGq+xQkOz/eTHInT+Si1Tm5M6NhHND6a7uIjZvreTHkLAtvwAqHxCPrc9T3dhLl4mLeVgNGf9aP7usoIfL3IVudVPW8+PYyicF802RndN6Tslf1CAskIqOq3AzZOjKFfEvkqhKCrLblfRjv4pGWZfHRTkhoglzexPUZdrOfWpIdvWWxwkdN8bPDRd3aaqzRcYK3J48or0+8/aLQGti+IchnYUdEz70rgZuwhFDQHrgmH5Mh7Jm2ua3+tB37Dii0gOVsusVTQmyhtinMvrZadj3hbjczBFylzCrXqU7uqXBGPARJoxJ8q3wnMUo232bpGVdI7AkuAhEl/9hsw6On+gFuZSUQUllqo+XZnBIkhm+h067Y1hFCgyWr7FxrVpg80lGbXu62kkDQ6MwM6M+fCtMuY5OG+ezpkOnaTCcc1fYGQp7CtDIXrYAGVdF0uDwfqFODfd+MTBuhmTLJ+Vcjqb/ WKfchGfc 5JYMxJzfAxaPq5UZrLHgWldPH4/Us7twqfFBnq4TGrjM2TS9Sn/uTSFQ/k+byIwx+7gd3IvLwFnhy7fY87t99Gu1rbywkb/nAio0R1gkZkPA9jZxrpXy2jFgeZRvv7oShNkyMy19b+xhYtKm6x6qVRJCeJnnLxF/Byq1dOuwpM23SFxqaFdPI1EZ6xVvAFEdyofgND0wmO5VnpZacwDFrPXNfv1WL10yfJ8uZS+idKOZpEgjuptWGV7LmO/1/n+ttvx4BsGNtWlTnkdC+m3nhMjpxgK+jtDxCpzYXHpklSBUNtYhH2KBDK2Lo1g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 13, 2023 at 5:25=E2=80=AFAM Kemeng Shi wrote: > > Hi all, this series remove unused parameters in functions from > page_table_check. The first 2 patches remove unused mm and addr > parameters in static common functions page_table_check_clear and > page_table_check_set. The last 6 patches remove unused addr parameter > in some externed functions which only need addr for cleaned > page_table_check_clear or page_table_check_set. There is no intended > functional change. Thanks! NAK Both, mm and addr are common arguments that are used for PTE handling in many parts of memory management even when they are not used in every function. Currently, they are not used in page table check, but it is possible we may need to use them in the future when support for other arches or different types of page tables (i.e. extended page table) is added. It is going to be hard to again modify all arch dependent code to add these arguments back. Also, internally at Google we are using these arguments, as we have a module that maps user memory in a way that is incompatible with upstream, and these arguments are used to support this module. Thank you, Pasha