From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29D32C433DB for ; Mon, 25 Jan 2021 15:39:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BA05C230FB for ; Mon, 25 Jan 2021 15:39:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA05C230FB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1CC418D0009; Mon, 25 Jan 2021 10:39:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 155518D0001; Mon, 25 Jan 2021 10:39:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 043B68D0009; Mon, 25 Jan 2021 10:39:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0040.hostedemail.com [216.40.44.40]) by kanga.kvack.org (Postfix) with ESMTP id DCC098D0001 for ; Mon, 25 Jan 2021 10:39:32 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 9EDF11EE6 for ; Mon, 25 Jan 2021 15:39:32 +0000 (UTC) X-FDA: 77744706984.28.name19_4a0c1ec27586 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id 579326C1A for ; Mon, 25 Jan 2021 15:39:32 +0000 (UTC) X-HE-Tag: name19_4a0c1ec27586 X-Filterd-Recvd-Size: 4299 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Mon, 25 Jan 2021 15:39:31 +0000 (UTC) Received: by mail-ed1-f52.google.com with SMTP id a14so4580183edu.7 for ; Mon, 25 Jan 2021 07:39:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Rra/deV4BpPfJHrSK+j1oedRvhTg8xlMYVP/CjTCdbo=; b=oT2pKEpwEYuKqNalnjLTRHdVcq6t3+B3XXVLdpXKu3V4ApIJJzXxasqADy9EZXqUXh n/BuUY/5ALgsbICzl3RIKCjVDYUHtIYek61hqI9KUL/2LNmRfnQ0GzO+XTL2MXbd3aK/ UsbqMjXr25onQ0szEsqlgipwxapnw7EPmLS3cPXyk2d8H28WIA52mQ7Yvol7ZM9ht9Zh 4+OwuM1jkeN51/bu6vR4JrA/Y4arNiozGdwTdv4f8cWHV411+H+g+HOBpzxam46DRzaS 2ThNiPt5XjxOw3h37ikX+KNHPGrNudfwkzs0vddCFZbZchOu9DDhuhN4cG8oBxIGQClP mP6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Rra/deV4BpPfJHrSK+j1oedRvhTg8xlMYVP/CjTCdbo=; b=eOTiV/4CP1Qe6k+PuIdn2WyMWJSyIaHrXRlKGluroX6j1uz19BGSm2Q0Rm1kFTnLsE YiW3widbm3A8jectrS+vKPVTybg8woo4B4Au7gRyxALYm0xrTfsY96Y7f3yC4o8ot4bT 2iKIrV5Dw10B7EJ892RxUN1YlkJR1VRF6cybh4pTbAahzn9f5NxeEWuf33i8H17fd9zU BghPM5wnXaDkWamFPKN8I5BYwLuN7yuzPMyD0pR2FzziGuhdNTHkyNSuHCWjMQQtc3mf Se6xtksRMlwbEyqkr1+s5snoXOAQy3YIripjvM6ECVWELrd+Ci3QfMzj7rOxmu06aVDQ D/4A== X-Gm-Message-State: AOAM5324yiLFEL2Ov7c/h0mFNNLzMGbljZ8UfwoX5raBKcWAaLLuDIVs M9mn/8oR8dldrGRFoNmdacXblVNPoqjG9C/MEQV0AQ== X-Google-Smtp-Source: ABdhPJzFrqfAwV4lIbCCiVu+IspFq83jhqoaMG65PKSTrukGguTs7XiN5FLFH6wPnByDVaUokuQk0Sd4Y5Qva95xCmU= X-Received: by 2002:a05:6402:3508:: with SMTP id b8mr934395edd.341.1611589170542; Mon, 25 Jan 2021 07:39:30 -0800 (PST) MIME-Version: 1.0 References: <20210120014333.222547-1-pasha.tatashin@soleen.com> <20210120014333.222547-9-pasha.tatashin@soleen.com> <20210120131400.GF4605@ziepe.ca> <20210125142819.GU4605@ziepe.ca> In-Reply-To: <20210125142819.GU4605@ziepe.ca> From: Pavel Tatashin Date: Mon, 25 Jan 2021 10:38:54 -0500 Message-ID: Subject: Re: [PATCH v6 08/14] mm/gup: do not migrate zero page To: Jason Gunthorpe Cc: LKML , linux-mm , Andrew Morton , Vlastimil Babka , Michal Hocko , David Hildenbrand , Oscar Salvador , Dan Williams , Sasha Levin , Tyler Hicks , Joonsoo Kim , Mike Kravetz , Steven Rostedt , Ingo Molnar , Peter Zijlstra , Mel Gorman , Matthew Wilcox , David Rientjes , John Hubbard , Linux Doc Mailing List , Ira Weiny , linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 25, 2021 at 9:28 AM Jason Gunthorpe wrote: > > On Wed, Jan 20, 2021 at 09:26:41AM -0500, Pavel Tatashin wrote: > > > I thought about this, and it would code a little cleaner. But, the > > reason I did not is because zero_page is perfectly pinnable, it is not > > pinnable only when it is in a movable zone (and it should not be in a > > movable zones for other reasons as well), but that is another bug that > > needs to be resolved, and once that bug is resolved this condition can > > be removed from gup migration. > > My point is you've defined the zero page to be pinnable no matter what > zone it is in, so is_pinnable(zero_page) == true Sure, I will move it inside is_pinnable in the next update. Thank you, Pasha > > Jason