From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF817C2BA4C for ; Wed, 26 Jan 2022 12:34:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2B1D6B0072; Wed, 26 Jan 2022 07:34:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DDAA86B0074; Wed, 26 Jan 2022 07:34:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCA286B0075; Wed, 26 Jan 2022 07:34:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0058.hostedemail.com [216.40.44.58]) by kanga.kvack.org (Postfix) with ESMTP id BDC3D6B0072 for ; Wed, 26 Jan 2022 07:34:57 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 7869F7E37F for ; Wed, 26 Jan 2022 12:34:57 +0000 (UTC) X-FDA: 79072382634.16.F14BAD8 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by imf08.hostedemail.com (Postfix) with ESMTP id 1363F16000C for ; Wed, 26 Jan 2022 12:34:56 +0000 (UTC) Received: by mail-ej1-f43.google.com with SMTP id ah7so38523529ejc.4 for ; Wed, 26 Jan 2022 04:34:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=A872bzMo6IlzyAAaWw5oHBWQXder2YytjfpeZ9XG+YI=; b=dLcrTCHgZcoiBBrgo+IT+WWZcsahinvRFDXNidl+eV1OG12bGu7I6xaNL82s+EBKv2 IJjyrcfFhuwJZ1sA/nXSwuiWMJOCMjCS9lcu2VoKXklf9VT2M+F4Jpp1XqO2KtSWLTH7 iGImzI/53J51uWCaN80T3ayPBbQdrnx4TNm/O1tlhcYRIgkQgu/mKcQ1q/79rTvobqXO gPuF2b2FHMtJqlo6/Te7Q/6c5KpP0TTrTSy2UGKP4eSupuilp3YrK07yKJmwQDnS97nQ 337HDYc8smOlARoDdWP5vb9i/MHr8SUJ0rgW9IcsGJbonEk08b6gIdGrvRrt4XZ0ae+f atrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=A872bzMo6IlzyAAaWw5oHBWQXder2YytjfpeZ9XG+YI=; b=B0mNynfN/KWUINN7pwXtVRhTk+zl0DJfdr0g9arUz/Hz7xkp0XVBnOAA3EkwLLZRZI vaJtRnbkhNWcBWBGwvCOHs4E/noXKs+SB8edF5YjXe75RYBWSpWnPjxemql4oWN4EaEy B2NiNet05SN8Y2ELN0cztcog1JKEdk5QgFqyUnq1s+pMZJKnLMshbWXRWWfvjYdax7Kq 5aN9MkvKWLwY/maMO7hKZmtj7lIzjU4Lvi/Zl/bHddiIetjnZRCr5On5WzKvOlAtRx3M Kgka7DSqiQWI4H2QSxDOJpXUV6Pi61ujg6j/pMKIbZkfkL3cEgUGMwQPVGMOufWYeeJT Q7lw== X-Gm-Message-State: AOAM533tEe7n0sHYbs+qxr2tDiQ+JdGuJUSGd5OYaFsVad5TRJaKXrJV u5VIPBALDYxo8aCF04sPy2xHC3IoiG075tDDvwRfjw== X-Google-Smtp-Source: ABdhPJzzm/M/KzGvTIlAYxOvQ2uo59zhnAsKB2J/FvNGDsr+MM678QTfLTc0An/w7tcT+GYa+/zH6vCyWLvjGDfg2kk= X-Received: by 2002:a17:907:7d8c:: with SMTP id oz12mr862732ejc.320.1643200495700; Wed, 26 Jan 2022 04:34:55 -0800 (PST) MIME-Version: 1.0 References: <20220126060514.1574935-1-pasha.tatashin@soleen.com> <20220126060514.1574935-4-pasha.tatashin@soleen.com> In-Reply-To: From: Pasha Tatashin Date: Wed, 26 Jan 2022 07:34:19 -0500 Message-ID: Subject: Re: [PATCH v3 3/4] mm/khugepaged: unify collapse pmd clear, flush and free To: David Rientjes Cc: LKML , linux-mm , Andrew Morton , Paul Turner , Wei Xu , Greg Thelen , Ingo Molnar , Will Deacon , Mike Rapoport , Dave Hansen , "H. Peter Anvin" , "Aneesh Kumar K.V" , Jiri Slaby , Muchun Song , Fusion Future , Hugh Dickins , Zi Yan , Anshuman Khandual Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 7ty8qrj886t9ob1aagbb9z86ipy9xd4q X-Rspam-User: nil Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=dLcrTCHg; spf=pass (imf08.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=none X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 1363F16000C X-HE-Tag: 1643200496-423709 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 26, 2022 at 1:34 AM David Rientjes wrote: > > On Wed, 26 Jan 2022, Pasha Tatashin wrote: > > > Unify the code that flushes, clears pmd entry, and frees the PTE table > > level into a new function collapse_and_free_pmd(). > > > > This clean-up is useful as in the next patch we will add another call to > > this function to iterate through PTE prior to freeing the level for page > > table check. > > > > Signed-off-by: Pasha Tatashin > > Acked-by: David Rientjes Thank you, David. > > One nit below. > > > --- > > mm/khugepaged.c | 32 ++++++++++++++++---------------- > > 1 file changed, 16 insertions(+), 16 deletions(-) > > > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > > index 35f14d0a00a6..440112355ffe 100644 > > --- a/mm/khugepaged.c > > +++ b/mm/khugepaged.c > > @@ -1416,6 +1416,17 @@ static int khugepaged_add_pte_mapped_thp(struct mm_struct *mm, > > return 0; > > } > > > > +static void collapse_and_free_pmd(struct mm_struct *mm, struct vm_area_struct *vma, > > + unsigned long addr, pmd_t *pmdp) > > +{ > > + spinlock_t *ptl = pmd_lock(vma->vm_mm, pmdp); > > + pmd_t pmd = pmdp_collapse_flush(vma, addr, pmdp); > > + > > + spin_unlock(ptl); > > No strong objection, but I think the typical style would be to declare the > local variables separately and avoid mixing the code, especially in cases > when taking locks (and not just initializing the local variables). I will address this in the next revision. Thank you, Pasha