From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35580C433EF for ; Thu, 30 Sep 2021 03:58:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DB6AE6187F for ; Thu, 30 Sep 2021 03:58:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DB6AE6187F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 63184940082; Wed, 29 Sep 2021 23:58:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E1C894003A; Wed, 29 Sep 2021 23:58:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CFD1940082; Wed, 29 Sep 2021 23:58:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0139.hostedemail.com [216.40.44.139]) by kanga.kvack.org (Postfix) with ESMTP id 3EBEA94003A for ; Wed, 29 Sep 2021 23:58:38 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id F28D239B21 for ; Thu, 30 Sep 2021 03:58:37 +0000 (UTC) X-FDA: 78642883074.30.56CFC14 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by imf28.hostedemail.com (Postfix) with ESMTP id C1D1E90000B2 for ; Thu, 30 Sep 2021 03:58:37 +0000 (UTC) Received: by mail-lf1-f42.google.com with SMTP id y26so19547500lfa.11 for ; Wed, 29 Sep 2021 20:58:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2l4dHoIfwgMb6BM7hfC3l0nv3vJcUx4BywuU/NezsIY=; b=ltE2JyZnf7KRkKOD6Fs0aNM4qMvhNqQXPfQZF3LT8qCz8/sWBX3WyT/o2vlb3POO5M pi4Yky+3YRwOUp+6ZKAu55hK/zR7npfVTZ/ROt4/Jh4nNYzfxPu0DH8GbK8BVVZ1k7CW QnA7KofIg5u1wSnz0EB3mPeXuZRqbjlXYtUwRsOaZIa9MsaQ433nUJ9UVHn93Rdjr+Yw XErBP7m7X0hRA3TVv6rO1ZQNHFCmP5frfJ7JMZWwRJX+/y/BvOr3iPMTMJydzlSDKXsS lNI8xVNMlPYedEmwF3DKbIxIJX28iRuugh6a8Y4Yfd+agrjqihwCzJAzXgkpSDQ+kbf/ ubNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2l4dHoIfwgMb6BM7hfC3l0nv3vJcUx4BywuU/NezsIY=; b=zMLC37zgje+v1cBx545HQSr+4R+jenBcGjT0qEdkcDU4RQWN/l+Ba46sbZfJhcAP1b sqqj5n4vds++/j3uKVadAnH/qffInM7yovMY2LbhQGHRR0idgtxHGi4L3fLflf3REV/7 oOhvLz9BtRGJXzEfG2xFRszcFevMzMhY3cRfpXbuLW2eV2x5JiFMvfFs6zxc1SXcob9c kdS12lVM2dfX8AkMrYCI8whwUiDTnzY4PMUzUI+sOp+F+ucFsYVw3M0PNR0a1rwPhYgZ MhosUpM8g6N9FfWrU2hKBuVopHwb6mG17udCXCWKjoK5//B6llftX5dMl2osQvuH7IUq L9aQ== X-Gm-Message-State: AOAM532UbDwYxcf4orXTFo5RHfb98BfFtRv+yzW8rnUHaPRxtRjFgJX5 i3sTHJC2iZ3FkMOSyonPZp4IPVEf9giEGKr2s+Uy7g== X-Google-Smtp-Source: ABdhPJxUiHZwl2ZEwrVsetpg+NGKuleqfbfAMMzrZj9iiEDLuwxZi2tNP61nwlB8/4wh0CbxcZVkvn20edtBs8IoT1k= X-Received: by 2002:a05:6512:2206:: with SMTP id h6mr3450790lfu.475.1632974316261; Wed, 29 Sep 2021 20:58:36 -0700 (PDT) MIME-Version: 1.0 References: <20210916231325.125533-1-pasha.tatashin@soleen.com> <20210916231325.125533-11-pasha.tatashin@soleen.com> <20210929124513.GD21631@willie-the-truck> In-Reply-To: <20210929124513.GD21631@willie-the-truck> From: Pasha Tatashin Date: Wed, 29 Sep 2021 23:57:59 -0400 Message-ID: Subject: Re: [PATCH v17 10/15] arm64: kexec: use ld script for relocation function To: Will Deacon Cc: James Morris , Sasha Levin , "Eric W. Biederman" , kexec mailing list , LKML , Jonathan Corbet , Catalin Marinas , Linux ARM , Marc Zyngier , James Morse , Vladimir Murzin , Matthias Brugger , linux-mm , Mark Rutland , steve.capper@arm.com, rfontana@redhat.com, Thomas Gleixner , Selin Dag , Tyler Hicks , Pingfan Liu , Andrew Morton , madvenka@linux.microsoft.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: C1D1E90000B2 X-Stat-Signature: 9tsfjg5jr3oka6izzo58mpzubd4ejpz5 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=ltE2JyZn; dmarc=none; spf=pass (imf28.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.167.42 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com X-HE-Tag: 1632974317-274593 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 29, 2021 at 8:45 AM Will Deacon wrote: > > On Thu, Sep 16, 2021 at 07:13:20PM -0400, Pasha Tatashin wrote: > > Currently, relocation code declares start and end variables > > which are used to compute its size. > > > > The better way to do this is to use ld script incited, and put relocation > > function in its own section. > > "incited"? I don't understand ... I will correct it: s/incited// > > +#ifdef CONFIG_KEXEC_CORE > > +/* kexec relocation code should fit into one KEXEC_CONTROL_PAGE_SIZE */ > > +ASSERT(__relocate_new_kernel_end - (__relocate_new_kernel_start & ~(SZ_4K - 1)) > > + <= SZ_4K, "kexec relocation code is too big or misaligned") > > +ASSERT(KEXEC_CONTROL_PAGE_SIZE >= SZ_4K, "KEXEC_CONTROL_PAGE_SIZE is brokern") > > Typo: "brokern", Will correct it. Thanks, Pasha