From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2534C48292 for ; Mon, 5 Feb 2024 18:51:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 360AA6B0075; Mon, 5 Feb 2024 13:51:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 310216B007E; Mon, 5 Feb 2024 13:51:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D85F6B0080; Mon, 5 Feb 2024 13:51:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0E6196B0075 for ; Mon, 5 Feb 2024 13:51:59 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id AA662A1FD9 for ; Mon, 5 Feb 2024 18:51:58 +0000 (UTC) X-FDA: 81758644716.06.7DDF301 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by imf15.hostedemail.com (Postfix) with ESMTP id D5655A000C for ; Mon, 5 Feb 2024 18:51:56 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none ("invalid DKIM record") header.d=soleen.com header.s=google header.b=HhvdB1YC; dmarc=none; spf=none (imf15.hostedemail.com: domain of pasha.tatashin@soleen.com has no SPF policy when checking 209.85.160.177) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707159116; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5VTygx6qb8sYZukMVdB0Zlh8j66lTNxSLNHqv5bFTEc=; b=zX9qe6sXGlZ1d8aXi7ORUeC8fGxywja77BjIKoT7s5yFbMphayObJwXofDBWsf1PAfQ2DQ dbPcJ6lrMfJ0ax68v4CB5xZHOLqUnXn8qcd2zuobg5hsnjijuSMKrbvEhavzolw1XULSi3 62YDGVWS65dVLpyFy+ADNPAN81vQV5s= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none ("invalid DKIM record") header.d=soleen.com header.s=google header.b=HhvdB1YC; dmarc=none; spf=none (imf15.hostedemail.com: domain of pasha.tatashin@soleen.com has no SPF policy when checking 209.85.160.177) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707159116; a=rsa-sha256; cv=none; b=pTtI7j084/Gxr9gj97p0vVFSAHWUM05T/KRrDAAyP8zqHWP1j8scwSQlzts1jBK6J6pJVn gSFurDrR4RR+f38XyuWe430LOqVfO1gLS832Mx7AIsjjI+IdeikUDQfp6RlzreNf8lWIV0 9IieMWMiYdjaq2k5+J/6IajW5jGlBxg= Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-429de32dad9so27184881cf.2 for ; Mon, 05 Feb 2024 10:51:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1707159116; x=1707763916; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5VTygx6qb8sYZukMVdB0Zlh8j66lTNxSLNHqv5bFTEc=; b=HhvdB1YCywbvB51k5/xNI48DO5G+VzwnKS8B7UeNZU8GB5g9YgZy89iObjLdYSUuDI Xi5UcA/tcj6TzjBrDuiI3FcYncP4GX186w33r0huXrurQ6nvuEpVkQEjtOX3VP1zfdlW jMMT3ESqtAQMa+tHvuE8DUAta9UloTlLhjV8XQ/YgEHvNAMCmbS71p/OSa/MNb/Cxvwg +QSGxis6Pk8h2/fFXT+WcRc2wpFhdeTf3veV/GRDnPjF9/HVXvj6oelpyZK/BY0tpnhF WAJzAgKHHm+Cb2xXxelOi5LCC4LmuiYe7BWIVDlL/eD7PJ9ZMoZSkRhAvdxBllgzsHc0 vj5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707159116; x=1707763916; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5VTygx6qb8sYZukMVdB0Zlh8j66lTNxSLNHqv5bFTEc=; b=YGANuPR/k5Rmq2TlOzdyE9IBrs6wXQb0UjOVSZOzLKVyX/Dz1w0xpwRWt8c5wqiS4D GDyhqjcuBNDSCgpyFGtzS0f59VrXAnYgBPYJraOZpIZqIorVRn4gCTn4xrYMVPdNcgpt auxIE7WlP6Sf2XRSVzNFPNRZrKVAEi+zxDq8je5NI98SFk44tzBXKFEkiDZXAytr0tdX VX6pMMFhA5wdvzfsoqYy1Ea1MIcjOws1umnxNuoayQ9PEnWirrM1Nf/IYwKPirsDTRAQ SIsyucKCHPGVo8xpXCvs0EiNAh8Bb+N4l4bAxBlWSIthQc7QqoUauVd1Muk2e19mkwqH Bcyg== X-Gm-Message-State: AOJu0Yy4bnDSLugs8hEXLMCbd/JoRtuTcYHgww4QLSzVZE7u8J0ZM2r4 WyPXnMRL0C1hXY3eTthn9UDrD2H32Pzh4rVl65b8eNgaOiYVNX7y5vs64l4GR8wLE1LyHWzepwT copJJiRcb+kv6Q+ZfWI4xkw7UIkMlWlHBEi6+og== X-Google-Smtp-Source: AGHT+IHCtUOUFGkzr8TaBXdeKKOZ0Xp0nyD8dcW0qlThLgsuY3VQrT8RHm+w5NKlMubnehHSEWMT8PuNkDi2wou0sNY= X-Received: by 2002:ac8:5f12:0:b0:42a:b410:fa47 with SMTP id x18-20020ac85f12000000b0042ab410fa47mr18907qta.17.1707159115882; Mon, 05 Feb 2024 10:51:55 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Pasha Tatashin Date: Mon, 5 Feb 2024 13:51:19 -0500 Message-ID: Subject: Re: [PATCH v3 1/3] iommu/iova: Tidy up iova_cache_get() failure To: Robin Murphy Cc: joro@8bytes.org, will@kernel.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, rientjes@google.com, yosryahmed@google.com, john.g.garry@oracle.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: D5655A000C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 33prw68ed3g1bsur65ssnk44pmzq9pbr X-HE-Tag: 1707159116-466866 X-HE-Meta: U2FsdGVkX19Hg1y2v8/KUjHLewdBA47SjnIP2UNWIL3wuPt0kLhmRWmrPEdnXUNdcWzo9mhjC26vi/hQ6gNv+wLLKu7CLscsjLzVHy8OSBcfKk/khUDTA9f1li/m6NU6rMfiwOkVe0r+agqVhjRGrMJXJBlg2etfQ/2Jm9IaZQ6NFCYwWU/bZMK8qGevOEThiZqR9nrLQpJkCwl2CxhSOsyEu1tor6jGpNVTmcUsBhpikQH0e+8QBAJAi1qs4ge3FNCfZBDWCdMjjbmDMSASpqraH9r0TJelRXuBkS2t3hMwQS46FiOHDNVXbeVHCfmadgC4WuG5xKoHsLjJZG51DQVgO8nisJzW/Qh+lm0zWWjzC8Pp+vTTUKa4njBbwCEybVpAGpBa+e5NLHXyGMXFBWBCtDRSHKbk2a6zA64AUJJWrUFtqfbpsrJ9BIk1m2vQJR2fJr5xCLCN8pzbnLXIrni0620Bm6p+4grmUC6VDUWifhyzLKVG9mRTZD1/TEm9F8yfbBEhJMqsgkKhOZNsustPxsM6rrudZzZE6Uo15Rk0UJ19bU2HQBd9Z9RE2UKWESINAqoK0baC7KXS2z9v/N2n4P6L31z1C5fllSzS8JUkUf3qGxA9SBok2RLVxFV12NC2/yuZ9/sl9d/snLsIEPdKWoTN4lMxv4tad6ofmqHYvDLUT7sP259Cjd6rv7QCMxiwmSDB7WrRTU7DNQSTq+XEx2cRUwaeqHupmYuWWp0WvIe4uN/EPjGbNDoguNh7eXxgGaySSA9tIG6QFhZxBX3mK/a0H6WArmqMZDdgrLq//FeF94mU0i7/tUTWeuxJTbU57SE9glm59RcYKeCzXBGFDDB3GELeL48nxI6TfeTBo3ksu4WDDYxx8NntSvmh+eee5wYwSuS9kiB2JHQjC6wRknUlZQ31XklKhO05uThUq0ad9q3+wEioDfIUMhGSMt1upw0ZSjukjVYZYTi cMDPMVbS adENEt5LvTBDXGl9Z+FlM4NYiUJpdfo8s7B4aQbtYHT81mAuVi7DSMgKzCSuSPz0JuKFJTnWzMtva1PVq6lRYha+jMN2Ct0kLq9HkFQdV3nWkKTH6Jho2XtBLOzYcPKmkZRv/Cr27JhNr5dy7WKOliMExXFNXmQ4SQmiZ2De6T4YvTmFztMR4o7wM5ek2Y3uQM44OARj273p2gAu+wLAOGdrzaoK5TPwM+tCXTuZVDbk/56Zbw9rmMiJwzaqXUKRlkBXoLy+8w0p9LZtPPSTT6oMXq0YonU1r6k1NVvceMGOTGjnxSSZfos8P1IfW+F3HgiGv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 5, 2024 at 10:32=E2=80=AFAM Robin Murphy = wrote: > > Failure handling in iova_cache_get() is a little messy, and we'd like > to add some more to it, so let's tidy up a bit first. By leaving the > hotplug handler until last we can take advantage of kmem_cache_destroy() > being NULL-safe to have a single cleanup label. We can also improve the > error reporting, noting that kmem_cache_create() already screams if it > fails, so that one is redundant. > > Signed-off-by: Robin Murphy Reviewed-by: Pasha Tatashin Thank you, Pasha