From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 121ACC433E9 for ; Thu, 3 Sep 2020 18:24:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AF1B320716 for ; Thu, 3 Sep 2020 18:24:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b="Vgjn0x5T" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF1B320716 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 496C78E0003; Thu, 3 Sep 2020 14:24:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 41FD86B0075; Thu, 3 Sep 2020 14:24:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2BFD28E0003; Thu, 3 Sep 2020 14:24:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0043.hostedemail.com [216.40.44.43]) by kanga.kvack.org (Postfix) with ESMTP id 0AD846B0074 for ; Thu, 3 Sep 2020 14:24:37 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id C323B8248068 for ; Thu, 3 Sep 2020 18:24:36 +0000 (UTC) X-FDA: 77222575752.19.jelly32_100ccaf270ab Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 87F4F1AD1B5 for ; Thu, 3 Sep 2020 18:24:36 +0000 (UTC) X-HE-Tag: jelly32_100ccaf270ab X-Filterd-Recvd-Size: 8282 Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Thu, 3 Sep 2020 18:24:36 +0000 (UTC) Received: by mail-ed1-f65.google.com with SMTP id l21so3638713eds.7 for ; Thu, 03 Sep 2020 11:24:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pYzegE1TrUesOvgJj7wxlo2/SZ1cjWBeZ/7cromDBhA=; b=Vgjn0x5T8wExJqnxkReGGH31IpzXLF6ysqaefBcSuMhV/mIdF7PRQFF/AqqPzMGOlP EzZH0fS1XK/waHqNfDMfNMDcTwMDfp+RTTU3Z/TLpMJ0rzOoCwnsAX6UYMVVSSjhqw2u FdlqQ00dFrco23zHwXpzUd1/tFhMTtV6Xr/5LCDKrbxbt8tlyy9Zwcmk/NVrj+jbGYw5 LeV/her4znhNS3ydJT2iQEcK5u03GxW8PD7miV17SGFwrz8JhEShGkZDkn+hdMYQorAu 7zjMzQC5xE8zhQxeZOwzcG41eS7HZBvZLv50TvhP9mUsRjSFwSkJUdHS+djt12oBM8Z4 jjmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pYzegE1TrUesOvgJj7wxlo2/SZ1cjWBeZ/7cromDBhA=; b=Cb+VRIhZ79FsKJNvyrCzresrucOrXwtTngd8qZimX/FRMAdyUNeiydDPUNnKpRqMHp 0Pd8kh4vwcTPIZ4qtMwJTgpHbSV0kcuEa/0IeQtYXFm5GViRNSlgwNjmnlKt+siEjpVM mmbE8oTsueRIk+BLlUzkO2AhwatBkIyasg6lPcSWxQIXjeObBiAWx29UZTH5t7SX5+XD BpwIQFqXoaCtRRiIqZIwBc/LtKCogZHi7f4my3le4Sluy8UxIswFbgnjQionGSMBOowj c/3E/cPzi/zPWi8wEmuuQbKCtKn0caQfqF+Hs0CF1qYF5HMSYfeCukKwYcM9cybfcTq6 9WLA== X-Gm-Message-State: AOAM531b7m0Hj34UU2JKgvIpyqzoZWe+Mv3YwoI1RN+7rNmnOI88frfy skTgmd+6vxywV1YyrYA6rJLYPWjKrZemVaDRmGAhTA== X-Google-Smtp-Source: ABdhPJw2cQ3MBveaBD7gbuOQHuRjWaMGjxlS/z1Wdd/NoipdoD4nd0B491pBg6dl98yFPkiu1jgocEMfy1isesqINhU= X-Received: by 2002:aa7:de91:: with SMTP id j17mr4508531edv.85.1599157474741; Thu, 03 Sep 2020 11:24:34 -0700 (PDT) MIME-Version: 1.0 References: <20200901124615.137200-1-pasha.tatashin@soleen.com> <20200902140851.GJ4617@dhcp22.suse.cz> <74f2341a-7834-3e37-0346-7fbc48d74df3@suse.cz> <20200902151306.GL4617@dhcp22.suse.cz> <20200903063806.GM4617@dhcp22.suse.cz> In-Reply-To: From: Pavel Tatashin Date: Thu, 3 Sep 2020 14:23:58 -0400 Message-ID: Subject: Re: [PATCH] mm/memory_hotplug: drain per-cpu pages again during memory offline To: David Hildenbrand Cc: Michal Hocko , Vlastimil Babka , LKML , Andrew Morton , linux-mm Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 87F4F1AD1B5 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 3, 2020 at 2:20 PM David Hildenbrand wrote: > > On 03.09.20 08:38, Michal Hocko wrote: > > On Wed 02-09-20 19:51:45, Vlastimil Babka wrote: > >> On 9/2/20 5:13 PM, Michal Hocko wrote: > >>> On Wed 02-09-20 16:55:05, Vlastimil Babka wrote: > >>>> On 9/2/20 4:26 PM, Pavel Tatashin wrote: > >>>>> On Wed, Sep 2, 2020 at 10:08 AM Michal Hocko wrote: > >>>>>> > >>>>>>> > >>>>>>> Thread#1 - continue > >>>>>>> free_unref_page_commit > >>>>>>> migratetype = get_pcppage_migratetype(page); > >>>>>>> // get old migration type > >>>>>>> list_add(&page->lru, &pcp->lists[migratetype]); > >>>>>>> // add new page to already drained pcp list > >>>>>>> > >>>>>>> Thread#2 > >>>>>>> Never drains pcp again, and therefore gets stuck in the loop. > >>>>>>> > >>>>>>> The fix is to try to drain per-cpu lists again after > >>>>>>> check_pages_isolated_cb() fails. > >>>>>> > >>>>>> But this means that the page is not isolated and so it could be reused > >>>>>> for something else. No? > >>>>> > >>>>> The page is in a movable zone, has zero references, and the section is > >>>>> isolated (i.e. set_pageblock_migratetype(page, MIGRATE_ISOLATE);) is > >>>>> set. The page should be offlinable, but it is lost in a pcp list as > >>>>> that list is never drained again after the first failure to migrate > >>>>> all pages in the range. > >>>> > >>>> Yeah. To answer Michal's "it could be reused for something else" - yes, somebody > >>>> could allocate it from the pcplist before we do the extra drain. But then it > >>>> becomes "visible again" and the loop in __offline_pages() should catch it by > >>>> scan_movable_pages() - do_migrate_range(). And this time the pageblock is > >>>> already marked as isolated, so the page (freed by migration) won't end up on the > >>>> pcplist again. > >>> > >>> So the page block is marked MIGRATE_ISOLATE but the allocation itself > >>> could be used for non migrateable objects. Or does anything prevent that > >>> from happening? > >> > >> In a movable zone, the allocation should not be used for non migrateable > >> objects. E.g. if the zone was not ZONE_MOVABLE, the offlining could fail > >> regardless of this race (analogically for migrating away from CMA pageblocks). > >> > >>> We really do depend on isolation to not allow reuse when offlining. > >> > >> This is not really different than if the page on pcplist was allocated just a > >> moment before the offlining, thus isolation started. We ultimately rely on being > >> able to migrate any allocated pages away during the isolation. This "freeing to > >> pcplists" race doesn't fundamentally change anything in this regard. We just > >> have to guarantee that pages on pcplists will be eventually flushed, to make > >> forward progress, and there was a bug in this aspect. > > > > You are right. I managed to confuse myself yesterday. The race is > > impossible for !ZONE_MOVABLE because we do PageBuddy check there. And on > > the movable zone we are not losing the migrateability property. > > > > Pavel I think this will be a useful information to add to the changelog. > > We should also document this in the code to prevent from further > > confusion. I would suggest something like the following: > > > > diff --git a/mm/page_isolation.c b/mm/page_isolation.c > > index 242c03121d73..56d4892bceb8 100644 > > --- a/mm/page_isolation.c > > +++ b/mm/page_isolation.c > > @@ -170,6 +170,14 @@ __first_valid_page(unsigned long pfn, unsigned long nr_pages) > > * pageblocks we may have modified and return -EBUSY to caller. This > > * prevents two threads from simultaneously working on overlapping ranges. > > * > > + * Please note that there is no strong synchronization with the page allocator > > + * either. Pages might be freed while their page blocks are marked ISOLATED. > > + * In some cases pages might still end up on pcp lists and that would allow > > + * for their allocation even when they are in fact isolated already. Depending on > > + * how strong of a guarantee the caller needs drain_all_pages might be needed > > + * (e.g. __offline_pages will need to call it after check for isolated range for > > + * a next retry). > > + * > > As expressed in reply to v2, I dislike this hack. There is strong > synchronization, just PCP is special. Allocating from MIGRATE_ISOLATE is > just plain ugly. > > Can't we temporarily disable PCP (while some pageblock in the zone is > isolated, which we know e.g., due to the counter), so no new pages get > put into PCP lists after draining, and re-enable after no pageblocks are > isolated again? We keep draining the PCP, so it doesn't seem to be of a > lot of use during that period, no? It's a performance hit already. > > Then, we would only need exactly one drain. And we would only have to > check on the free path whether PCP is temporarily disabled. Hm, we could use a static branches to disable it, that would keep release code just as fast, but I am worried it will make code even uglier. Let's see what others in this thread think about this idea. Thank you, Pasha