linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Pasha Tatashin <pasha.tatashin@soleen.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Mike Rapoport <rppt@kernel.org>,
	llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
	 Linux Memory Management List <linux-mm@kvack.org>,
	kernel test robot <lkp@intel.com>
Subject: Re: [linux-next:master 4972/5926] kernel/kexec_handover_debug.c:16:18: error: use of undeclared identifier 'kho_scratch_cnt'
Date: Tue, 4 Nov 2025 18:12:24 -0500	[thread overview]
Message-ID: <CA+CK2bBJRXX5u9sCkG+WKW_OK1biyBUfdcJ73yuUdeNv6QevbQ@mail.gmail.com> (raw)
In-Reply-To: <20251104141501.48a1f76a3f83967f08d00097@linux-foundation.org>

On Tue, Nov 4, 2025 at 5:15 PM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Tue, 4 Nov 2025 12:50:49 -0500 Pasha Tatashin <pasha.tatashin@soleen.com> wrote:
>
> > The fix looks like this:
> > diff --git a/kernel/kexec_handover.c b/kernel/kexec_handover.c
> > index de4466b47455..2a8c20c238a8 100644
> > --- a/kernel/kexec_handover.c
> > +++ b/kernel/kexec_handover.c
> > @@ -477,8 +477,8 @@ static void __init kho_mem_deserialize(const void *fdt)
> >   * area for early allocations that happen before page allocator is
> >   * initialized.
> >   */
> > -static struct kho_scratch *kho_scratch;
> > -static unsigned int kho_scratch_cnt;
> > +struct kho_scratch *kho_scratch;
> > +unsigned int kho_scratch_cnt;
>
> This patch is making changes which are already present.
>
> > --- a/kernel/kexec_handover_internal.h
> > +++ b/kernel/kexec_handover_internal.h
>
> Against files which were moved to kernel/liveupdate/!
>
> > Andrew, Mike, do you want me to resend the "[PATCH v3 0/3] KHO: kfence
> > + KHO memory corruption fix" series with the fix included?
>
> A little fix against what's presently in mm.git would be great, please.

Hi Andrew,

This is because in mm.git you have patches that move kexec_handover*
to kernel/liveupdate/ (and they fix this build problem), but
linux-next does not have these patches. The patch I sent is a fixup
for  "kho: warn and fail on metadata or preserved memory in scratch
area" patch.


  reply	other threads:[~2025-11-04 23:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-04 14:48 kernel test robot
2025-11-04 15:38 ` Mike Rapoport
2025-11-04 17:32   ` Pasha Tatashin
2025-11-04 17:50     ` Pasha Tatashin
2025-11-04 22:15       ` Andrew Morton
2025-11-04 23:12         ` Pasha Tatashin [this message]
2025-11-04 23:54           ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+CK2bBJRXX5u9sCkG+WKW_OK1biyBUfdcJ73yuUdeNv6QevbQ@mail.gmail.com \
    --to=pasha.tatashin@soleen.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    --cc=llvm@lists.linux.dev \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=rppt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox