From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50AFCC46CD3 for ; Tue, 26 Dec 2023 17:15:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BFE496B0072; Tue, 26 Dec 2023 12:15:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BAE696B0074; Tue, 26 Dec 2023 12:15:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A761E6B0075; Tue, 26 Dec 2023 12:15:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 97DB56B0072 for ; Tue, 26 Dec 2023 12:15:15 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5EE7B1205C9 for ; Tue, 26 Dec 2023 17:15:15 +0000 (UTC) X-FDA: 81609620190.17.A911389 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by imf08.hostedemail.com (Postfix) with ESMTP id 6D2A3160011 for ; Tue, 26 Dec 2023 17:15:13 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=TEKBjghh; spf=pass (imf08.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703610913; a=rsa-sha256; cv=none; b=dHi2b4IBRArkGFhMk8UeL3+2PdRvCfDjK6cbHiAOM9INh9mV3CmwiVcnGhKY4ZF/TVKlNC Nz0t6l4iHFhFIlJFKf1Sw5rVz8KeuO6VaCvUvc2h/x6SXmbge2GZ2CGr43N+ajWNTnNMGP Dj4l0MuqdbwRb9pPXgjB3YIeIbZ0s+c= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=TEKBjghh; spf=pass (imf08.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703610913; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=znBescOeGDyEd/eBwZlWM7zCSH3WtYT9hTuxQY/0ciQ=; b=xXO4Cl12/ym+rcfUvlrCm9Zwo+Z8IutxFXBX3cV/WKFsT8tuOQg1RgAfG8nvz2w+sxaP1B ehLgoYMA0bqTocpyvC1rLwuTOV/F/PnZ1A4wTzMeQRWtulXJOJcdqaXGAkISOIGLBUFQDV YRp30ed8A+tQSlbmO3A/jieZ0GOCEII= Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-427e8bb6778so872271cf.3 for ; Tue, 26 Dec 2023 09:15:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1703610912; x=1704215712; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=znBescOeGDyEd/eBwZlWM7zCSH3WtYT9hTuxQY/0ciQ=; b=TEKBjghhWFn/CPhiFOHnzoWwOD7m25BPQQzhM0N+KZNI1Uk/AKgve9XHFrDuD19vgz sNOSmGCcmcQpcf3XlKVWcX9XkwC5eACyvqSAcEenqetlXMSWcDoew9paggCt5ltnK37U GOYtQFOVg4f+I9FgNdd6t7kNPKbq4w9IK/yGyLmveatp0BRLxBqR52yJjXfLTYMap34i PNQV93XNlFdgeH5/e6bSRyaxeEyYXIOlhJfBrlPGUVPprN/Eeh7C1hlejUQfVaknoA/X EPKM6DILtpfz7iZZGUVj3rn/QwrN7AI0yt5ewduqWxmrgt3oG7pvCQvhveGOjBxviKS7 YAcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703610912; x=1704215712; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=znBescOeGDyEd/eBwZlWM7zCSH3WtYT9hTuxQY/0ciQ=; b=AqdLfqev8/ZhU+s5AuFVisW/4jYKnF3mLb7rwCwGTE8XsRdRv2WyJiY3H785G9B4lh ALArvsYoqsqbIjqQFnNj1gaq3n9OPWSxwX5wIOYjrpETYd55macz3YQ1s65VpXnzvCxX E4VMWD8iwi0obMm6ga7V1CulW6adgXsq2fI4SyoDYGPHzUIAIX084RlF4XElVxeBqmpG q0WS+HwcfYJwo3tOnPSVG7biPjZLewPf/yhQ4rSRhx6GdEJ3cX6VMSgqIpcK1Vh9H135 amGAK8nfCq2y5t6J95Zp20D5QixhKEiAM03Ja0OhySckymsN58KOyVbp+yNectGbq2Km jeXg== X-Gm-Message-State: AOJu0YwRCeIT1qcMjKMV+v3F7d75ge5cvksAsyl288DnWMCNqNLdg433 jwxPHSDAs296mxpEyqoXVu4GLOvDF2EwOXoA0usIIaxdUYugpA== X-Google-Smtp-Source: AGHT+IHyQ5pm+vKsp8dlt+xdHnTW6C3uPhOZpDSwoY++VClJ/nDwEbMxRN02tbeUhgBwD4pSJVi4TOSqszJhqwYmmj4= X-Received: by 2002:ac8:5bc2:0:b0:425:a28f:ddd8 with SMTP id b2-20020ac85bc2000000b00425a28fddd8mr8563250qtb.137.1703610912560; Tue, 26 Dec 2023 09:15:12 -0800 (PST) MIME-Version: 1.0 References: <20231130201504.2322355-1-pasha.tatashin@soleen.com> <20231130201504.2322355-2-pasha.tatashin@soleen.com> <776e17af-ae25-16a0-f443-66f3972b00c0@google.com> <0ba8e579-2b6f-4e9f-a38c-097694f14d3c@intel.com> In-Reply-To: <0ba8e579-2b6f-4e9f-a38c-097694f14d3c@intel.com> From: Pasha Tatashin Date: Tue, 26 Dec 2023 12:14:35 -0500 Message-ID: Subject: Re: [PATCH v2 01/10] iommu/vt-d: add wrapper functions for page allocations To: "Liu, Jingqi" Cc: David Rientjes , Andrew Morton , alim.akhtar@samsung.com, alyssa@rosenzweig.io, asahi@lists.linux.dev, baolu.lu@linux.intel.com, bhelgaas@google.com, cgroups@vger.kernel.org, corbet@lwn.net, david@redhat.com, dwmw2@infradead.org, hannes@cmpxchg.org, heiko@sntech.de, iommu@lists.linux.dev, jernej.skrabec@gmail.com, jonathanh@nvidia.com, joro@8bytes.org, krzysztof.kozlowski@linaro.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, lizefan.x@bytedance.com, marcan@marcan.st, mhiramat@kernel.org, m.szyprowski@samsung.com, paulmck@kernel.org, rdunlap@infradead.org, robin.murphy@arm.com, samuel@sholland.org, suravee.suthikulpanit@amd.com, sven@svenpeter.dev, thierry.reding@gmail.com, tj@kernel.org, tomas.mudrunka@gmail.com, vdumpa@nvidia.com, wens@csie.org, will@kernel.org, yu-cheng.yu@intel.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 6D2A3160011 X-Stat-Signature: z6imj5c34dur1h54fx534gzoy15ibs1h X-Rspam-User: X-HE-Tag: 1703610913-901802 X-HE-Meta: U2FsdGVkX18f/fC27oixKok5UY9n+yiDJK/9wvtfl0uSBODz5o6zMIA355K17R8X1mTAqJFfWAT0FAFjGnTzW+XNFPPDC+rugt/zU+Fy3oX6d7m29Kq/B6IDCDyxdp01lRasYwAlWxbEZROm1eEKEvRaKANmoJHqZ5vwn3aVjwrdWhbYc3ptADOVPL+crqJ2hXkZT6qmo3m+DmYnSCZ1nmztgENqiBsEL3Qm1Ts8XF7S3JfVkJZndH4J3s+O8kkFPqeQ5pMYGzh9XjEyZQgWJGM37hM3bVAkJgkfv6e075fDUxPWfknuaTSVhcQwsY76uS6pOkUINXKmAQcNJ5E6f6KCKU0MMXR7OjmJJk/UmCJo90GxWZRPpsGbYxUXgg7Jdwi3A9Iujlj+wng5QnOBWTeAhD/aZA/8jQGUgVFB+5s748ZuycnXs3HEMsDNh6LsyzA6ntj9a62oRERNhFs/Uzd2qgGC3oqepIIdbx3a7T6cEpGVtXUCW82uQT2/dhQwgQ9FU1VA84iTGDzo0yPSAzVOANktgG8ypq5H3PYS+lTSEWTcyBXUHpSw8xYTLjo54Hb1yPPqFk4NIIo04IiyIjbcTxUuWFqCU5n5P3VMPVlmsDdHD4CW7aC3rqDWJgOto4D40IlWANO/BjxlQ/lZ5fDr4C6BbveMWmaZy+WeDjmO53zwwuxBKzTNDNKoVbUlBskgbSJF3FGQPEl5Bppc7uJjpB7v1AiCUaQ3z5QLS1pCRw1ZAXogD4fszPwJTLPGOOLIGin+xXU7Ch9ByFYrAHkz35iEB0/xtacKxpBSq6qL5UqtMzDNC374tFBxCTYrLLY2/fxwyYJj28DHnfn0d7GgiEcqcFMW3v4F8gFfv9WGEN9H2wIJTgKlpWWsRvyAEQY2yF0s0bfPkq1Ro3VvcS59r7T/RKmnhVuQ8HufaORgBqX3GwMliKvTUlttjYbx88wy9/gEy09tfHRERQO ovQAzOJJ j/ANMGrlItdhaTijhTcqgkS4bkqmrq4OtvVMg77PO1T20jq3+zXLGtSBhSogXKg9kb2r8nR2CK6PmVa2AfeLB3r87je1zHrz92kBRx1ytVDbJNgSlSouy/Jcyop8zR1jNuIYcdruayhdBHxAKf10WtByNte1P62koHNdExqqodMICYHRzbsjH26W28RluziXBE1MKCrGwFjb3o2yPrQgwEBLeHUdgAGImzOQCFSVd3oepXyMhur5LekUvoGAJ4sqf8Qj1BfPqU8i4vt0ZYNcm+kltqL+JAEXs8xQgKuUv1DfdCWg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > >> Document the locking requirements for this? > > > > Thank you for the review. I will add info about locking requirements, > > in fact they are very relaxed. > > > > These pages are added to the list by unmaps or remaps operation in > > Intel IOMMU implementation. These calls assume that whoever is doing > > those operations has exclusive access to the VA range in the page > > table of that operation. The pages in this freelist only belong to the > > former page-tables from the IOVA range for those operations. > > These pages maybe be accessed concurrently by thread contexts other than > the IOMMU driver (such as debugfs). Good point regarding debugfs. While, it does not change any locking assumptions, for this series. It might change some design decisions that we need to make when freeing pages on unmaps (a separate RFC series that I sent). I will have to study how debugfs affect refcnt and mapcount, and whether we could use per-page page table locking if needed. Thanks, Pasha