From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFE55D711D2 for ; Wed, 20 Nov 2024 17:47:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1895A6B0083; Wed, 20 Nov 2024 12:47:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 139BF6B009C; Wed, 20 Nov 2024 12:47:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1B506B00A0; Wed, 20 Nov 2024 12:47:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D375D6B0083 for ; Wed, 20 Nov 2024 12:47:37 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8BDD31A0EF9 for ; Wed, 20 Nov 2024 17:47:37 +0000 (UTC) X-FDA: 82807203738.06.C17C483 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by imf17.hostedemail.com (Postfix) with ESMTP id 034F740008 for ; Wed, 20 Nov 2024 17:46:55 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=bmvOaG7O; spf=pass (imf17.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.181 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=pass (policy=none) header.from=soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732124763; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UaFYnoy6vIIc+NNFw3dXMBs61SIsGb7xxVzTfcYyYis=; b=qo5aGujmPLd3BQNvKHCvQnoz8inuJZh6TWeAPqqRkgZJ87DcCi2KLTN5xkNmhkjkAxWalH cVRmBmUNoH8baupAnpZm+CiLyblNwrkfdBqOt7szAepdLeXHU23vUmzF4po+tAfyvzd8IE GAPlbtOliyM6oTCIoLcq9KAVku9fwT0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732124763; a=rsa-sha256; cv=none; b=No4SWGldk2OeAb4maIg/QWMONm/uYlA39HKr349mO5ZyrDAgC337DF5mmY/b4qKa2zn2mp R9nkmEnNt9hIn4wy/91gcvz5WXhr7uUn12Dnq5TBF2RJ4g0UG8tLZEbUN7dZVOml7hVrs4 1potta9+N70ptPsE6TOXGXXd9TrvYWg= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=bmvOaG7O; spf=pass (imf17.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.181 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=pass (policy=none) header.from=soleen.com Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-4609e784352so264631cf.0 for ; Wed, 20 Nov 2024 09:47:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen-com.20230601.gappssmtp.com; s=20230601; t=1732124855; x=1732729655; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=UaFYnoy6vIIc+NNFw3dXMBs61SIsGb7xxVzTfcYyYis=; b=bmvOaG7OBkKxhkkAqjlqcfSGx0RIzZa2HiJ2Ns/3NmTAlxx1q43hKQ/ybVluFvo0aH sFfxPqtX0c2XD9VFJu/GCAMEZ32sirRPbtO7fY+0z8b7z6SKV64jnAF9efL6goJPzmOv fhqJgzZeDBwrV9mCidjvzsVhnztOHhH1v+Kti7j/Of3Iep/vWtiWCSobUezbzBe/ukEc 2rJ+DbPnp2lJZupL8T7hzH8oDKCtoXl6tdhl/J4OJudA5fACW3c7IP0rzeJpHzrugzEh ZiEqnS2Gqqw0ybpHRwR7W7AR4PBPHgAq6HR7XrcVu6YDywo+Pb+dG75qs6UiBBnjNwDg Fcgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732124855; x=1732729655; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UaFYnoy6vIIc+NNFw3dXMBs61SIsGb7xxVzTfcYyYis=; b=XQlgmZjK7y/AjCTnL1hmrsm/n/GCpXNPLYCEipe2N3hJwFMG0cEj34BQYqMQSnU5ER UnPIiToW+DLuhykbB4L6gTr1d6YqXzizCtJFYMP84SX3WbVnUrPTKyGXEDlJNnV2j19k rRR3bg6OIA2vokKU3Imk9Ott2fgHTQ+D5p2TzqoY7KheU3E2AA3CCTGkRj06vwpAW+7J wnRAvywtQ9fiCJ4HAAw2UKw5hfAceCPR9jkU3vd2lJ4tR/cYewxRfzmdN1CGCFl8/5KN 3G7jsGmjCGXyA9DTjFveQVuKMRr3ndAqUYMOQdjDViInp8J+VM3TYPCxliL+KCCJxdk8 z43g== X-Forwarded-Encrypted: i=1; AJvYcCVzPJ/J24wwdIC0O34eI++3M4r4DVqxR+v18RzQjKows1oA6VZ0n6HRAVArI3GirTQ2F/g1F/vS3Q==@kvack.org X-Gm-Message-State: AOJu0Yws1CO34O3xWnCjMIetp5kK0ELQErhCnTOWdkIc8t6iRhvoXxAK NSNjoORhI+y1TD30BWGEgJy7rY4tqJf4NOTivCA/al6aPkg9uYfw9S6ahR440X6XyRBtpuTpYDB pkiZugOEmSZjDyE9dqt3rm+EccLEt301NkkF6zw== X-Google-Smtp-Source: AGHT+IETZYeQkb0s7u5Wf9yV4Cku4EiSNu5qCpIOez8ZpXMAHom6F/sK07PgTzdhYiGYrI8j7GVXlIMLnKbJrLP6RZU= X-Received: by 2002:a05:622a:2d5:b0:460:ebb5:5fe5 with SMTP id d75a77b69052e-464782a740bmr36717931cf.10.1732124854779; Wed, 20 Nov 2024 09:47:34 -0800 (PST) MIME-Version: 1.0 References: <20241116175922.3265872-1-pasha.tatashin@soleen.com> <2024111938-anointer-kooky-d4f9@gregkh> In-Reply-To: From: Pasha Tatashin Date: Wed, 20 Nov 2024 12:46:57 -0500 Message-ID: Subject: Re: [RFCv1 0/6] Page Detective To: Yosry Ahmed Cc: Roman Gushchin , Greg KH , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org, linux-kselftest@vger.kernel.org, akpm@linux-foundation.org, corbet@lwn.net, derek.kiernan@amd.com, dragan.cvetic@amd.com, arnd@arndb.de, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, tj@kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, shakeel.butt@linux.dev, muchun.song@linux.dev, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, shuah@kernel.org, vegard.nossum@oracle.com, vattunuru@marvell.com, schalla@marvell.com, david@redhat.com, willy@infradead.org, osalvador@suse.de, usama.anjum@collabora.com, andrii@kernel.org, ryan.roberts@arm.com, peterx@redhat.com, oleg@redhat.com, tandersen@netflix.com, rientjes@google.com, gthelen@google.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam10 X-Stat-Signature: 94zwt8e44c9toiqwrkoopqzgtdgsf1oh X-Rspamd-Queue-Id: 034F740008 X-Rspam-User: X-HE-Tag: 1732124815-936237 X-HE-Meta: U2FsdGVkX18ILKkHCfV8QtF7sTNEIyGqwRmAcwfJ0jm5LjIWVueUdu7sjVS+4v2SI2+jivB5i5209VGt8C9jUUnAVvDckQhflSSUCvRA6+qNyjoGETuHZWLFT6Kq1KlwFe2ZiCN00S8576jJh6F14FSawc7qhHHVCS9T6DKHWqy8q60bzvZXQUNRpRs3F/RCIiUS3TwoOggycpcRVzzWfkcvvjV+83NBscut85oYubXycW6UO6ydezfaWA6u4TXU78qGrMhqW5EU6+TlDs+IUodoc61PVh4Zm2f8MN2UKU4HZZtA4N1vkksy7ZnKruxWj4RW2e6ntMt2S+GUk8g9OD4fgFcuU0SJq+Nm0JSHLtREh5YDj5EP9BhXumW/Q9rhK0v2wSdv6AsZ8aXnp0YnnwvzmIy7LvnaIoK87iLKEopvwx7LbR59KbASJ+czp+FaCEyAVomE2OlTwvbyL09S76T2/VZ6VegZAsosJrnLNq44uafO/UpemC0OB5Z4Yl0AKZAuEX5UfNIRg4WMfLEFY0biBdhGNoGrKhhei439JBH82oG7Jz6n5n4UzFZkbG7HH1bKuhBUJUPL9QDL/EBgh4FeshlLsK8kq5sGGujmRtmm2DIHa/Jqj4hdJlx85jP/tMmjAbD2WCKAQnFi2kb0VSNouU4QLd0o0O4UIqc1LnEo+USB/wxclILYJEGeXyfEugYfXejA+UyEa/pqaAUm974auSQ0RAvDACvcF0elB0UBK1ooTdo4ZCqHhP5qFmSq/QQ22V/zxpKsgoVmj41MWTtv8/Zg3DEHD+uMk4HOONbeG1xhrRYgpTG/04jEEhkHJlDP3gMAaPuTNunbKyrcky3xqkKnFUZKD3PzsplDDBhZhqTvCM2Fk8cWf9OfWGAeewrcKMEPByHbqck6Kgd60+aHIDWNdRyVyfGvg5CP2AB2YHmO/1FvE9zaTteUMuFZiZDRRlWYO+idd9dFIGk QVd/+PDr crlrk9fIDwRy9giQnBGeoN6fs4qkFuP1pZpZ+1REVa9pN0MvGV48cloAiUQjouxz6aIXwio2oWhzsUayHLeGoJ/J9Y//zODo7DbSNxASlWCexDjIasV3bB85jg7SGT/uTHx+O6RXglDtdjPFfk5JxrJQmJkfGV/E5jOqRN0Y3RwtBDpPBgdbwblOkTPIRVVyBXkQzSy1klogmh8hJ6VGvj2cnDzOZIbKcoHSkXMeCF1WCeSBz0Ynk/XSyr695XeSZpodS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > /* Use static buffer, for the caller is holding oom_lock. */ > > static char buf[PAGE_SIZE]; > > .... > > seq_buf_init(&s, buf, sizeof(buf)); > > memory_stat_format(memcg, &s); > > seq_buf_do_printk(&s, KERN_INFO); > > } > > > > This is a callosal stack allocation, given that our fleet only has 8K > > stacks. :-) > > That's a static allocation though :) Ah right, did not notice it was static (and ignored the comment) Pasha