From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 246C5C433ED for ; Thu, 1 Apr 2021 14:27:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 80A4B61358 for ; Thu, 1 Apr 2021 14:27:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 80A4B61358 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E5FB96B0072; Thu, 1 Apr 2021 10:27:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E0FE46B0073; Thu, 1 Apr 2021 10:27:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB03C6B0075; Thu, 1 Apr 2021 10:27:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0004.hostedemail.com [216.40.44.4]) by kanga.kvack.org (Postfix) with ESMTP id AAB976B0072 for ; Thu, 1 Apr 2021 10:27:14 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 569BD182F45FF for ; Thu, 1 Apr 2021 14:27:14 +0000 (UTC) X-FDA: 77984025588.02.29553AB Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf10.hostedemail.com (Postfix) with ESMTP id B56C040002D6 for ; Thu, 1 Apr 2021 14:27:12 +0000 (UTC) Received: by mail-ej1-f48.google.com with SMTP id kt15so3144548ejb.12 for ; Thu, 01 Apr 2021 07:27:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=gnafp+WfprUSUoacKsjOwRBf+VXemWu2ScVTthleKlo=; b=LR9XnNbOVyRPM9uKaP6OkP5ztLHdsLIUBWS4FM+sG9YdiylPaqUwHU2zcckCIWYAuC pVQELYHpOXc3KbZv6GWHjkCEMK5JUnMCn6c2nyfkEEsEPD4uF26vTxlBcymQ+LwNhwSG q9LPyUi6XNTevS25W7v8FHeNEflOdOKU2WNxKflu8yFGGsqfBvuTS+jgvVYP/Vzjxe4u jNkzw7/KW9GUd/dbUc1vE+v0hN7VS3qIH7wv5H/fh6ISSHjvm4X1oBrzpSmgL5KYEsTj bdY594j9g3m+Gu30WhwxJMnF82UW2g1c0sudNTMYGUqUmsN+pd9jox3SBQm7I//jKSlp Q6Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=gnafp+WfprUSUoacKsjOwRBf+VXemWu2ScVTthleKlo=; b=VpUba8TolfbA71kJ0z3lVBC2KwzvXOL54XeUHDgV8/4Gg7kP4socemeDj5ItvIKfW4 DQuu9/Inosg7sYrS3r7p89uM36VOXz7VbIaNxijM0rF/mYNo0VNn3KD7AfwsA7XoBI8a l36ZxsG8GTaaWngjudZ8wQRbfrHcFq1O83aUmjxZcuw5g2QWEpx/yemPAyZFkS/2E4NG q8dO1EBHerpD6Z4hOb07vMqZCqy/ruw6CmRtmIq6Q/MAdH+9KPvasxUlf5iupwTz9TyQ 4BsNZj2ogChkhfbDjzeN+laV8Ag5GlUFu76VWO098bqdq49B4XcxQDQpdi4kxzBAaki5 uBpw== X-Gm-Message-State: AOAM532AmlL6G8VTr9cG4lwUtKHesky0hMCCEktLNgRYyWC+Mh+ciOzb eyLYdcnq96SEpN7dcg3tgkA9Tt1e75IQPRCY5GmorQ== X-Google-Smtp-Source: ABdhPJxskqrkU+/Bun8iluS9RzTTCb312PP/YzPq0j1Ynfozeu/uQ5PJ0jJtaZQhzko8nZjTMM9sCROJMFZvlGqDETY= X-Received: by 2002:a17:906:4ada:: with SMTP id u26mr9365566ejt.129.1617287232520; Thu, 01 Apr 2021 07:27:12 -0700 (PDT) MIME-Version: 1.0 References: <20210331163816.11517-1-rppt@kernel.org> In-Reply-To: <20210331163816.11517-1-rppt@kernel.org> From: Pavel Tatashin Date: Thu, 1 Apr 2021 10:26:36 -0400 Message-ID: Subject: Re: [PATCH] mm/hugeltb: fix renaming of PF_MEMALLOC_NOCMA to PF_MEMALLOC_PIN To: Mike Rapoport Cc: Andrew Morton , Mike Kravetz , Mike Rapoport , linux-mm , LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: B56C040002D6 X-Stat-Signature: qnf8sfxudduxc3nz1obqdumsiheoab8x Received-SPF: none (soleen.com>: No applicable sender policy available) receiver=imf10; identity=mailfrom; envelope-from=""; helo=mail-ej1-f48.google.com; client-ip=209.85.218.48 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617287232-727998 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 31, 2021 at 12:38 PM Mike Rapoport wrote: > > From: Mike Rapoport > > The renaming of PF_MEMALLOC_NOCMA to PF_MEMALLOC_PIN missed one occurrenc= e > in mm/hugetlb.c which causes build error: > > CC mm/hugetlb.o > mm/hugetlb.c: In function =E2=80=98dequeue_huge_page_node_exact=E2=80=99: > mm/hugetlb.c:1081:33: error: =E2=80=98PF_MEMALLOC_NOCMA=E2=80=99 undeclar= ed (first use in this function); did you mean =E2=80=98PF_MEMALLOC_NOFS=E2= =80=99? > bool pin =3D !!(current->flags & PF_MEMALLOC_NOCMA); > ^~~~~~~~~~~~~~~~~ > PF_MEMALLOC_NOFS > mm/hugetlb.c:1081:33: note: each undeclared identifier is reported only o= nce for each function it appears in > scripts/Makefile.build:273: recipe for target 'mm/hugetlb.o' failed > make[2]: *** [mm/hugetlb.o] Error 1 > > Signed-off-by: Mike Rapoport > --- > mm/hugetlb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index a5236c2f7bb2..c22111f3da20 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -1078,7 +1078,7 @@ static void enqueue_huge_page(struct hstate *h, str= uct page *page) > static struct page *dequeue_huge_page_node_exact(struct hstate *h, int n= id) > { > struct page *page; > - bool pin =3D !!(current->flags & PF_MEMALLOC_NOCMA); > + bool pin =3D !!(current->flags & PF_MEMALLOC_PIN); Thank you Mike! Andrew, since "mm cma: rename PF_MEMALLOC_NOCMA to PF_MEMALLOC_PIN" is not yet in the mainline, should I send a new version of this patch so we won't have bisecting problems in the future? Thank you, Pasha