From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C6D3C433E7 for ; Wed, 2 Sep 2020 12:35:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B648420767 for ; Wed, 2 Sep 2020 12:35:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b="SX43yO/l" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B648420767 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5BA196B0072; Wed, 2 Sep 2020 08:35:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 543756B0074; Wed, 2 Sep 2020 08:35:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 40B466B0075; Wed, 2 Sep 2020 08:35:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0001.hostedemail.com [216.40.44.1]) by kanga.kvack.org (Postfix) with ESMTP id 24CA56B0072 for ; Wed, 2 Sep 2020 08:35:12 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id DF9F0181AEF0B for ; Wed, 2 Sep 2020 12:35:11 +0000 (UTC) X-FDA: 77218066422.13.bread76_0b0612e270a1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id AAB2A18140B69 for ; Wed, 2 Sep 2020 12:35:11 +0000 (UTC) X-HE-Tag: bread76_0b0612e270a1 X-Filterd-Recvd-Size: 4112 Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Wed, 2 Sep 2020 12:35:11 +0000 (UTC) Received: by mail-ed1-f66.google.com with SMTP id ay8so4725701edb.8 for ; Wed, 02 Sep 2020 05:35:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=X4rF/yq5M8ifTAczaYaXvE/5Rh0KHOWFFE/+jNdXZrs=; b=SX43yO/lEpB+wj0mnfbD4nBzXL8bX3IZcPZnzMlnu3ip23vQ2I8ocHqN1f9i8/4tDI bGLkc0pEP1LTiWJiGYvj77n/Nb5hpc167l+QaiVDmlebzyHAvB+iJP1U58CF5gK+hrrF z1jDRw6vgfAdo1jOY8vW9v9NPpTUaLTd7pN2/s6j7SLqc17yJLr1l6EgSo80rhZOxkoP DrcRcsL0FHNKw9gqxeFj53SeErvNxsq6y9htoAWg19HX8jFTb4PbfsE8Hoi0/Whq5cLW A3omfeeb54TcWf1YbK22kl3lFx1mQbDvMW6wjZ2Ve4mGNmuwqllqkeMnAQQzn/b8R6qK H8dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X4rF/yq5M8ifTAczaYaXvE/5Rh0KHOWFFE/+jNdXZrs=; b=b46vc+55xaH2JjMKYHD7mc6MTfHPKQMPbs5jOMggWQbMMULhCrHXaGGk4uI9V1T4T8 Z0ZauYdVegUwJ4SenV718PZ3BoIoAnxJ1i8DmsGfpdzVhb+ZodeM0u8LbvWR0pUrSiqN snHk7en35uR06SqB2W0ypxr21ZJhFhuF+TzqxeczlJ36/mAawrEiraiXE+jEWLhm4uOr ZK8TfMTiGMRaCLK828N7UDRu3MiOxxqE7eW9CSnnlMtvy977JM2hjSpXImh59+1AhapA KcqujkXLXKhwYO7pjeLvy4DE98yxv2kO9BRyZcejcK4ScWvFurJiUmePqJIFCbDBSJrh 6V/Q== X-Gm-Message-State: AOAM5332Vaf16YlSsWoTfyGQWvbBtpauuQCVtzGZ2mq32sga5+v13vIV DN0hqmmJl/rUBgx08Mm5K6wJSi/gBkaGx4Cuyz7LZw== X-Google-Smtp-Source: ABdhPJwDY5rfx6SUKhnLfANCZH4T5a7778rYWZ4Dkd+N+1SS1+FyIo0aivBzlr1A066niH50hwCEBfUC59DPTKJn+Hw= X-Received: by 2002:a05:6402:17da:: with SMTP id s26mr1105652edy.221.1599050109841; Wed, 02 Sep 2020 05:35:09 -0700 (PDT) MIME-Version: 1.0 References: <20200127173453.2089565-1-guro@fb.com> <20200130020626.GA21973@in.ibm.com> <20200130024135.GA14994@xps.DHCP.thefacebook.com> <20200813000416.GA1592467@carbon.dhcp.thefacebook.com> <20200901052819.GA52094@in.ibm.com> <20200902062311.GB52094@in.ibm.com> In-Reply-To: <20200902062311.GB52094@in.ibm.com> From: Pavel Tatashin Date: Wed, 2 Sep 2020 08:34:34 -0400 Message-ID: Subject: Re: [PATCH v2 00/28] The new cgroup slab memory controller To: Bharata B Rao Cc: Roman Gushchin , "linux-mm@kvack.org" , Andrew Morton , Michal Hocko , Johannes Weiner , Shakeel Butt , Vladimir Davydov , "linux-kernel@vger.kernel.org" , Kernel Team , Yafang Shao , stable , Linus Torvalds , Sasha Levin , Greg Kroah-Hartman Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: AAB2A18140B69 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > I am on an old codebase that already has the fix that you are proposing, > so I might be seeing someother issue which I will debug further. > > So looks like the loop in __offline_pages() had a call to > drain_all_pages() before it was removed by > > c52e75935f8d: mm: remove extra drain pages on pcp list I see, thanks. There is a reason to have the second drain, my fix is a little better as it is performed only on a rare occasion when it is needed, but I should add a FIXES tag. I have not checked alloc_contig_range race.