From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7C49C4829A for ; Tue, 13 Feb 2024 15:45:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E9AD8D000F; Tue, 13 Feb 2024 10:45:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 572298D0001; Tue, 13 Feb 2024 10:45:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C4398D000F; Tue, 13 Feb 2024 10:45:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2966E8D0001 for ; Tue, 13 Feb 2024 10:45:34 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EABF3140180 for ; Tue, 13 Feb 2024 15:45:33 +0000 (UTC) X-FDA: 81787205346.09.B5F28C1 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) by imf05.hostedemail.com (Postfix) with ESMTP id 00D2110000E for ; Tue, 13 Feb 2024 15:45:31 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none ("invalid DKIM record") header.d=soleen.com header.s=google header.b=LnidU58i; spf=none (imf05.hostedemail.com: domain of pasha.tatashin@soleen.com has no SPF policy when checking 209.85.222.172) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707839132; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r+5lFm1GOYo46btsIaJvA6S/B+CQsp17IG3lccG/v6g=; b=ZYAnpZuey2FOWD5HkOUMC+WmjAPhBRHF/lzfqrgPKzyVXL9Kk4Nt1K8AupNbbA10DnKs+h uPlv8IXPKvPk/KLBKTmZD1irN+dad5CtV+vTFH27BupvBmr4tBLkun5p1RLxDbRWYm3Nxm aCDxGce33YUObUAjLaSc5RMLQ6jM95k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707839132; a=rsa-sha256; cv=none; b=JiWtjNHw5Y0g79odfZNM1IgGMKnIOF+pJHjlVH2itTjNhmOzASxZf62hU/SJLretCfxO6B NmFGZ2Pdc9dNQgsc3lBkrCG+wtw6EgnsGGAfB65Cw37S9p7lPurxHOrK6Q5B+tyHQugdYx YMRHsrEXXLMWJDTiEpwJ0Wzcc7t32jM= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none ("invalid DKIM record") header.d=soleen.com header.s=google header.b=LnidU58i; spf=none (imf05.hostedemail.com: domain of pasha.tatashin@soleen.com has no SPF policy when checking 209.85.222.172) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=none Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-783f553fdabso304619985a.0 for ; Tue, 13 Feb 2024 07:45:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1707839131; x=1708443931; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=r+5lFm1GOYo46btsIaJvA6S/B+CQsp17IG3lccG/v6g=; b=LnidU58ib/eEIEHKVeooqH+1KphGyqf8UiEBydpRWzTefr79bUoIMs+jR+gzeWEtNn TJzrlTE9TpWAgitQrDbVl/FNdE6XFHDSKokWd+jKZLovn3044Z7igpFOxgJx88PeC8aU PlItCxTHWRAEiwOxL6uoquXTCtc8zg5VCtRWc48j5mSXeptCyTC04A6Xl74EDbe0U6Is GTIunND9gKv6eFNbS2ZufuyW1gWbNq4XCL0DRE4x7BJByEBlnAgyhQ583z0BSWD0Gn4d 5mBF3wFDftjhvHxwiz7cEUQD3VgJfVbX7+FBZTt/bUu7cEewdRLkRMyQwmzl+W5gUvAn cjqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707839131; x=1708443931; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=r+5lFm1GOYo46btsIaJvA6S/B+CQsp17IG3lccG/v6g=; b=N0oMchIpAg0RUR3087DSWfWjqqTl3zrrUl1Zg7NvdaS2iCJ0gv7svY49D2MjzKKow4 w8/H7vbSeiziep8/GOppqXd2LgXOJmWG3F7E8ykb8fptw/E9APyxoMmtuSOf64JjpS1A dz+Wi3rEbuZXAd4kaOfZ/za54uLZ6xRttOFuSmuDxMguZCYh+dBRLJZva5/mwZ4zRzMP XKFj0kVMcYjNWK8Ke6c5YXuY92ubjLZ07y/Qap2ARz8paPiufIymA0E0lCBptxdvJEZw JhVvhmD2uyrQXeylwb7xsuWeLAU1fSZgBnyFUqWtdTQRvE3tyktXz+kKLIkkd4a/b+qx YXxQ== X-Gm-Message-State: AOJu0Yy+/LdVHKM/56NQqmCnGHG71u6pdyrmeF/WUbXS3KOMyH9hu2uX 2pSKeB0r1wfcOOKE1ut4217sBw8/dmJecAK6wrRQ2hVw3gKPqnY7G/G/aV2t5V7LJe8pA2FQMYV dcYs0hIWXfYVnEyTlpSVxaQHatGVhl1Li+fxyHA== X-Google-Smtp-Source: AGHT+IFqChznTFjr/EeidSN571ZA0nQfVJvF+Fp0E+Y2flaP6eNCXc4z1s3ADkdtr1CrUfrPgpTF+9pex3Z052b1w5U= X-Received: by 2002:a05:620a:618b:b0:787:1db5:f0de with SMTP id or11-20020a05620a618b00b007871db5f0demr2991955qkn.26.1707839131046; Tue, 13 Feb 2024 07:45:31 -0800 (PST) MIME-Version: 1.0 References: <20231226200205.562565-1-pasha.tatashin@soleen.com> <20231226200205.562565-11-pasha.tatashin@soleen.com> <20240213131210.GA28926@willie-the-truck> In-Reply-To: <20240213131210.GA28926@willie-the-truck> From: Pasha Tatashin Date: Tue, 13 Feb 2024 10:44:53 -0500 Message-ID: Subject: Re: [PATCH v3 10/10] iommu: account IOMMU allocated memory To: Will Deacon Cc: akpm@linux-foundation.org, alim.akhtar@samsung.com, alyssa@rosenzweig.io, asahi@lists.linux.dev, baolu.lu@linux.intel.com, bhelgaas@google.com, cgroups@vger.kernel.org, corbet@lwn.net, david@redhat.com, dwmw2@infradead.org, hannes@cmpxchg.org, heiko@sntech.de, iommu@lists.linux.dev, jernej.skrabec@gmail.com, jonathanh@nvidia.com, joro@8bytes.org, krzysztof.kozlowski@linaro.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, lizefan.x@bytedance.com, marcan@marcan.st, mhiramat@kernel.org, m.szyprowski@samsung.com, paulmck@kernel.org, rdunlap@infradead.org, robin.murphy@arm.com, samuel@sholland.org, suravee.suthikulpanit@amd.com, sven@svenpeter.dev, thierry.reding@gmail.com, tj@kernel.org, tomas.mudrunka@gmail.com, vdumpa@nvidia.com, wens@csie.org, yu-cheng.yu@intel.com, rientjes@google.com Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 11rc6oknkoxo939srdjc8epejoqzy7ij X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 00D2110000E X-Rspam-User: X-HE-Tag: 1707839131-105780 X-HE-Meta: U2FsdGVkX1+DknaySKZ4nPsBoC+oThGQVs+UhOQ59eEMA7t3TjXBbC0DLi4ilPhGi4vEGopr2HqB/5V6etXonGRsnk06mqjIrTUiko0LqrMptsmwcXNBnQurhzu/BcLNN4vqsvrXPpYfXZnWNQgMc+OOw7ELgAch72Xy09Q4UozVK3tYFbiKPFWnXqJ/J4pFSqkYEZTINXmC4RUxvKuiEw5Y2h4P6vCQFlQIZZ6StzyZamZCNfVj3pvjFAO4pWgc68Ll/KvkBRVt/ft871kbALy6nTHPGnImEUv/tf/KBL6cDbKMcKJdJjuMjzsFHaro+bq6mmq+DxGRbtN2XPf5Y+JjO3XSuMf3HiPTHxjGSML9waNoZG5Za3JUkSWR3dB2E7jvmwo2dCH1NrEbFycXYRDOGaGy9WrMkTiGdpeABIT3tHTMs4IVyL31fat3Y3TBUZAb5K351/v6+jdbQVgRHMRb/MV+t3BvIWCUnFwfk2uTIU/pqmnjv2AX9zmO+PRen+7ha7oy4txpGmrk2NcerDW0g39wjVV9VO/WpDX3+P7vUZUpb8L+rWOQfEvrJ7hGLlX0iDZ0978aeN5HGnjPV7R9iS98nvK5+vyjXKAWs7a+f1kYBJ9H+1Kq1HDZPlSrN7RJrtpk+ZollcOAbHK6d83cw0NjNegKFNIGlSVvBW8pjransA8XVlVGMxmjaDuVlELgvdUAN5ugDQkVAiCmCynY7Xqfzn6wSLbgDJmzc75eGjL3/K3S6JjM6mNLZ054gkr3/stcF0ZbDy7CtQ+Gkicufma2RJxV0ohF7KNauAzgRHIWxzgaqKFeaVKdBizj6ChgS8ECxVNZ4icdbTCUv+VxxpPUjG8Go5nD7etYOcHRaPU1iwzI274Rue8XX1xwCNQwelFPPFLx2sIr0JLRM5kTgNhuoUGtiBEYYbE8qQE6pzJyvUF91VzlFjtqcm0+YTJrBJn+ic3XvGdw3/s IRwBiHdg zC2s2O1XyBUrJp3zhR4PnWm4Mw77cvn9VOICIL4gx6utLinkvmJx4gPZcEb+Iwsss4vN68QfB66knFLYlb9q7f3Gspr4nO2erDiYGuv1UU3bZIFk21l+GFDFz2DFnKVfuUNZ+LCUGT490h4L9xUrelXqXh7udHhArR6Lu9pqzDAdm++SxpaleXlr+npKFXJYbLMeXi06tBozk+HORurCKV/gqY9kIwv5NtlEp X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > SecPageTables > > - Memory consumed by secondary page tables, this currently > > - currently includes KVM mmu allocations on x86 and arm64. > > + Memory consumed by secondary page tables, this currently includes > > + KVM mmu and IOMMU allocations on x86 and arm64. Hi Will, > While I can see the value in this for IOMMU mappings managed by VFIO, > doesn't this end up conflating that with the normal case of DMA domains? > For systems that e.g. rely on an IOMMU for functional host DMA, it seems > wrong to subject that to accounting constraints. The accounting constraints are only applicable when GFP_KERNEL_ACCOUNT is passed to the iommu mapping functions. We do that from the vfio, iommufd, and vhost. Without this flag, the memory useage is reported in /proc/meminfo as part of SecPageTables field, but not constrained in cgroup. Pasha