From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CD8CC3DA61 for ; Fri, 19 Jul 2024 02:55:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2FAC06B0082; Thu, 18 Jul 2024 22:55:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2AAF26B0083; Thu, 18 Jul 2024 22:55:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1728F6B0088; Thu, 18 Jul 2024 22:55:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id ED18D6B0082 for ; Thu, 18 Jul 2024 22:55:57 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 784DF1A0351 for ; Fri, 19 Jul 2024 02:55:57 +0000 (UTC) X-FDA: 82354987554.09.FA9C6C4 Received: from mail-vs1-f54.google.com (mail-vs1-f54.google.com [209.85.217.54]) by imf27.hostedemail.com (Postfix) with ESMTP id A75E84001F for ; Fri, 19 Jul 2024 02:55:55 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=iN2c6w+w; spf=pass (imf27.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.217.54 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=pass (policy=none) header.from=soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721357700; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xIhpumDPm4fvOwY3jLHPpABCQS7IJTZrwNfks0Zro8o=; b=v/letFUywUGF4m/vQ2G8BrSi8hSkxMJSt0BrO9K5yH9jetSwgZSEnKaMCVykXnG2BsdYUD u7PV9d3PYuNd/ZGNHRauCmx9Cw7UXEPgBW+09PtmLND6gdLMxfrCrugNHIs6GpQtjlSNoo QjPnq8Qco3WDr+T0BT1dRJpkJF2jXFY= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=iN2c6w+w; spf=pass (imf27.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.217.54 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=pass (policy=none) header.from=soleen.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721357700; a=rsa-sha256; cv=none; b=vV9rW8QrIUjRsMltCbr1OXvDi+k/sTx7UW1jIr+AfsEepeVfOacT7Wo4fCDmyH1LxBqC2w 3uzM2B9CUyRz9YrAO652y15Zb3zgZcZSuuQHsxMDXktTs40/saxZ9edPpdq1n+SoXuTJuH +2uZsd/99hX9p7NBEK2RrJTE2huE1xs= Received: by mail-vs1-f54.google.com with SMTP id ada2fe7eead31-48ff8aa6081so483432137.1 for ; Thu, 18 Jul 2024 19:55:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen-com.20230601.gappssmtp.com; s=20230601; t=1721357754; x=1721962554; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xIhpumDPm4fvOwY3jLHPpABCQS7IJTZrwNfks0Zro8o=; b=iN2c6w+w8lHybaGOyni1eWzP4rZYJOUe5MEj0KsZhJvQ2WejlRUMU9keS/+E6uCX0G 2suVfQ7az70eIyMIYcQ+Y2j5k/FjXC1Bx7cyLPvWHfFed1DmaVQAmSWpRdOh1EKThtb1 sCQnKJ57cbYDl2ic0z4QiBMHVq28CuWPdmSoGg5d7dACvviNozG9Vm0Cd/fbSaPordtS 02Ti0yP+6uhZrWpI0LSpLPNIMobA9TKhMTt09DSkPqmgnp1qqRMY+RRTvb9DZoUhpw9d eOAaVCfqcGEAZV2FRH44x2KZFhKDHAcmMDQJfbPKwezkPJzCIEFOLpRbyUtSrYFehnVB KY+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721357754; x=1721962554; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xIhpumDPm4fvOwY3jLHPpABCQS7IJTZrwNfks0Zro8o=; b=Q+qcyULFLXvdcIdhaAqB480siaA5MHFR28cDjEIJyVpVJMU/2RHSCVOb8ohvraPOX4 r5ZC6M3WhmJJn25xRSW1DwallF6mvdi5L/w0JZ8pGApKX6f2SE0ZYQZrDz/V9w3ymofc ONtqH5mewn8xvTBRkn2KOuDNsy26AJzkdFjucQ9kCg9GtFwH7+atSn1vmDbvUVrIwjbA xC2csWW61is1MsnUFU/Q43lP5QwTIzntIPMoowG1n2WYvAZBKcVULGmDuteZayNAGL6h bsXKc86KfayRfga0krU0m7ix3OFfLGLiw8+W0ulSCtT0+OPoYegOLgLr1a7oJf9pPvNz ek/A== X-Forwarded-Encrypted: i=1; AJvYcCVuMfcaqP8Elr4nRDZ7BxXPlAaeAMmdQv5wqNSkRKH/E3/EbV8w4XDSJpKKyNM+XydUssj6KXbp0lJ5zmSIozkYs9U= X-Gm-Message-State: AOJu0Yx8lo5emMjLwwCPtjeSkDoHiXOpR9VqzM1BxdBP8YZuTgXdu6AT j7QO5wIGSnhB6SyjNQYPrRvRK6mLuxI2w4p5AaK8A2sSGP7aILWjADRC8ivlFwdleuX7jTU0JOd T8S0zEUnvG8HmGJ7bHr5WglZPvfrGuHyesRZVLg== X-Google-Smtp-Source: AGHT+IF9USjnlYvphL36rdSXytfyHnoWlCthQOZzmJ7NTCLIEur/EE/+i/CoA2/MuhlEZSKE5A/DrhXQKIDnwO6Rq+4= X-Received: by 2002:a05:6102:80a4:b0:48f:df86:db3 with SMTP id ada2fe7eead31-491597faba5mr8705048137.3.1721357754635; Thu, 18 Jul 2024 19:55:54 -0700 (PDT) MIME-Version: 1.0 References: <20240718202611.1695164-1-pasha.tatashin@soleen.com> <2fbbxcsjs7vtzpb6a5wudbppcr2wgc2xwdw3cgs6ejzx6rioze@z2sct6rbulng> In-Reply-To: <2fbbxcsjs7vtzpb6a5wudbppcr2wgc2xwdw3cgs6ejzx6rioze@z2sct6rbulng> From: Pasha Tatashin Date: Thu, 18 Jul 2024 22:55:17 -0400 Message-ID: Subject: Re: [PATCH v4] vmstat: Kernel stack usage histogram To: Shakeel Butt Cc: akpm@linux-foundation.org, jpoimboe@kernel.org, kent.overstreet@linux.dev, peterz@infradead.org, nphamcs@gmail.com, cerasuolodomenico@gmail.com, surenb@google.com, lizhijian@fujitsu.com, willy@infradead.org, vbabka@suse.cz, ziy@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A75E84001F X-Stat-Signature: akbqbwdji5b3e59bm3x7wryb11nt4he9 X-Rspam-User: X-HE-Tag: 1721357755-685624 X-HE-Meta: U2FsdGVkX182UbKBUO9Jhnky1DlZUbXP/OaL591p4pUIR/qtf5a/KarkD9bNPIjYw4VLfs7w0y/Dq7QxeqyTIlS9NU84Y/zINt30/t9PDU0dAsAHRstXp48uC6aKZJqN9no7/wKcqkH6Tk8liRP1JhoO2e7XyIAUOF/jRQR1F/nDX5eaqa4J9i9NVb1XQTRekY/+SEfn4ghoxNRGywgaDSXnwUdLyLpSrqLu/QM/Cp2QFv5DmSfXFMVW0pxj5FDbTyLkfIkDkjnkcIKIptmZtzi3qgguv+ibwPlhVbF29dBOz50MYghEaYsAv5i7Fam1nZndV/hhhez/ZKiMqeXUw+MLZuwB96IIVErQ1BiuZO+qe5JgwTF3lMQcG5CI+OYzBVGl46GxHNZZiHPDP5qooIJIeSdjKRxPKrVoDS+1d1zXRKRwMu0pUp6QgY1eMSUpVrBwqxxX6K3qfteoLY4ICCa+G96feNpnm5kXMfHWlhlML12T8ezcaMytgII3YFzFv98FOMrxvQ7ij74x8jhAVTtM6ojsrVeEcEEVZ+U3oBbZkFxdT1CpZQ5SY83IUW1u5HLUOW61Q5PJ2fPNZhSsrT3H9SxnyIQA7Aymz5vwQ8YBcXBInWG1SF0JXNMtBs3QZsY78m41t9eHkXaaC85bEFKFVXcpX+TNT/RdgtSBvYBIN8+CIxVNK8rbfGhW2Pu+xtOto3ZsWaWBKwQUd27wgprfjowasoaRTExXMiGQi4wGfsw/EB+FyQvhtv5l1eTU8YdqE/lzs1+8wcyGmndkvtNot4uIAVhyQzOmRtO6s25dVt0oVNrxmcQwz9G97C0AIZnExjZv92BFIpt9AZpqxpOQWdDr5F/J2kiNL/iyng+PmEGYCgtrD6lWsloI3i5KkGrbrU7C6MPgBqcYT/ZyttD5nQrXXMm6gByT1JlGlRwSlEhKZozbfyiHsniO702BS7f3WTAZIiU5sIhl2So 7++wWeaE C8PpiJYP2MzwByimW8ZSfU2xBNTOG5Anxk8Gxt1OJCtteMtDDZAvDADr/NDn4OIZv3+OMD3UL8p1ksRV6EqLdz+mndp0BC29xFE4/I4CsQKh4R8CybCzcABLfoL7wPwLSD5wk5CwQ5fQwVzmdnAzteuZZCHjZ5ldxqQf/DX+fp80k5p6r5BhORtmopXgfDI8adMb3nRh28bNqLbZJlbIeyEcIppNFDBfp0jC6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 18, 2024 at 7:36=E2=80=AFPM Shakeel Butt wrote: > > On Thu, Jul 18, 2024 at 08:26:11PM GMT, Pasha Tatashin wrote: > [...] > > diff --git a/include/linux/sched/task_stack.h b/include/linux/sched/tas= k_stack.h > > index ccd72b978e1f..65e8c9fb7f9b 100644 > > --- a/include/linux/sched/task_stack.h > > +++ b/include/linux/sched/task_stack.h > > @@ -95,9 +95,51 @@ static inline int object_is_on_stack(const void *obj= ) > > extern void thread_stack_cache_init(void); > > > > #ifdef CONFIG_DEBUG_STACK_USAGE > > +#ifdef CONFIG_VM_EVENT_COUNTERS > > +#include > > + > > +/* Count the maximum pages reached in kernel stacks */ > > +static inline void kstack_histogram(unsigned long used_stack) > > Any specific reason to add this function in header? For performance reasons to keep it inlined into stack_not_used() which is also defined as inline function in this header. > > > +{ > > + if (used_stack <=3D 1024) > > + this_cpu_inc(vm_event_states.event[KSTACK_1K]); > > Why not count_vm_event(KSTACK_1K)? Avoiding header include recursion? I could not include "linux/vmstat.h" into "linux/sched/task_stack.h" because it introduces some dependencies such linux/mm.h and linux/fs.h, uapi/linux/stat.h, and when all of those are added it still fails to compile on some architectures, so it was just simpler to stop resolving the conflicts and use this_cpu_inc() directly. > > > +#if THREAD_SIZE > 1024 > > + else if (used_stack <=3D 2048) > > + this_cpu_inc(vm_event_states.event[KSTACK_2K]); > > +#endif > > +#if THREAD_SIZE > 2048 > > + else if (used_stack <=3D 4096) > > + this_cpu_inc(vm_event_states.event[KSTACK_4K]); > > +#endif > > +#if THREAD_SIZE > 4096 > > + else if (used_stack <=3D 8192) > > + this_cpu_inc(vm_event_states.event[KSTACK_8K]); > > +#endif > > +#if THREAD_SIZE > 8192 > > + else if (used_stack <=3D 16384) > > + this_cpu_inc(vm_event_states.event[KSTACK_16K]); > > +#endif > > +#if THREAD_SIZE > 16384 > > + else if (used_stack <=3D 32768) > > + this_cpu_inc(vm_event_states.event[KSTACK_32K]); > > +#endif > > +#if THREAD_SIZE > 32768 > > + else if (used_stack <=3D 65536) > > + this_cpu_inc(vm_event_states.event[KSTACK_64K]); > > +#endif > > +#if THREAD_SIZE > 65536 > > + else > > + this_cpu_inc(vm_event_states.event[KSTACK_REST]); > > +#endif > > +} > > +#else /* !CONFIG_VM_EVENT_COUNTERS */ > > +static inline void kstack_histogram(unsigned long used_stack) {} > > +#endif /* CONFIG_VM_EVENT_COUNTERS */ > > + > > static inline unsigned long stack_not_used(struct task_struct *p) > > { > > unsigned long *n =3D end_of_stack(p); > > + unsigned long unused_stack; > > > > do { /* Skip over canary */ > > # ifdef CONFIG_STACK_GROWSUP > > @@ -108,10 +150,13 @@ static inline unsigned long stack_not_used(struct= task_struct *p) > > } while (!*n); > > > > # ifdef CONFIG_STACK_GROWSUP > > - return (unsigned long)end_of_stack(p) - (unsigned long)n; > > + unused_stack =3D (unsigned long)end_of_stack(p) - (unsigned long)= n; > > # else > > - return (unsigned long)n - (unsigned long)end_of_stack(p); > > + unused_stack =3D (unsigned long)n - (unsigned long)end_of_stack(p= ); > > # endif > > + kstack_histogram(THREAD_SIZE - unused_stack); > > + > > + return unused_stack; > > } > > #endif > > extern void set_task_stack_end_magic(struct task_struct *tsk); >