From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E87AC4332F for ; Sun, 6 Nov 2022 13:47:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F357D8E0003; Sun, 6 Nov 2022 08:47:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EBDED8E0001; Sun, 6 Nov 2022 08:47:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5FAE8E0003; Sun, 6 Nov 2022 08:47:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C7BC78E0001 for ; Sun, 6 Nov 2022 08:47:05 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8D059806F8 for ; Sun, 6 Nov 2022 13:47:05 +0000 (UTC) X-FDA: 80103143610.21.44A690F Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by imf07.hostedemail.com (Postfix) with ESMTP id 3646640005 for ; Sun, 6 Nov 2022 13:47:04 +0000 (UTC) Received: by mail-ed1-f53.google.com with SMTP id v17so13840157edc.8 for ; Sun, 06 Nov 2022 05:47:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4Cc3Cob2HMpA+4FuJJhkFj8IUBM4Qig1zRJRYFxaKeQ=; b=i+XtjvGSXRuumvaCFDiGQ3DTX1a6VYta2aAmDaYwPeZV47m/TFpCpgYNvrvc+oviIc 2v6YOarLLUwNPaNXG8Sd8zzObAmDR3OuSwflTqP3Pi8wYUPLcRb3qpcUcNX3H5lME1AO 2YX5341IlxRbenFdpH4Es5tSBqMgLe5DoNd2yUivWgB74w6B/haOqesq+5VOdo/V8l0Z J5446eY1lR+EavB5zej6PEfU9yVi3zznqcqVDLX2a5oVf8Uxq2EwI4Gueh7id3f/7H+d CNeqE3CEhAj7plFdnJ2OGxgnsWRc1lh0bEV7f3aBeHpEOhnPUIus1TymFzzJW/HePhtD olPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4Cc3Cob2HMpA+4FuJJhkFj8IUBM4Qig1zRJRYFxaKeQ=; b=H1cpmqE01SrpNLpYzv66jgJtyImqrdtV422NLiDiUKsIo8hHhGVbADhvUAwY+hbFcm f6w5+q9SpX1F1ePqooCSRqV5cTigVv27ogXmPT0eXllqXgWeskD78itUGObKc0/8Ft8R Oh4GWQe7EJsLE++qXnVUUffdwgruXCzDKmr+rgD0N8e0CSy/TUeuTSTLPoJxzuIDkSKB dxUwPb8xdnjrXufZ6ps3An1dSWagshk0huV0qF8FKeAlSGX6IPWVmB6toSvyFoG5Vq08 E2ppQvv+rwr4cedC9Wqpx0oO38YetPpHyLcMX3eowojn/homR/P8j6kk+/Ulj+ITRVEb fR2w== X-Gm-Message-State: ACrzQf2g6wylACUAXHJ4Ngo/ZLapTTawk46B1qu1h687Tmhzd7Z0KKUx NPvbXNnhor07KYL0Gcm9AjlUJagIfRUZb6fWkaHBTg== X-Google-Smtp-Source: AMsMyM48U0SeoynJS9XayTwbS33kzjYHL5TJWZzzOCIZ/D3eTcq7XZQc+SJqFkFx2x40ydFcGhc0xE5HaNQArM9a8qE= X-Received: by 2002:a50:eb83:0:b0:462:a2ac:8623 with SMTP id y3-20020a50eb83000000b00462a2ac8623mr45311356edr.360.1667742423783; Sun, 06 Nov 2022 05:47:03 -0800 (PST) MIME-Version: 1.0 References: <20221105025342.3130038-1-pasha.tatashin@soleen.com> In-Reply-To: From: Pasha Tatashin Date: Sun, 6 Nov 2022 08:46:26 -0500 Message-ID: Subject: Re: [PATCH] mm: anonymous shared memory naming To: Bagas Sanjaya Cc: corbet@lwn.net, akpm@linux-foundation.org, hughd@google.com, hannes@cmpxchg.org, david@redhat.com, vincent.whitchurch@axis.com, seanjc@google.com, rppt@kernel.org, shy828301@gmail.com, paul.gortmaker@windriver.com, peterx@redhat.com, vbabka@suse.cz, Liam.Howlett@oracle.com, ccross@google.com, willy@infradead.org, arnd@arndb.de, cgel.zte@gmail.com, yuzhao@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=i+XtjvGS; spf=pass (imf07.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667742425; a=rsa-sha256; cv=none; b=0LNFn4UqgFcYKN2F/hc3XsaQmnGjHoyvUoSvcQw6xWMxUDNoNemCG9pNG1wFWsjVlsP/4T M20LE7ayCzr2GQM3RHO+dILE+lHs3VGjCo/bWlRDxNVfpiSVzM+CO81JFnFKdbhS2WigqQ 2vis7jHxGh0Yw5jf2C+wIv847o3HY54= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667742425; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4Cc3Cob2HMpA+4FuJJhkFj8IUBM4Qig1zRJRYFxaKeQ=; b=3zzpRxEEhHYNdMLNcWw8OfBEOQ45cUrpvhP+LRx95siUZC0wEmJU3wqekfXDTmdo0VZWTc 0+XNL6s+AQLLhcwygMjIqMkesNBsbYe7TVSYSjKsuvzY8qTdHxtPRRFUtFnwu7shWdFhfr XLEE3XdJsfVWA4Ac2IggTaHkRuQ4OrA= X-Stat-Signature: gumpfbkr3c3yap7dq381b346gniaarzf X-Rspamd-Queue-Id: 3646640005 Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=i+XtjvGS; spf=pass (imf07.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1667742424-139407 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Nov 5, 2022 at 5:34 AM Bagas Sanjaya wrote: > > On Sat, Nov 05, 2022 at 02:53:42AM +0000, Pasha Tatashin wrote: > > Since: > > commit 9a10064f5625 ("mm: add a field to store names for private anonymous > > memory") > > > > We can set names for private anonymous memory but not for shared > > anonymous memory. However, naming shared anonymous memory just as > > useful for tracking purposes. > > > > Who are "we"? > > Instead, say "Since commit , name for private anonymous memory, > but not shared anonymous, can be set". Thanks will update. > > > @@ -431,8 +431,10 @@ is not associated with a file: > > [stack] the stack of the main process > > [vdso] the "virtual dynamic shared object", > > the kernel system call handler > > - [anon:] an anonymous mapping that has been > > + [anon:] a private anonymous mapping that has been > > named by userspace > > + path [anon_shmem:] an anonymous shared memory mapping that has > > + been named by userspace > > ============= ==================================== > > > > The table above triggers Sphinx warning: > > Documentation/filesystems/proc.rst:436: WARNING: Malformed table. > Text in column margin in table line 8. > > ============= ==================================== > [heap] the heap of the program > [stack] the stack of the main process > [vdso] the "virtual dynamic shared object", > the kernel system call handler > [anon:] a private anonymous mapping that has been > named by userspace > path [anon_shmem:] an anonymous shared memory mapping that has > been named by userspace > ============= ==================================== > > I have applied the fixup: > > ---- >8 ---- > > diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst > index 8f1e68460da5cd..3f17b4ef307fe4 100644 > --- a/Documentation/filesystems/proc.rst > +++ b/Documentation/filesystems/proc.rst > @@ -426,7 +426,7 @@ with the memory region, as the case would be with BSS (uninitialized data). > The "pathname" shows the name associated file for this mapping. If the mapping > is not associated with a file: > > - ============= ==================================== > + ======================== =========================================== > [heap] the heap of the program > [stack] the stack of the main process > [vdso] the "virtual dynamic shared object", > @@ -435,7 +435,7 @@ is not associated with a file: > named by userspace > path [anon_shmem:] an anonymous shared memory mapping that has > been named by userspace > - ============= ==================================== > + ======================== =========================================== > > or if empty, the mapping is anonymous. > > > Thanks. Great, thank you. Pasha > > -- > An old man doll... just what I always wanted! - Clara