From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DA5FC3DA6E for ; Thu, 28 Dec 2023 20:51:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 99FC26B00FA; Thu, 28 Dec 2023 15:51:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 94F796B00FB; Thu, 28 Dec 2023 15:51:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8174F6B00FC; Thu, 28 Dec 2023 15:51:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 71F566B00FA for ; Thu, 28 Dec 2023 15:51:04 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4725A140162 for ; Thu, 28 Dec 2023 20:51:04 +0000 (UTC) X-FDA: 81617421648.22.BE9A584 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf06.hostedemail.com (Postfix) with ESMTP id 7E3D018001F for ; Thu, 28 Dec 2023 20:51:02 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=LugKHRl5; dmarc=none; spf=pass (imf06.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703796662; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O6AAWinozqvqRPJJJy9/95oMBpoLUYKoADUfceo9DTA=; b=LKGZMb16syOuyhIH3dLoI7d+SWt+RZdzGWP878lF2wdLtOfdFbYEOFroShBuxAg/w80Rk0 LwK7qUDxLZAHFKINQKnYwZO1fA1eC9qHkvbAYo0FZtQRPKjRiSO3uC1MTnto2l+J9cWvr2 l4kHO3sSvCci8XrvyNkC15adoMHyp/U= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=LugKHRl5; dmarc=none; spf=pass (imf06.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703796662; a=rsa-sha256; cv=none; b=H+S8Y/qPKp/oX1yUT9PvKeskHXUq+tBLf1myTcBnLV0LIVhz+nevW1B+QktYISk0+Iqlox s4Wg1oLsexkibR5VNnY64N9N2pyoVkcC4HDUHdKbsDIqc5OcYJzoPCe4nVZlHAwIdDpxP3 0ke1ktsIZxmkTpFvenxnXMOFfEWvb9I= Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-42786ec994bso53214781cf.1 for ; Thu, 28 Dec 2023 12:51:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1703796661; x=1704401461; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=O6AAWinozqvqRPJJJy9/95oMBpoLUYKoADUfceo9DTA=; b=LugKHRl5CUbej44r2Dy9namDu6gyIIgIS+Bs/XEh2MMtFWP6FogiPna/nWCXBeSj9s cpIOklECh8T4rEZrZpBulCYxlnBLIkDrbLXYJphZE/oB7a5o5mwDNRUPAGeSIVMXv8vI Gpn/Q7jw4I89G9jDiNSpRUi/4Rx/THRRCvHYijzSiTBWFW6fiGUHNuCb5Q1RsNuxqSP5 hl7VYy+u+7FUy8yXtDxfmgUJFTAXomph6g6YR4f+65vzObOMMgTBagq2LB3tVF3uIHT9 Ow8v60btl9hvRY+UOTJC8Kbu04kqkyer30H4sP9xtG2EK59uxUhQI8zpMX485qdWKSda qCYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703796661; x=1704401461; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O6AAWinozqvqRPJJJy9/95oMBpoLUYKoADUfceo9DTA=; b=lT94q8vin2p3/bdwGVKWX77hFAO6HxsRu0RQ000p+ylJZFFVwdrD1emcAvGngahehK cSgtuAlGcMW77vcjmI5VK1wFfu8sqcCT9+izW4tqSYzRK9m+j18tzGwt1VGxsi8Edpj8 IuK8qvFZdfvrESZEdORGbFH35WH4w7bkucK4flJ0BitrlaIUzV0LK2jadq6MHGT/W0Da 5/8BnvSwM4+AVnJs5yTZslnSlvOqyjmwWhcaRTI/YCbHrm4HD+lmuZztnBd1kuGqeieA sHQmGVDCB/76YLdvDDk9tADhpzFm9yCybXTJakhB4yBVaeMa8MWM+OApgUejXHh/DsK/ DQNQ== X-Gm-Message-State: AOJu0YyZrM2D2Bf83ua5kUxXru9P2atZgFWTRtqLPsIJ/sBcpzYN8sYL UBfQaKyEsedaJN1hwawurTxWp/AyfoE2GU/C7jPCYvy9C0Wnmw== X-Google-Smtp-Source: AGHT+IFpM6FSJnu/fT7MUo3kvAgcqckDw2HVcb4L+wg/qq6S8e2uST/Lil7U8asRT24B/JXhj0d+Dr0vAnZygi7KTec= X-Received: by 2002:a05:622a:55:b0:425:8a26:9798 with SMTP id y21-20020a05622a005500b004258a269798mr14518555qtw.73.1703796661591; Thu, 28 Dec 2023 12:51:01 -0800 (PST) MIME-Version: 1.0 References: <20231211154644.4103495-1-pasha.tatashin@soleen.com> <3d415ab4-e8c7-7e72-0379-952370612bdd@google.com> <13e5fbd4-d84d-faba-47f1-d0024d2c572d@google.com> <20231227104244.824b0977ae6d4bb6b37f6f79@linux-foundation.org> In-Reply-To: From: Pasha Tatashin Date: Thu, 28 Dec 2023 15:50:24 -0500 Message-ID: Subject: Re: Sysfs one-value-per-file (was Re: [PATCH] vmstat: don't auto expand the sysfs files) To: David Rientjes Cc: Andrew Morton , Linus Torvalds , Greg Kroah-Hartman , rafael@kernel.org, surenb@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, souravpanda@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 7E3D018001F X-Stat-Signature: toqdmddrf635ak7and7mhgteee3a7xeb X-Rspam-User: X-HE-Tag: 1703796662-734607 X-HE-Meta: U2FsdGVkX1+u6QqjWSf+9CwZoBIpWQ5sWx5XXnwsN7egiHVh9VXR8GcxpRbxtmSJ0r4ha0xl3uE7LMBuXd5P9JowLmFurirbLizH2D9BqMNmDwOuqolnjlg7dpNKRg7Dt4PO5WhrYRql3TWA3mWYSGya2v8TfWGTpubnysGrEEg2VFIMtiVH0H9UfcoQZVZfYfqq9TS/BBj02P3SYP8fVfFwvuVC3CsPeEqtzYJ6D8HGOa8Db0bz7Z4PyiSQUYDg0ajDt/BqAgOsglFsDbH1CiaOoc4nAvjvsFISbSvw8nkj/9n5YRNd/Jqztra1d702TmihcUdFt50ghoPSAXC2F/57L3v9xrQ2LKYxa28T8ssK/ePP5iC61oBu8TlnvsY10W+kibixjxt7npWzsueDTSiGV6MNcRixd4Z0PRtVArDjXi0pX4jAh7mzYVRXE5DIr6FcdqAZPqjZyzhUZYQcPsB1Bb9jd4ots/HYySUx8DJ41jVQVCASM8WF21GN+G8j30kBWIrzQM4aliX8t7pytG9UM44TFLlAd9B/5M2qxyLksQ8wTruRx2WLkRZh60HuEIoG+RS6La/nMg0lam8DxnSsDtJmrrOW4M1yRoLTPZpph8sSj6OOeGfl8OpBFHOHR2SpwiTfqk0ppo16SxGIxlg5GN6NwOmOLi/zDW2y+KUTnlOq8MUn1eO/A7ImC/pwtDsHcfL/3usfHW2BJRhIQnj9cylHXCUBbhYYg5IRzASmF/rs2i7h/ewPW8m4NmdYStndwZGVEby9OKFB20IMn8BQPWxLJqqeFNN/rwpPf/bRPi8v+yLIChCY1eQdiGKa4QMsLfAjrwbMq5NoeLyfcz949hc8HGUBar9W93B4hLk5LIB/TqbsrC0CNA2/+hWCG3xcJau8t7+Wsl+vcIkeAJ+l0oUwPdrrvk4xddcVYM65POwD+wSR0hFjaXF9bi5ddaZOLD0gluFUPLBp/U1 gnm4oOOn r1aio+0zz81m1cvS5PiIGCQLzvgKZVUcU5/QESu/NB8WSRaz8picrDYdgT9UUAv6UWlMPjy2iZ8trN9QIwJQDZwsJn7QqIwWTrQOqUyuITSzJCWkQJ21MlfJiIowa/+BaExmJu7vl2MQmcgQSf36WEjRcn8eM0FLgIiPIFyxFodMOlQgMMfHiKcZeRDkGgUUK+/m7pA0dJvnYBYQmAaFjPl5cJSudsBrGCTSJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 28, 2023 at 3:43=E2=80=AFPM David Rientjes wrote: > > On Thu, 28 Dec 2023, Pasha Tatashin wrote: > > > > > But for existing files and conventions, I think we should settle it= as > > > > "keep doing what you've been doing for 13+ years" and don't force t= his > > > > argument every time a kernel developer wants to just add one more s= tat. > > > > > > Absolutely. Let's do what makes most sense. For new things, one val= ue > > > per file. For stats which logically group with other existing stats, > > > do whatever the existing other stats are currently doing. > > > > The intent of "[PATCH] vmstat: don't auto expand the sysfs files" is > > to do exactly this: keep the current fields in > > /sys/devices/system/node/node*/vmstat as-is, but prevent future fields > > added to node_stat, numa_stat, zone_stat from showing in vmstat. > > > > This is the opposite of what Andrew and I wrote above. There should be n= o > need to start preventing future stats from being grouped together in > vmstat if it logically makes sense. > > NAK. Hm, I must have misunderstood what Andrew said. I am ok with this patch being NAK, as long as the IOMMU observability patch series and Per-Page Metadata patch can be merged upstream, and extend vmstat without a NAK from GregKH for expanding a sysfs vmstat file. Pasha