From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55D3FC71136 for ; Tue, 17 Jun 2025 19:32:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D06BD6B009D; Tue, 17 Jun 2025 15:32:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB7486B009E; Tue, 17 Jun 2025 15:32:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA6666B00A1; Tue, 17 Jun 2025 15:32:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A875F6B009D for ; Tue, 17 Jun 2025 15:32:55 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 6713DBE057 for ; Tue, 17 Jun 2025 19:32:55 +0000 (UTC) X-FDA: 83565890310.07.E8B88AA Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by imf02.hostedemail.com (Postfix) with ESMTP id 7F00180002 for ; Tue, 17 Jun 2025 19:32:53 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=UaZ7eYX+; spf=pass (imf02.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=pass (policy=none) header.from=soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750188773; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ves47J1muGKJhd/kO2JKlr9I8bsuRNvgukULjmQzbWo=; b=niMqcxfU9T2SD7nfcEyCxog4UaarPFZsFZQjLDNq3jUZcKx2i8OdX0DWRwpnliHoSii4ln R1q6RmZtgHSW4TADVMv4tIvKNwBWHSCSqoSnk16KvLEDKszwY+vh0CZuVMFvN8umTtgHVR Nhfc8253rmAmYfBMj/N8CGflR9OAwBY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750188773; a=rsa-sha256; cv=none; b=4lNs6lczKsEzIDADhDP4zgkLNTxthZGl97o3Dx7Sn20RepCrtm19G6arLeqKE9Z1fjACX+ MgtTOR1aN0gi92tUixSj794fQNjvB+uVYT15RXWe7Z80O86vaUmvJredSz4Xhgqw94vKrF +MXVWPFhfBIEs6kzJz6RwuoMP5B1b9Y= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=UaZ7eYX+; spf=pass (imf02.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=pass (policy=none) header.from=soleen.com Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-4a745fc9bafso193231cf.1 for ; Tue, 17 Jun 2025 12:32:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen-com.20230601.gappssmtp.com; s=20230601; t=1750188772; x=1750793572; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ves47J1muGKJhd/kO2JKlr9I8bsuRNvgukULjmQzbWo=; b=UaZ7eYX+nhsFWD69FJZarOYqF1WvOoLtuTg2aJj6LHGB76yaqnD7UoYsm43jKt0PkE W/7uO4J4Nw2XYgTfbzzIBRw8niWO9F+sqQcM6ITvEF7RNSmjB+8fzQLIGIaaqAPh8b6Z gBBGZKFNI+aiMUlVQ9CQyVHy8N42cbKkWNcNtBslpka3rU/adrKnwIqkr+s2qOF4qc26 xSr9VuTOI7PcOU76xigXi3uqaHcazpn5VqK0ttwQiUZVSwGao6S9fg6Fjj1ZZLfRmYEo geW40eNT/AQKdAXsz7E+VyOXtDaLX8qucUOsUaGje3hQRFTnvwdAlHTuclwADVsvXfhw 1Jug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750188772; x=1750793572; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ves47J1muGKJhd/kO2JKlr9I8bsuRNvgukULjmQzbWo=; b=VwYzYqMWIlek5saY5tgepGAMv4Y3aM9LZlhjAinu4pzCY1IaQxhJ8GRjAertxMznfU nwfFsZCxnSAQPXhjBG3U8eQb92uVXGOjYA/jiZJRO+PuUFvPTudKVVv3yMDF4sZrFfQE I3vB63cJ1Qxb4Qa8/E4ybaQd04QlqONn8Sb5RNd0A3kdXpskPxvUGzuIpDUzKJw8lYND 8+6lvLeqW1zUddINlcAUclSU1lGq0gtHibcMZl1mzAFkwkY2vPpaw4sRfJ/l7Y65aapQ +mVBcYsdGuZ2Cea7gBgI95WKBqao2AnaOsweoO11Aak8V8ztptbQ/n4Co19TsOWUcdfZ BgLA== X-Forwarded-Encrypted: i=1; AJvYcCUwaonfoVH7kTu4mTbHR6om2KH6fdMZ5kwEVm5SkEoDeFl/fFsVUvBmEyZaJyGfeKN1B8McHN39Jw==@kvack.org X-Gm-Message-State: AOJu0YwBnENGayxqLzqkaVKeIYTV7wfSmUx0hr6VkjftiTAVgFLwa4zm kYbGrOs6cHN2iSPjpbZNRyreDQGK+xbuN7UfcEWSkwtOmZY5/3ulVMjtgmobmthtJS+oNMNo7Sa xBx5d99PAGsG/mU4fX5FTwDU+LTTAv7Or35GXqCR1zw== X-Gm-Gg: ASbGncsu48WKzxAKmygGhD+Tj61RUxoXRUA6XdW0qhp83/Sk/mSTk2egAqqxYyAouum IR/S7fTeVzaXRfN1WipOritZGN37Xk818lvqvqOf2mQ7JKgxqa/AZvQdIXvwrCqnJ1DnIV7wC39 /1oyWbfJQGSosYK6Oz/eur09vLekbejDUGpLfykXdp X-Google-Smtp-Source: AGHT+IHJZQLBelhzlpJ0ptowIyHIBKA44ecNZ4lE6UyXBr92AYsut9j2K3HQ5qGuEv971SjC4f+GDuHHtKxJ/HrN3ho= X-Received: by 2002:ac8:58d6:0:b0:4a6:f6e6:7696 with SMTP id d75a77b69052e-4a73b7c5539mr235522661cf.26.1750188772431; Tue, 17 Jun 2025 12:32:52 -0700 (PDT) MIME-Version: 1.0 References: <20250515182322.117840-1-pasha.tatashin@soleen.com> <20250515182322.117840-6-pasha.tatashin@soleen.com> <20250617152357.GB1376515@ziepe.ca> In-Reply-To: <20250617152357.GB1376515@ziepe.ca> From: Pasha Tatashin Date: Tue, 17 Jun 2025 15:32:15 -0400 X-Gm-Features: AX0GCFuqJ-tQnczF7gXXi8cFVYwNmh8hzNe9WhUyLpdDr7xmvZ9G9OUQyElUNtE Message-ID: Subject: Re: [RFC v2 05/16] luo: luo_core: integrate with KHO To: Jason Gunthorpe Cc: Pratyush Yadav , jasonmiu@google.com, graf@amazon.com, changyuanl@google.com, rppt@kernel.org, dmatlack@google.com, rientjes@google.com, corbet@lwn.net, rdunlap@infradead.org, ilpo.jarvinen@linux.intel.com, kanie@linux.alibaba.com, ojeda@kernel.org, aliceryhl@google.com, masahiroy@kernel.org, akpm@linux-foundation.org, tj@kernel.org, yoann.congal@smile.fr, mmaurer@google.com, roman.gushchin@linux.dev, chenridong@huawei.com, axboe@kernel.dk, mark.rutland@arm.com, jannh@google.com, vincent.guittot@linaro.org, hannes@cmpxchg.org, dan.j.williams@intel.com, david@redhat.com, joel.granados@kernel.org, rostedt@goodmis.org, anna.schumaker@oracle.com, song@kernel.org, zhangguopeng@kylinos.cn, linux@weissschuh.net, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, gregkh@linuxfoundation.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, rafael@kernel.org, dakr@kernel.org, bartosz.golaszewski@linaro.org, cw00.choi@samsung.com, myungjoo.ham@samsung.com, yesanishhere@gmail.com, Jonathan.Cameron@huawei.com, quic_zijuhu@quicinc.com, aleksander.lobakin@intel.com, ira.weiny@intel.com, andriy.shevchenko@linux.intel.com, leon@kernel.org, lukas@wunner.de, bhelgaas@google.com, wagi@kernel.org, djeffery@redhat.com, stuart.w.hayes@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Stat-Signature: oawmefo84xo36ws8robo9wiq8h8ezhz3 X-Rspam-User: X-Rspamd-Queue-Id: 7F00180002 X-HE-Tag: 1750188773-801496 X-HE-Meta: U2FsdGVkX1/KYgFst/2GBed3tqFGIvjD5pyUXAhnHA7Ym8RiRWxbvuN4X2AUKyPYv7/ld4Rd2aOBUbLqhshEGNtTMIFCzBvmQnPS4e4kcJDAapCFI7xwDITxNpyiT7XDcAVQqCBY77vYVF0ItvBGJ1iXa1398UTBOfF3HnRgsKv6tVr/EDD230XZlnaCSCIlnVqOFfROX2P8rOnxVr9tCgjRR9GCFEVA1uyoJU5UMDj8A07tefoVUVXwA77cTEgtcw0J0DN0KFta9WP182dYPLUFyJ5bJ74Ub5yuQWORS+bflvhqjPLInOr52oCo9cHgT8RncyVVXjIUlS9ktbcsT1gk7HS3GF56pU9Qjw2XMnTj9gkCSoXRC6npNRnCFA1qKhs5tAcxyakmGM/4xFy4FcYJAvGjTfhw4dRHjiV2h6e8JiS7j+pg6mafZsNkX7bFvrAD0wTPw03BDF2kQQB4jFrsOmeo+PokNk/cy8eA78gVbrnTeqGFOSJ3icsvjmh+j7hx6x3sm6u+ZPznok5M5vlVAWeELm0js1PYNNd3v+3Xu9K87xdkMvyArMZ9lzjc2h+d20SOhPfR/B+FS3TREEiyQMutTl3JRb2A9ZSHUXDJL4LpZ4iml3LmdMiWdeY/oghs0zRh1k8MSG4kcueLI4zF74A299yCqob7Mi44xABdyOktFoXQjaB9f9REjfV5mkmGEVrvTawVj0NF5xJved8M1bmluq9VUjLFl51VHi32glXPpTBZf93c4++OFJohdJumpJAeCe70xdUy1nedhbj8cDvd6bc0Vwpie8tdGE+GmLtT9Uu5QY/BDDAgzBnTguLilawl6Nu5vh3em6/JLRB2svQ4mAzbAj/qfVhiqJSyFHjuP5/pUiuZCkQvSZ2z3rr2nDqppFA1G4ixkZl77XBuhb5OzUdaWrFOnCilixY5eWJPgcfDNkTn5BlcKZdP5DvH6ETHAT0WDRkVTP3 NfP3XnLz saRTnbCAJXAvS1gxx8xMz86cp+mD+OzHEISKS11k7T9YJ0N8afbxBxHjbUj4M9UkP4Ad6vVEDXUP1A7GHprphxrhyv3aKE+eSD29pldngthqpwP+JeSNG8GIcKgNAaqAVf0IFyoXsDT297aJoaoowrR2OgOjk4GqkhkfBtZHOV+gpiaI7DOqlUAN85doUYQILzY5X3rjHellif/Ll/BvmVD+GUCsTzkAH5HzaaEXECm0lSlSra9v4QBBAsUhIO2SCyIEq3z02UCTeTAX0UNO0Z5W/6RkIrrKFcocnuTxmK/sXMER7vXVX8iZkRGyBCv87Z9TYnodPpng6O3vPBm3s+mZvUnp76Wyis5IveZoSrzdMESALWBbHDxMWhjhSVAtmt3ba575RTsw4ovF95o1Qy9Lz9MwSmVc/+9XZ+MMpWKiVJKs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 17, 2025 at 11:24=E2=80=AFAM Jason Gunthorpe wro= te: > > On Fri, Jun 13, 2025 at 04:58:27PM +0200, Pratyush Yadav wrote: > > On Sat, Jun 07 2025, Pasha Tatashin wrote: > > [...] > > >> > > >> This weirdness happens because luo_prepare() and luo_cancel() contro= l > > >> the KHO state machine, but then also get controlled by it via the > > >> notifier callbacks. So the relationship between then is not clear. > > >> __luo_prepare() at least needs access to struct kho_serialization, s= o it > > >> needs to come from the callback. So I don't have a clear way to clea= n > > >> this all up off the top of my head. > > > > > > On production machine, without KHO_DEBUGFS, only LUO can control KHO > > > state, but if debugfs is enabled, KHO can be finalized manually, and > > > in this case LUO transitions to prepared state. In both cases, the > > > path is identical. The KHO debugfs path is only for > > > developers/debugging purposes. > > > > What I meant is that even without KHO_DEBUGFS, LUO drives KHO, but then > > KHO calls into LUO from the notifier, which makes the control flow > > somewhat convoluted. If LUO is supposed to be the only thing that > > interacts directly with KHO, maybe we should get rid of the notifier an= d > > only let LUO drive things. > > Yes, we should. I think we should consider the KHO notifiers and self > orchestration as obsoleted by LUO. That's why it was in debugfs > because we were not ready to commit to it. We could do that, however, there is one example KHO user `reserve_mem`, that is also not liveupdate related. So, it should either be removed or modified to be handled by LUO. Mike, what do you think? Pasha