From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA8D6C4361B for ; Fri, 18 Dec 2020 12:33:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 659BB23443 for ; Fri, 18 Dec 2020 12:33:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 659BB23443 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C81A66B006C; Fri, 18 Dec 2020 07:33:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C327C6B0070; Fri, 18 Dec 2020 07:33:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B48866B0071; Fri, 18 Dec 2020 07:33:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0098.hostedemail.com [216.40.44.98]) by kanga.kvack.org (Postfix) with ESMTP id 9FE7C6B006C for ; Fri, 18 Dec 2020 07:33:07 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 5A857181AF5C1 for ; Fri, 18 Dec 2020 12:33:07 +0000 (UTC) X-FDA: 77606342814.30.bee23_5e1850f2743d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id 46D42180B3AB8 for ; Fri, 18 Dec 2020 12:33:07 +0000 (UTC) X-HE-Tag: bee23_5e1850f2743d X-Filterd-Recvd-Size: 5889 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Fri, 18 Dec 2020 12:33:06 +0000 (UTC) Received: by mail-wr1-f48.google.com with SMTP id q18so1981279wrn.1 for ; Fri, 18 Dec 2020 04:33:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=q5KjjPrbn9WR2MdEGDTRtTus2Vw4k9w92nCN62Th8qg=; b=UQKi0zIH+5RBkxjLICF+v+gLFuX5Yn/W4ogPzP5V4rmY3SGR7gUDPduCncrWW7RecZ 7wtPBVcyR2wdwtN+1OkyNp9AM7ZWjYpRGd+2d4UyyrFoJaA0m7I5FJ02AMVCtFIP5YbG H2qh0kxKXwbuOesHnKGk8DP/SkkhpJNP+kc/fm0DCQ+6WjDTe0OK/aM3vqfSKJOgUxnh bsD/Bxdlwo78e+ZrI9p694YPJPkghUmemIZV36cJ1HubQ3mNtLUhCN0zYPfUyV9VSVfp r073sVIb5imENWeRbeLod1SoKtKN+DHcvH165E2ueeKSc/DJjrmvz6unJag37qvpAnU7 i8+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=q5KjjPrbn9WR2MdEGDTRtTus2Vw4k9w92nCN62Th8qg=; b=A6M25FbjfrZvUVSEY5OxjFBfSTmOn/Spo5cBp2F6WuBl6nYf77LjiPqdmFUHubbsNW 8clWjJYY/xywDAFWzjrkbLHJ8oZMxs3XSokKYmkZLPmYQUCazTQ1VnTYtjyzesDmgTjw I7IsVTspTDlFhy4031UNteEysSshDj6tO6kMUPj3Ps6jjfjlUeUVXviO2LXCzbKuU8+W 4T9CzBbplzHDR5g5CCkq0e8LEumCEZdBOGA0TtqXJSEal04bHWzoUg0R9+j1FL1rjKiy dHOItqzpq6DrH0Mx2YPrMC00mn8SB5e8vgCNZKIjD6x5o2QtjAcg3/Cn0TxrW7o9sVRz H51Q== X-Gm-Message-State: AOAM530pTZ7zycMWiX06dSxH6LHWRmknjbUTeqXkn47FhF37eEGORYXf /KFp7TxN+/kpwoPtUYHDmVX179ikeJb1B69opCldnS8q2a8h3g== X-Google-Smtp-Source: ABdhPJzYpFY+fqtYFVTRAo67fRmzRQtjC2ddNY82HbsGhTh9P0LkvQeKOIes+HF7XU76kp1q3P/VHUBHVO7ShP4WC/s= X-Received: by 2002:a17:906:4a4f:: with SMTP id a15mr3763164ejv.541.1608294217306; Fri, 18 Dec 2020 04:23:37 -0800 (PST) MIME-Version: 1.0 References: <20201217185243.3288048-1-pasha.tatashin@soleen.com> <20201217185243.3288048-4-pasha.tatashin@soleen.com> <20201218093653.GS32193@dhcp22.suse.cz> In-Reply-To: <20201218093653.GS32193@dhcp22.suse.cz> From: Pavel Tatashin Date: Fri, 18 Dec 2020 07:23:00 -0500 Message-ID: Subject: Re: [PATCH v4 03/10] mm: apply per-task gfp constraints in fast path To: Michal Hocko Cc: LKML , linux-mm , Andrew Morton , Vlastimil Babka , David Hildenbrand , Oscar Salvador , Dan Williams , Sasha Levin , Tyler Hicks , Joonsoo Kim , mike.kravetz@oracle.com, Steven Rostedt , Ingo Molnar , Jason Gunthorpe , Peter Zijlstra , Mel Gorman , Matthew Wilcox , David Rientjes , John Hubbard , Linux Doc Mailing List , Ira Weiny , linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 18, 2020 at 4:36 AM Michal Hocko wrote: > > On Thu 17-12-20 13:52:36, Pavel Tatashin wrote: > [..] > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > index 469016222cdb..d9546f5897f4 100644 > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -3234,11 +3234,12 @@ static bool throttle_direct_reclaim(gfp_t gfp_mask, struct zonelist *zonelist, > > unsigned long try_to_free_pages(struct zonelist *zonelist, int order, > > gfp_t gfp_mask, nodemask_t *nodemask) > > { > > + gfp_t current_gfp_mask = current_gfp_context(gfp_mask); > > unsigned long nr_reclaimed; > > struct scan_control sc = { > > .nr_to_reclaim = SWAP_CLUSTER_MAX, > > - .gfp_mask = current_gfp_context(gfp_mask), > > - .reclaim_idx = gfp_zone(gfp_mask), > > + .gfp_mask = current_gfp_mask, > > + .reclaim_idx = gfp_zone(current_gfp_mask), > > .order = order, > > .nodemask = nodemask, > > .priority = DEF_PRIORITY, > > @@ -4158,17 +4159,18 @@ static int __node_reclaim(struct pglist_data *pgdat, gfp_t gfp_mask, unsigned in > > { > > /* Minimum pages needed in order to stay on node */ > > const unsigned long nr_pages = 1 << order; > > + gfp_t current_gfp_mask = current_gfp_context(gfp_mask); > > struct task_struct *p = current; > > unsigned int noreclaim_flag; > > struct scan_control sc = { > > .nr_to_reclaim = max(nr_pages, SWAP_CLUSTER_MAX), > > - .gfp_mask = current_gfp_context(gfp_mask), > > + .gfp_mask = current_gfp_mask, > > .order = order, > > .priority = NODE_RECLAIM_PRIORITY, > > .may_writepage = !!(node_reclaim_mode & RECLAIM_WRITE), > > .may_unmap = !!(node_reclaim_mode & RECLAIM_UNMAP), > > .may_swap = 1, > > - .reclaim_idx = gfp_zone(gfp_mask), > > + .reclaim_idx = gfp_zone(current_gfp_mask), > > }; > > > > trace_mm_vmscan_node_reclaim_begin(pgdat->node_id, order, > > I was hoping we had agreed these are not necessary and they shouldn't be > touched in the patch. Thank you for noticing, I was sure I removed these changes, not sure what happened :( They will be gone in the next version. Thank you, Pasha > -- > Michal Hocko > SUSE Labs