From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04FCACD128A for ; Thu, 4 Apr 2024 00:01:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 82F4E6B00B8; Wed, 3 Apr 2024 20:01:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DF376B00BA; Wed, 3 Apr 2024 20:01:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 67FF96B00BB; Wed, 3 Apr 2024 20:01:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 48D4F6B00B8 for ; Wed, 3 Apr 2024 20:01:16 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EA90880620 for ; Thu, 4 Apr 2024 00:01:15 +0000 (UTC) X-FDA: 81969894510.30.2E49535 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by imf04.hostedemail.com (Postfix) with ESMTP id EAEA94000A for ; Thu, 4 Apr 2024 00:01:13 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=N0X44yoK; dmarc=pass (policy=none) header.from=soleen.com; spf=pass (imf04.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712188874; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EouJXf14bYBG3TFDA7FhpXHScaVdR+iW0OTLcyhvMu8=; b=GupuyEhSe2n3vXLWnJTHs9y6jR86jpf3aaXMrO9lLU9K3CYQEgHoG5bm1rQX4uC9NeVcYZ 6VuvWa0Wz4Ee1sh4F6f0sBMDWofmGhuQegi9o8DCZ+AQ0cIhvPSvsm1ZOVW/9tXjXnznc0 RAUSZP/QK2Hq258q2lCF7m/Ukg8Qpq8= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=N0X44yoK; dmarc=pass (policy=none) header.from=soleen.com; spf=pass (imf04.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712188874; a=rsa-sha256; cv=none; b=Ul2vzfwOcDyS8eAjWnoGW5H5lvvhzNxOlfFm7/fbwgrrBGPi+/7MIefQf6guPG8aZlIPJL LCbTxEyyBubUEyUvF4i8cw6e31tUWL23520dEOG0cs+l41f31v0T6fQsQVjkGRD+WC94Hu CM8weYqbZxqyPQ89vZ7ZOiWxBk6jVk0= Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-432ffed0423so2073981cf.1 for ; Wed, 03 Apr 2024 17:01:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen-com.20230601.gappssmtp.com; s=20230601; t=1712188873; x=1712793673; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=EouJXf14bYBG3TFDA7FhpXHScaVdR+iW0OTLcyhvMu8=; b=N0X44yoKaOBfl7U248cI1k0i1JFdBIUEyxyo4zqRg+zhQQb8Ws59dmVINj/7E/vbwk bdRq9Csk+golqEwBG6+zUa61cSc2kWtjmg+oC9yQnEwN/ya53hzriphfYwqV02gCAAAJ UvfaKNdZGGfNnPen7HPYHKVN05lvhzknU2n+I9vZ/+naBiv1BLd2Dt1hdWU558hcVhXq slO4nH/X8e+f6nWC19Isrj4s/hPkLivTup5hDSu6cBfnJJRDLo/QnATJsJEl0XXaqA1k zzPOekHja+H6598jtTLwIceEOyGJJCMHnpk63DAp0Umiswl3FAvprgCX0yI7yF4bdRn6 JtBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712188873; x=1712793673; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EouJXf14bYBG3TFDA7FhpXHScaVdR+iW0OTLcyhvMu8=; b=cMv5S94VXVzskrDgTf7cCL48CBjwdOXsdu8ASLfZlQGioOpyBDpCjYF4JavAmrloNG c/9VlrjF6dALaj2gZ+ibR38XjSgErS6vbx14IXhG3gOIvpnYocn9iqGzYprXhH/IbMro qMbnQrdsGLlvwtJDbCRtoHYKielbbX+eBOzR2fEmzrmIQ4L2QzuB44frKViDc3smu9HS 9NYij24FR6cpIOc6BWMtlvR/Vjkmg2hkEanU3rB0vL/JC50Wn0ojNnL6fZGkyN1/O//G ZO0tkYyVNarFGnolefwTHkTgiBb9UIZPSj7CjYBtk5dGqo/NHfPmXfLMwUS33zEOV//k c2Hw== X-Forwarded-Encrypted: i=1; AJvYcCXpt7UFO0paqh9uVBQTzGn5/dXohVasOo8eb+gP44m9sY0N+HA/il4+6t8vuWEzx/csfh9VoCBWfSapEFUJRpaLDzQ= X-Gm-Message-State: AOJu0YxOS4GAkLOQ0kgSbn7PiGM35Td+5gRGDFRcUf3vScbHk3wTmMSd twjv/62yXg4Og71Dnw3h0m/CAu9QjPE9wLQS/Sj2+hDIxXXYP3RlDpf2Eu8upP5iFrohkaQvt3v /1UhscLCaD4q7k7qMkerfPl1UBuoNmmKfgdCvJg== X-Google-Smtp-Source: AGHT+IGsXyB4D2wJ0imPILoI1sX0/9gh1QXhIS2cWPu5WGcG8wW0R1/3s3Qb93ZqSuEATVQyB05fmjchi9mzxvRVQ7w= X-Received: by 2002:ac8:5786:0:b0:431:82d5:13d5 with SMTP id v6-20020ac85786000000b0043182d513d5mr844572qta.9.1712188872638; Wed, 03 Apr 2024 17:01:12 -0700 (PDT) MIME-Version: 1.0 References: <20240402051154.476244-1-rmclure@linux.ibm.com> <20240402051154.476244-10-rmclure@linux.ibm.com> In-Reply-To: <20240402051154.476244-10-rmclure@linux.ibm.com> From: Pasha Tatashin Date: Wed, 3 Apr 2024 20:00:35 -0400 Message-ID: Subject: Re: [PATCH v12 09/11] poweprc: mm: Implement *_user_accessible_page() for ptes To: Rohan McLure Cc: linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au, christophe.leroy@csgroup.eu, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: EAEA94000A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: jc5uqfxw4439hnriscdbcy5qngtrds9q X-HE-Tag: 1712188873-577216 X-HE-Meta: U2FsdGVkX1+p8CO1EWBHOwX65hpRFf6S6h8QxioWqUogNDhVuCMGynGX/ojGNMrFQbH96GiToCvQHQXWsGfcGG72a5JdOSpzCvuaL9HtF7l2WUl1W8kqqjUNEUvYD1Co6N/b4xJYQ8aXsEDEyT7MnE2jqUBsIZH/vlpSjvsujqUuvMSIiwMxCI8ZHSWZncJDRZi5HFCJEe51PgXs/Mx4xMu9GLkJwmACfywdbUjpU0OHGQ85TwdEvTscbTCDTSWfHzyp8jhBYmAkzt8MGsCVM9ZgOmds6EAD8cDJ/3y3bTUF85bZdojSggdSJGDGFY5uEOM7EIOpT+8ZaTR11QSqdhZ5kU2arTHwXtuda8PrIb1gp3Y9wLANqfABrJVjAg36vogZfmuuEt1s9NdS/5fv1VbeGC7jZx+H9Ge+qQn4C7ViUsPQvdJ22Hi2REne9Zl6A9acFsuoIN2GIegPd8qsmF0IQGnL8DyvZlFDEWxp6CI8rw4aoMsPABFgzgEvdsvuc3BIy1CwB2b1GNzWbHUZhXu1vA/GEYNI2kVsE7hg4qu/oR+uu0NvYvWXyi0lHz5FW/9iT+V7RZzDmfkSbZU0JWbqOIND6BueVPZDi2u5QYTWggi6RMiRw42ebSLd43dXUqrS4a8Tib3RjEx5a0/rEDqOIspGNVRKvk8kbRvjo/5jov8kK0cKI4oJLpM3gRgyDltHfckK0Y+wGxHWWN5hg5yGKdP74OHX9ap7s1xRKFicvb/HVQMCg/FCDNXkjuF/hwgkMa0188HRqtnUk03/umqwJaR7S7Hvlu4CKiaPS5sigtvDccvF1B3vRLPfwkpuAkMcoIvFNDKWQa2e+XbzOQzrgkjKXZfU8PHLYLiKGjMiG4DRJ8iakqM/CKndEcWkXgu+ryDNugVRxQ34zzeC12Lokk5E7vQu3GAYcDXVSVRL0/01+KWwrcNjqigzFfGYgYVJ4NcQunT3sAHqZYK iID99S4P pINGZ/lhE96TL1yyB0r4mEqN4worDl7wRIBNLU6EZtrclllb4ne+SSPKvCWmQ4YZAKYhQTKZlxyl6h/F5wYYtQv6r3RXiJIuhnzEWtWJxa6Jml/zEAMDx0cmgu8X/b23NCxRhnOn6s1BB/dx9uG6mzfERO5bjpUsDgNlFoIUhylsIRyPMYGQ48suOR54/z3d2Q3BhwECOewGbGO2PGBqUN0KzKU9S8P42nvHx6j3jxEDngz/9psIWJ6WHKV9B5mVdR4DwGaihQZuUV9TM1nmmcyRjjUUG6yJ/G3nfrcrjzPzvb0xt3z0uwRDXku4TNCufgBROLkpDyQpDx+ow3EKlWsuaWNZjULQCVFUiqlbiBC6x+MmB4XAk6DqUMNqWxhcPgu4UkxAOOoCDPMFFrCpbalFgsIYItpYYv1BsuWCdWAIxgCTZk+EvjmP+YqQrHkNU1daKqD8HfDqJ5ELiWBoWttLBNA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.061612, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 2, 2024 at 1:13=E2=80=AFAM Rohan McLure = wrote: > > Page table checking depends on architectures providing an > implementation of p{te,md,ud}_user_accessible_page. With > refactorisations made on powerpc/mm, the pte_access_permitted() and > similar methods verify whether a userland page is accessible with the > required permissions. > > Since page table checking is the only user of > p{te,md,ud}_user_accessible_page(), implement these for all platforms, > using some of the same preliminary checks taken by pte_access_permitted() > on that platform. > > Since Commit 8e9bd41e4ce1 ("powerpc/nohash: Replace pte_user() by pte_rea= d()") > pte_user() is no longer required to be present on all platforms as it > may be equivalent to or implied by pte_read(). Hence implementations of > pte_user_accessible_page() are specialised. > > Signed-off-by: Rohan McLure Reviewed-by: Pasha Tatashin