From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F0CDC3DA4A for ; Mon, 5 Aug 2024 18:41:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B8D66B0088; Mon, 5 Aug 2024 14:41:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 93FFA6B0092; Mon, 5 Aug 2024 14:41:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E12A6B009D; Mon, 5 Aug 2024 14:41:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5C3506B0088 for ; Mon, 5 Aug 2024 14:41:29 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0F46F140208 for ; Mon, 5 Aug 2024 18:41:29 +0000 (UTC) X-FDA: 82419059898.30.015C8A2 Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) by imf17.hostedemail.com (Postfix) with ESMTP id 1E56140025 for ; Mon, 5 Aug 2024 18:41:25 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=EVqDm0DO; dmarc=pass (policy=none) header.from=soleen.com; spf=pass (imf17.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.167.179 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722883278; a=rsa-sha256; cv=none; b=BvvoFA0VlX8K6fa/ukK+RkeJjLWAIamF0uVKIePqtLG0yOElolPYb8yTE6zgMVYKsC4t8U N4q9htfmwcilIvIfLaAp9lNjRYLsRdmSMu3DsiVPVjyebArZvzBvWVVd/ZpM6IIuAO/Z/0 gG/vG4lxAYugiwxewcPrh46uyrju9nc= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=EVqDm0DO; dmarc=pass (policy=none) header.from=soleen.com; spf=pass (imf17.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.167.179 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722883278; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nXDR7qiLrGhxm4QaBcXkbXKBNxx4m/1amTQ3OxtKpcA=; b=oMr7L2CIJx+0sKH0+0kAs4KXJGzqKegeco6cjLDB09tQ5/wMe4bDvBV9tZmJUWkNWnnyTN byT+YABrX6zongI1hMnMnc/PHqJUkKqEQgkPHqs7FnVznVd+WmmKDAE7nyO43cQt7+DUwA Fy9GEj7AIJt6Fv4y4jy1Mj25h/ccEU8= Received: by mail-oi1-f179.google.com with SMTP id 5614622812f47-3db1d4dab7fso6612534b6e.1 for ; Mon, 05 Aug 2024 11:41:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen-com.20230601.gappssmtp.com; s=20230601; t=1722883285; x=1723488085; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nXDR7qiLrGhxm4QaBcXkbXKBNxx4m/1amTQ3OxtKpcA=; b=EVqDm0DOiCLr3QNGTQp7Il0JBpGJzbWf6+KNxY565/tgdzzRLlacPv1+NU5GXlnHIN BG6W+Q/fzEbjxCAoQ2iWXM3WH1UWBlRZDzu2Ke23wGFud+MKOKOg4a37h2t84WdgEWKJ tUNjDO6iaxBbHtZvgW+fhGE2HCg5aIqVgtFqKpzOhHO5MtC+vmcD4Xu6iCo5tmuwTTDb 3iCOiP0mwz8XoweZLIwRvkttNkwVH6Uax1ysCQ9x98EyAvfi0dJJm330OJ46HmxJFq5q UBcATLY6rOyr5Mrov6BOkeiUVYIqopsdM8kAamwjwPBpoFibEKJ7Vu/9KBckPDo+1kvf FWoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722883285; x=1723488085; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nXDR7qiLrGhxm4QaBcXkbXKBNxx4m/1amTQ3OxtKpcA=; b=JNyKpFP24+1VShSzddAuIDSBS9o+fq635g84LGj3e3GII1NLouPFcjfq7bDLpzoBD7 EVS/zuh6/33UEkBMQHC7XyzrmhFoNV8I7z9+Bcja0jZ6XpNKclrZ0qDOoTB1jDT+ostu f6K+xiahCHu9V3RzBGKp6c8b2Wz+62OJ+c/WarmuM6WAYQhV15fzJZEh5DLlCdJAmO+/ hJyQ5V66aVOEDOt+tCOr997hPPvRzqCbjEXMpMgU/WXVVzZ3MtCEcr8KGGCoA7TYUDlp Z3ez+t4PgKDLHuy+eETaLRkE+Q+GXqDscDHQIe1VCFOb7OxnDlSMZcwFgHMl/x+MqTyN Imlw== X-Forwarded-Encrypted: i=1; AJvYcCVXCkmcIBxlUjF8tsrp/arlqcVTZBwW0Wl8X+pzeUVWExafF6V2mGU8nzrF4+R865/vo060AbrRvZHKAFqV1m7d0y4= X-Gm-Message-State: AOJu0YyUMS4/Kx5NbvGPmX14qJJlvmrZadfr/35rz+UMQKIEM9nOcFPJ M7GKl7cnYjVRdBLt7/Krmuvc86HplPzgYbQ1TW6TWLl19T0XIhZEm9znT8kk4VjhVObDLdAn6q3 KODH1e27kV2Rs52kUvjl0bCFUYYfCvkDaWX7o2A== X-Google-Smtp-Source: AGHT+IELiX1V707IcRryP1iDqdmXzsN+eMp7QFXOkdeEr9fYlKlUd987VH8uQ7e08ycHl28xM7Hu7WLB3uBVe3WBGzg= X-Received: by 2002:a05:6808:191a:b0:3da:e02f:eb8e with SMTP id 5614622812f47-3db5583e3e9mr18020289b6e.43.1722883285128; Mon, 05 Aug 2024 11:41:25 -0700 (PDT) MIME-Version: 1.0 References: <20240605222751.1406125-1-souravpanda@google.com> In-Reply-To: From: Pasha Tatashin Date: Mon, 5 Aug 2024 14:40:48 -0400 Message-ID: Subject: Re: [PATCH v13] mm: report per-page metadata information To: Alison Schofield Cc: Sourav Panda , corbet@lwn.net, gregkh@linuxfoundation.org, rafael@kernel.org, akpm@linux-foundation.org, mike.kravetz@oracle.com, muchun.song@linux.dev, rppt@kernel.org, david@redhat.com, rdunlap@infradead.org, chenlinxuan@uniontech.com, yang.yang29@zte.com.cn, tomas.mudrunka@gmail.com, bhelgaas@google.com, ivan@cloudflare.com, yosryahmed@google.com, hannes@cmpxchg.org, shakeelb@google.com, kirill.shutemov@linux.intel.com, wangkefeng.wang@huawei.com, adobriyan@gmail.com, vbabka@suse.cz, Liam.Howlett@oracle.com, surenb@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, willy@infradead.org, weixugc@google.com, David Rientjes , nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, yi.zhang@redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 1E56140025 X-Rspamd-Server: rspam01 X-Stat-Signature: ohrsm8aj3amet1xfkw6ajzrq6e8cxqp9 X-HE-Tag: 1722883285-13423 X-HE-Meta: U2FsdGVkX1/0tEh7GgzHC3cjYrFyH0zirmr7UxOnB3DaBxbsoeJ+GA+uR/ALTSuM3gBjGWPGBPKRIdLhHhZnb9LTMukH1BgRcnBPv4384r/MlO9CFfkPDCHWEnet/396JS1h6x2aGbGGpy6qV6ou8MFfjJ1M07/7LMP2/3EkxNvkuo80MYPtoDqB/zQB6nlJnYtzIMVfQNo7LHNgcT9vExLGusv7HtSOlv4IMfPRfGxV7mXmAsNTKA50TPd/7JeoKVgs3slERQ0HuuEGhXCPN9nKXgbtg/piINFdWwGyLmGv4y9/MEuFBBn/nJ5NQxjLmgFDLQthLLyBpYVWgisoKnRkbVSoV8OzSk27QDmo+U+zohYpAusevUtxY1j8RjdHzU89AZkyqfTT2KFuEZ2dEd5o0q5j0DCTHM8V59tqRAIRn/PkJdE0VEx/cqzxEZfXZ+EXTmZr5utoNASPXekD5ANf7/6NsfYWoj+mLXXeg/3dcU4pZvkqym6l0wd2CMUOdybxss/x+Nt4bOaso44HynlbDPZK/46GqLYWgzuXIixGI9grmEMo4nKuqK68wXx53sp7XmdaoI/jz4H6wwPQEgOs/icRQWpmOiQ9Z5YPQflwmi3fwMB9XJFwLB09E2T0Uy3COl+/+vSkXm3AKaB1+lS9UIzKRi58bHoGCp5z/x8xpnmQHHGQOlQDzuwbGHMp2+v8yPZZy2MvDzRfubVPLQn6suopEw8CZjFRkliNXqRP0IxQuO6JAI9uevyKjc3eXLnauo7tUzg1Ci/ubmgKySnrUiHPBy6hdylbD+AEoMqgEw/ELJx9gEKce0FnvLfeLXdUpQM+PduL8PC1lG2PQMKGgJTwut7qFEkljOvqakzMrDYVy5fs7ifuvM+UgDDw+bQALxsASlhc0JJESPLZlJhMalRieRQvWsWxDEq/sP4NZoxSjQUoxZ/he+u8PoAsEWlhaJoUy7f+cUxHA/A HUdHb4u0 P/8+HJharBqdD0qB7E8zJxIydeRIpJri6yMrYa8SQLyS4cPYk8BVk7LURaweyhf1rHtXQuT1t/Zd1Csd5UHUfpsRpuWB5w7y7s3H3XWOxbjuy9GZi0AwcOGQ3c0PH0AGM8TnvZQT2qlsM5ml9Yj8jIjBoPm4LWTLMYgFVpgEJiVxB9dzU8EZiwZboQ3aEFGtL8Jr8vOGOGWKaTqtaROniu0dVrT/kj9RPDjsWYHqYA47wFk2bgM1p4qt/PfOELrtXT88stzGLsYBCg840MU9t7lYd5X/4/ODrwOKi36dOAvz/l+ow4LWq/AoziuTPiLHnI4RVqe2xztxNO7XiIzWunxs57EYgtmEeHqzsITa0SRd7HhB3aUrlLDkaOnaqErsDYdTzjJ7bDTsM1B9X2NBUe8Ft99Z6+wPq9kh+S5fHYE0G8cXCCl2nbuQOR4elZo53B7OtOuifzrK8h24K4cVsDxfXqU5BPQLOO4QHsUw2RtoO4mw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Aug 2, 2024 at 3:02=E2=80=AFPM Alison Schofield wrote: > > ++ nvdimm, linux-cxl, Yu Zhang > > On Wed, Jun 05, 2024 at 10:27:51PM +0000, Sourav Panda wrote: > > Today, we do not have any observability of per-page metadata > > and how much it takes away from the machine capacity. Thus, > > we want to describe the amount of memory that is going towards > > per-page metadata, which can vary depending on build > > configuration, machine architecture, and system use. > > > > This patch adds 2 fields to /proc/vmstat that can used as shown > > below: > > > > Accounting per-page metadata allocated by boot-allocator: > > /proc/vmstat:nr_memmap_boot * PAGE_SIZE > > > > Accounting per-page metadata allocated by buddy-allocator: > > /proc/vmstat:nr_memmap * PAGE_SIZE > > > > Accounting total Perpage metadata allocated on the machine: > > (/proc/vmstat:nr_memmap_boot + > > /proc/vmstat:nr_memmap) * PAGE_SIZE > > > > Utility for userspace: > > > > Observability: Describe the amount of memory overhead that is > > going to per-page metadata on the system at any given time since > > this overhead is not currently observable. > > > > Debugging: Tracking the changes or absolute value in struct pages > > can help detect anomalies as they can be correlated with other > > metrics in the machine (e.g., memtotal, number of huge pages, > > etc). > > > > page_ext overheads: Some kernel features such as page_owner > > page_table_check that use page_ext can be optionally enabled via > > kernel parameters. Having the total per-page metadata information > > helps users precisely measure impact. Furthermore, page-metadata > > metrics will reflect the amount of struct pages reliquished > > (or overhead reduced) when hugetlbfs pages are reserved which > > will vary depending on whether hugetlb vmemmap optimization is > > enabled or not. > > > > For background and results see: > > lore.kernel.org/all/20240220214558.3377482-1-souravpanda@google.com > > > > Acked-by: David Rientjes > > Signed-off-by: Sourav Panda > > Reviewed-by: Pasha Tatashin > > This patch is leading to Oops in 6.11-rc1 when CONFIG_MEMORY_HOTPLUG > is enabled. Folks hitting it have had success with reverting this patch. > Disabling CONFIG_MEMORY_HOTPLUG is not a long term solution. > > Reported here: > https://lore.kernel.org/linux-cxl/CAHj4cs9Ax1=3DCoJkgBGP_+sNu6-6=3D6v=3D_= L-ZBZY0bVLD3wUWZQg@mail.gmail.com/ Thank you for the heads up. Can you please attach a full config file, also was anyone able to reproduce this problem in qemu with emulated nvdimm? Pasha