From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93B6EC77B7A for ; Tue, 16 May 2023 14:15:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A64E8900003; Tue, 16 May 2023 10:15:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A1555900002; Tue, 16 May 2023 10:15:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DD00900003; Tue, 16 May 2023 10:15:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 801D8900002 for ; Tue, 16 May 2023 10:15:07 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 03B3F402E2 for ; Tue, 16 May 2023 14:15:06 +0000 (UTC) X-FDA: 80796315054.29.FAB04E0 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) by imf30.hostedemail.com (Postfix) with ESMTP id 017F280014 for ; Tue, 16 May 2023 14:15:03 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=afSUZJer; spf=pass (imf30.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.222.177 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684246504; a=rsa-sha256; cv=none; b=B3CSbpLaVamvnyKeNrBBInHx5+TQAUUOZgibeAkvHcpzTMXfDfZQJ1SkuE+8ZVq+5ycsqg TymLFi4qugigZOmzUKHd9KLO4Vy24yqgqvcTbJo8yjHsPqlZ7ijRF0az+fyBtKSR1JTdC/ Jr+0yEdpuV4simYfG3Y9pb2Ze4V+4xg= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=afSUZJer; spf=pass (imf30.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.222.177 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684246504; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MjmWo+hCpEtivWOwri7/iADoZ8E9ycZlQARPYEOsBeY=; b=cpWv3D8sUixTPaWc2NzrdnxzsVmEmET8ouVZHGxsxdNKgGN4g8PfPkjdJneFNmcKWAS9Se FoDdVBMSBkXjgz9ezZ43itKTN7cogSJWba0kD6JavBM/gMleYxiExvWk/r7CoeEV9F4bcA AaQhhqUsHTSjugTr+cBVivWJHzUIjHI= Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-7577ef2fa31so276486885a.0 for ; Tue, 16 May 2023 07:15:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1684246502; x=1686838502; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=MjmWo+hCpEtivWOwri7/iADoZ8E9ycZlQARPYEOsBeY=; b=afSUZJeraE4UXuA9KVN1ySJjEKq3ywhpoGJL+kSOCkxHroh8Tts50u/trVlmLUkGuw fxZEtbMs0Pf2xg7vQ1t4106ZLILJpzhQ879/C96SPU7fZ42mBXATWzkj3KYOvO1J5/Tu j3eanUCd5R6IaQrESgZJaf67f44HQts2P2zwTns2bqxbOQzj+b+0ZaTySHMTwAA7Fmzh DYlPGfIbtSI3AzxuPALs84Akj50j4lLLfkWugNfAvYgWeajKxA/vLM5NEvkJ++mMS7pq 4lkHnv+onGhYmjsbQNlZOuk0rUzPs48NMzSTFjQl70O+nqNkWJKOzIPF3UPK/+IRKSFK 1wHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684246502; x=1686838502; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MjmWo+hCpEtivWOwri7/iADoZ8E9ycZlQARPYEOsBeY=; b=XUfwabfd/08xjq3gmoaDZ7RwjReG8kVWC1A/X0GPFPeKl8krPa/1gfLSiQrcA60Bf1 GYSVsgBXQYeL9MOz4j93vB45RajF9SRr6lkH3pzSn81etRcaRRj+GmX0JOWCKt0Qp22S DgK2HZO3m+prKH7HIjfOJYZhgn9jWOB9lgX1tjGhtb+nXPpJdCvBa2Jp6il+mLdisNc6 1RXzLNRDX/XN7+NF5ML9xdTvSf7cu3L+NVBdy1+2DjgPiMqGy4aQPVpO7NE48+Fg5E7i THv1/4yU5c1vb1XTXeeWuH9GvZ7tzbtyQvQghKaObAIGzR1DvFnqkGcXCj9zpjGR8oay hGuQ== X-Gm-Message-State: AC+VfDx8ENk9UwzHI9AGY5ZTiRwA73UMTuV+0Esl0zbhsgXti9N+5pry feaFwRKlHAeJCAPcEqQZuNjEJv/UjJkOhYzlNmYoiA== X-Google-Smtp-Source: ACHHUZ57FJsfJFFk4qJNOuOhjLPxnKXdzMSpLYiGr7X8IDSjhV+PkeEn4XFSMuguWShJVzNJ1+1AdvhqFy+Uf+Vr+4o= X-Received: by 2002:ac8:7d10:0:b0:3f5:2582:65db with SMTP id g16-20020ac87d10000000b003f5258265dbmr15289020qtb.29.1684246502695; Tue, 16 May 2023 07:15:02 -0700 (PDT) MIME-Version: 1.0 References: <20230515130958.32471-1-lrh2000@pku.edu.cn> <20230515130958.32471-5-lrh2000@pku.edu.cn> In-Reply-To: From: Pasha Tatashin Date: Tue, 16 May 2023 10:14:26 -0400 Message-ID: Subject: Re: [PATCH v2 4/4] mm: page_table_check: Ensure user pages are not slab pages To: David Hildenbrand Cc: Ruihan Li , linux-mm@kvack.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Matthew Wilcox , Andrew Morton , Christoph Hellwig , Alan Stern , Greg Kroah-Hartman , syzbot+fcf1a817ceb50935ce99@syzkaller.appspotmail.com, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 017F280014 X-Stat-Signature: t8165wraudffdw9h3pw11ppgowtoohxi X-HE-Tag: 1684246503-924855 X-HE-Meta: U2FsdGVkX1/JQkxklI2Qw9ryBPwJ5GALad+Qj5WR9EfqIFVzHjMh9mmNkV57cYTb/gSbeVTV8Xh9wzrgprUtCFHd11z7I8YVPqBugrKKLPv2bNCMcLqNjV/9nBQCp+7GZOFQnBiC5cn4D1blGLtUiACVzuzvquePndkpqC5QosUnAUi5WybA0x2rCZ5GttFtr8qJuHapupcJQylL9dSrPJ0Rb++Z+olqvk0ioz/CVLr9aorfZkTGp1KdvZxsmXNbj4G1hCWWgabXi2Z8C9JhO5WTbQpDFQhmN4bbzmGUKqBdAyFtikTXtp6CR/+36UT7MX1XgYgEsmje3qEoZ36wNgyudOi3dJLtGMlJmO4i+jhqzBGMYYtd186ptkBauj6G5FuxmvZ8BusE7JqYHsQXwN6aHoxHMJm4Wh1LegT7my3HPvjBudjM0KKcRKrfgGPqy+jTib0rMMPmhYik4BVAyWeepF88zVGd/mlWw9J67PMXRHtezqupdWjLQFm/jXsz54fW29B23cBf0Yrp1KztcniNdz1OWOCJE+2tvW8j6y+XIAQw0v2VvpydST/5bhHRM5ZMBvCaTL4/8wx07JFF5amacBcxWX68iOMZsYYlPDqtmBZbwoPG9QjUUrxBn1unBE6b3doaWbphW8ZfQOgk+ZecaJoZSdq0Jya4FvRb6P6TNPuikMd3P+glhaegqtZYhUYJLYGevYq9l4S5dcQnGbzTNGo6QuS3M8pQ/n6MKrT6kmDRtLWiBn+haWlodN+uFc1YkM1hqC2XBKzPxqhXHOjdc02Dx5JTgC4zTnOxyLMcXwiiYg6o9NxxNhCf5kAiG2MSzMsgSLE4I7Wc1iHDS6720bNTq9UrzuaY4U0dEYHSq7zndc7+oGgalyWDGSfnan797WrWfz+gS55HcNEOLLiHSMiCC+bAvmnwdnYsrcEYLesasF1bJBkoTNH/56sTSlqVmI8n/6ASP2cm9d9 C0++wZWW JTYpu+6L/cnbivAZCsXpaBIcU43jiIBjpltVH2vVgHVAxy5BgoakCbjsqgU1xxIKh14grj2K/naLcl1lJtOlcBIBgyujsLwioyqIYTU33Omjx/5tlQ2lbN3w+Aikn1ET756X6TgR9JeAbTj+kCxNRBG+AAUVFNzfzW7dGcuL7EQruaGf0m5zU/xHfNuGjNEVXg3PRF40hoHG39dfj/+sX8H/VV4N6ELHaf1ESr4XVj+v6I3JP+lvMVClcyVsA5k/YgVmF60jl4WpIiTKaZ+Z9MbJtuQSTh3TcJLVO7c9d29c2OOTqCSFEy9Q0AbF58U8bcAJxD+4s39XJm62Ri8L7Zw1en7X+CoFi24rfWQDboldTg/W8ISAVEnnx+Muv770V1cqQ+2m4bmEf1DYnxMaREgtSc23vJbKtTX8Z9c97llRxXH56OopELDKGAQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > >> Acked-by: Pasha Tatashin > >> > >> I would also update order in mm/memory.c > >> static int validate_page_before_insert(struct page *page) > >> { > >> if (PageAnon(page) || PageSlab(page) || page_has_type(page)) > >> > >> It is not strictly a bug there, as it works by accident, but > >> PageSlab() should go before PageAnon(), because without checking if > >> this is PageSlab() we should not be testing for PageAnon(). > > > > Right. Perhaps it would be better to send another patch for this > > separately. Yes, as a separate from this series patch would work. > > Probably not really worth it IMHO. With PageSlab() we might have > PageAnon() false-positives. Either will take the same path here ... That is correct, it works by accident, but it is not a good idea to keep a broken logic at least because it may be copied into other places.